All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Amlie <kristian.amlie@mender.io>
To: openembedded-core@lists.openembedded.org
Subject: do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH.
Date: Wed, 26 Apr 2017 17:03:50 +0200	[thread overview]
Message-ID: <1493219031-12843-1-git-send-email-kristian.amlie@mender.io> (raw)

This is a direct followup from the earlier f6a064d969f414 commit in wic. It
works more or less the same way: The variable specifies a list of directories
relative to the root of the rootfs, and these directories will be excluded from
the resulting rootfs image. If an entry ends with a slash, only the contents are
omitted, not the directory itself.

This is early feedback call, and several things are missing here (see
below). However, I would like to know if at least the basic approach is
acceptable. Reviewers pressed on time really only need to look at the topmost
hunk as well as the last couple of lines of the two functions. Those show what
the basic idea is.

What's missing:

* Documentation

* Test coverage

* Respecting IMAGE_ROOTFS_EXCLUDE_PATH is a behavior change, and isn't
  appropriate for all image creators. In fact, for the the main use case [1] to
  work it must not always be respected.

My idea for the last point is that the variable will not be respected by
default, and each of the pure filesystem image creators (btrfs, ext2/3/4, etc)
will set a flag that mark their image creator as a "pure filesystem", which
would respect this variable. Image creators that make partitions, however,
should not respect it, because they will use wic for that purpose instead, and
then they need to have access to the entire rootfs. Hence they should not set
the flag.

I'm imagining something like this:

  d.setVarFlag('do_image_%s' % t, 'respect_exclude_path', '1')

although I'm not sure if that's the best approach (tips are welcome).

[1] The use case for this feature is the following: We are creating two types of
images in Mender: One complete partitioned image, and one image containing only
the rootfs. In order to be able to populate non-rootfs partitions, we want to
use the regular bitbake recipes for building these components, but then exclude
certain directories from the rootfs image. Using wic, we are adding those
directories back into the partitioned image, but under different
partitions. Unlike the rootfs image, the other partitions are not expected to be
rebuilt after the first rollout.

-- 
Kristian



             reply	other threads:[~2017-04-26 15:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26 15:03 Kristian Amlie [this message]
2017-04-26 15:03 ` [PATCH] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature Kristian Amlie
2017-05-22  7:08 ` do_image: Adding support for IMAGE_ROOTFS_EXCLUDE_PATH Kristian Amlie
2017-05-22  8:46   ` Ed Bartosh
2017-05-22  9:38     ` Kristian Amlie
2017-05-30  7:46       ` Kristian Amlie
2017-05-30  7:46         ` [PATCH v2] do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature Kristian Amlie
2017-06-19  9:01           ` Kristian Amlie
2017-06-19 14:01             ` Kristian Amlie
2017-06-19 14:01               ` [PATCH v3] " Kristian Amlie
2017-08-23 11:44                 ` [PATCH v4] " Kristian Amlie
2017-08-23 11:46                 ` Kristian Amlie
2017-08-23 11:46                   ` [PATCH v4] " Kristian Amlie
2017-08-23 12:39                     ` Kristian Amlie
2017-08-23 12:39                       ` [PATCH v5] " Kristian Amlie
2017-08-23 12:47                         ` Richard Purdie
2017-08-23 13:19                           ` Kristian Amlie
2017-08-28 15:47                             ` Kristian Amlie
2017-08-28 15:47                               ` [PATCH v6] " Kristian Amlie
2017-09-18  6:45                                 ` Kristian Amlie
2017-10-13  9:08                                   ` Kristian Amlie
2017-10-13  9:08                                     ` [PATCH v7] " Kristian Amlie
2017-10-13 10:37                                     ` [PATCH v6] " Alexander Kanavin
2017-10-13 11:22                                       ` Kristian Amlie
2017-11-22 13:13                                       ` Kristian Amlie
2017-11-22 13:13                                         ` [PATCH v7] " Kristian Amlie
2017-11-22 13:31                                         ` [PATCH v6] " Alexander Kanavin
2017-11-22 13:35                                           ` Kristian Amlie
2018-01-25 10:33                                           ` Kristian Amlie
2018-01-25 10:33                                             ` [PATCH v7] " Kristian Amlie
2018-01-25 10:58                                               ` Martin Hundebøll
2018-02-13  1:29                                               ` Cal Sullivan
2018-03-15  9:29                                                 ` Kristian Amlie
2017-08-23 12:46                       ` Richard Purdie
2017-08-23 13:19                         ` Kristian Amlie
2017-05-30  8:01       ` ✗ patchtest: failure for do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature. (rev2) Patchwork
2017-06-19 14:31       ` ✗ patchtest: failure for do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature. (rev3) Patchwork
2017-08-23 12:04       ` ✗ patchtest: failure for do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature. (rev4) Patchwork
2017-08-23 12:04       ` ✗ patchtest: failure for do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature. (rev5) Patchwork
2017-08-23 13:04       ` ✗ patchtest: failure for do_image: Implement IMAGE_ROOTFS_EXCLUDE_PATH feature. (rev6) Patchwork
2017-08-23 15:12         ` Leonardo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493219031-12843-1-git-send-email-kristian.amlie@mender.io \
    --to=kristian.amlie@mender.io \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.