* [U-Boot] [PATCH] armv8: minor fix to comment for enabling SMPEN bit
@ 2017-04-27 4:36 Dinh Nguyen
2017-04-27 16:59 ` York Sun
2017-05-15 23:18 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Dinh Nguyen @ 2017-04-27 4:36 UTC (permalink / raw)
To: u-boot
The SMPEN bit is located in the cpuectlr_el1 register and not the
cpuactlr_el1 register. Adjust the comment accordingly and also fix
a spelling error.
Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
CC: Mingkai Hu <mingkai.hu@nxp.com>
CC: Gong Qianyu <Qianyu.Gong@nxp.com>
CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
CC: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
CC: York Sun <york.sun@nxp.com>
CC: Albert Aribaud <albert.u.boot@aribaud.net>
CC: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/arm/cpu/armv8/start.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S
index 62d97f7..354468b 100644
--- a/arch/arm/cpu/armv8/start.S
+++ b/arch/arm/cpu/armv8/start.S
@@ -86,12 +86,12 @@ save_boot_params_ret:
0:
/*
- * Enalbe SMPEN bit for coherency.
+ * Enable SMPEN bit for coherency.
* This register is not architectural but at the moment
* this bit should be set for A53/A57/A72.
*/
#ifdef CONFIG_ARMV8_SET_SMPEN
- mrs x0, S3_1_c15_c2_1 /* cpuactlr_el1 */
+ mrs x0, S3_1_c15_c2_1 /* cpuectlr_el1 */
orr x0, x0, #0x40
msr S3_1_c15_c2_1, x0
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] armv8: minor fix to comment for enabling SMPEN bit
2017-04-27 4:36 [U-Boot] [PATCH] armv8: minor fix to comment for enabling SMPEN bit Dinh Nguyen
@ 2017-04-27 16:59 ` York Sun
2017-05-15 23:18 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: York Sun @ 2017-04-27 16:59 UTC (permalink / raw)
To: u-boot
On 04/26/2017 09:36 PM, Dinh Nguyen wrote:
> The SMPEN bit is located in the cpuectlr_el1 register and not the
> cpuactlr_el1 register. Adjust the comment accordingly and also fix
> a spelling error.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> CC: Mingkai Hu <mingkai.hu@nxp.com>
> CC: Gong Qianyu <Qianyu.Gong@nxp.com>
> CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> CC: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> CC: York Sun <york.sun@nxp.com>
> CC: Albert Aribaud <albert.u.boot@aribaud.net>
> CC: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> arch/arm/cpu/armv8/start.S | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/armv8/start.S b/arch/arm/cpu/armv8/start.S
> index 62d97f7..354468b 100644
> --- a/arch/arm/cpu/armv8/start.S
> +++ b/arch/arm/cpu/armv8/start.S
> @@ -86,12 +86,12 @@ save_boot_params_ret:
> 0:
>
> /*
> - * Enalbe SMPEN bit for coherency.
> + * Enable SMPEN bit for coherency.
> * This register is not architectural but at the moment
> * this bit should be set for A53/A57/A72.
> */
> #ifdef CONFIG_ARMV8_SET_SMPEN
> - mrs x0, S3_1_c15_c2_1 /* cpuactlr_el1 */
> + mrs x0, S3_1_c15_c2_1 /* cpuectlr_el1 */
> orr x0, x0, #0x40
> msr S3_1_c15_c2_1, x0
> #endif
>
Thanks for fixing this.
Reviewed-by: York Sun <york.sun@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] armv8: minor fix to comment for enabling SMPEN bit
2017-04-27 4:36 [U-Boot] [PATCH] armv8: minor fix to comment for enabling SMPEN bit Dinh Nguyen
2017-04-27 16:59 ` York Sun
@ 2017-05-15 23:18 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2017-05-15 23:18 UTC (permalink / raw)
To: u-boot
On Wed, Apr 26, 2017 at 11:36:03PM -0500, Dinh Nguyen wrote:
> The SMPEN bit is located in the cpuectlr_el1 register and not the
> cpuactlr_el1 register. Adjust the comment accordingly and also fix
> a spelling error.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> CC: Mingkai Hu <mingkai.hu@nxp.com>
> CC: Gong Qianyu <Qianyu.Gong@nxp.com>
> CC: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> CC: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> CC: York Sun <york.sun@nxp.com>
> CC: Albert Aribaud <albert.u.boot@aribaud.net>
> CC: Masahiro Yamada <yamada.masahiro@socionext.com>
> Reviewed-by: York Sun <york.sun@nxp.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170515/3fa13e11/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-15 23:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-27 4:36 [U-Boot] [PATCH] armv8: minor fix to comment for enabling SMPEN bit Dinh Nguyen
2017-04-27 16:59 ` York Sun
2017-05-15 23:18 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.