All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janusz Lisiecki <janusz.lisiecki@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Driver Project Developer List
	<driverdev-devel@linuxdriverproject.org>,
	Janusz Lisiecki <janusz.lisiecki@gmail.com>
Subject: [PATCH 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs
Date: Sat, 29 Apr 2017 22:58:42 +0200	[thread overview]
Message-ID: <1493499528-27307-3-git-send-email-janusz.lisiecki@gmail.com> (raw)
In-Reply-To: <1493499528-27307-1-git-send-email-janusz.lisiecki@gmail.com>

Replace CamelCase variable name with underscores to comply
with the standard kernel coding style.

Signed-off-by: Janusz Lisiecki <janusz.lisiecki@gmail.com>
Reviewed-by: Tobin C. Harding <me@tobin.cc>
---
 drivers/staging/ks7010/ks_hostif.c | 24 ++++++++++++------------
 drivers/staging/ks7010/ks_hostif.h |  2 +-
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
index 1f8405e..856f714 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -1696,12 +1696,12 @@ void hostif_phy_information_request(struct ks_wlan_private *priv)
 static
 void hostif_power_mngmt_request(struct ks_wlan_private *priv,
 				unsigned long mode, unsigned long wake_up,
-				unsigned long receiveDTIMs)
+				unsigned long receive_dtims)
 {
 	struct hostif_power_mngmt_request_t *pp;
 
-	DPRINTK(3, "mode=%lu wake_up=%lu receiveDTIMs=%lu\n", mode, wake_up,
-		receiveDTIMs);
+	DPRINTK(3, "mode=%lu wake_up=%lu receive_dtims=%lu\n", mode, wake_up,
+		receive_dtims);
 	/* make primitive */
 	pp = kmalloc(hif_align_size(sizeof(*pp)), KS_WLAN_MEM_FLAG);
 	if (!pp) {
@@ -1713,7 +1713,7 @@ void hostif_power_mngmt_request(struct ks_wlan_private *priv,
 	pp->header.event = cpu_to_le16((uint16_t)HIF_POWERMGT_REQ);
 	pp->mode = cpu_to_le32((uint32_t)mode);
 	pp->wake_up = cpu_to_le32((uint32_t)wake_up);
-	pp->receiveDTIMs = cpu_to_le32((uint32_t)receiveDTIMs);
+	pp->receive_dtims = cpu_to_le32((uint32_t)receive_dtims);
 
 	/* send to device request */
 	ps_confirm_wait_inc(priv);
@@ -2270,44 +2270,44 @@ void hostif_sme_multicast_set(struct ks_wlan_private *priv)
 static
 void hostif_sme_powermgt_set(struct ks_wlan_private *priv)
 {
-	unsigned long mode, wake_up, receiveDTIMs;
+	unsigned long mode, wake_up, receive_dtims;
 
 	DPRINTK(3, "\n");
 	switch (priv->reg.powermgt) {
 	case POWMGT_ACTIVE_MODE:
 		mode = POWER_ACTIVE;
 		wake_up = 0;
-		receiveDTIMs = 0;
+		receive_dtims = 0;
 		break;
 	case POWMGT_SAVE1_MODE:
 		if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
 			mode = POWER_SAVE;
 			wake_up = 0;
-			receiveDTIMs = 0;
+			receive_dtims = 0;
 		} else {
 			mode = POWER_ACTIVE;
 			wake_up = 0;
-			receiveDTIMs = 0;
+			receive_dtims = 0;
 		}
 		break;
 	case POWMGT_SAVE2_MODE:
 		if (priv->reg.operation_mode == MODE_INFRASTRUCTURE) {
 			mode = POWER_SAVE;
 			wake_up = 0;
-			receiveDTIMs = 1;
+			receive_dtims = 1;
 		} else {
 			mode = POWER_ACTIVE;
 			wake_up = 0;
-			receiveDTIMs = 0;
+			receive_dtims = 0;
 		}
 		break;
 	default:
 		mode = POWER_ACTIVE;
 		wake_up = 0;
-		receiveDTIMs = 0;
+		receive_dtims = 0;
 		break;
 	}
-	hostif_power_mngmt_request(priv, mode, wake_up, receiveDTIMs);
+	hostif_power_mngmt_request(priv, mode, wake_up, receive_dtims);
 }
 
 static
diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
index d773432..3e53a90 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging/ks7010/ks_hostif.h
@@ -188,7 +188,7 @@ struct hostif_power_mngmt_request_t {
 	u32 wake_up;
 #define SLEEP_FALSE 0
 #define SLEEP_TRUE  1	/* not used */
-	u32 receiveDTIMs;
+	u32 receive_dtims;
 #define DTIM_FALSE 0
 #define DTIM_TRUE  1
 } __packed;
-- 
1.9.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2017-04-30  0:45 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-29 20:58 [PATCH 0/8] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-07  3:37   ` Greg Kroah-Hartman
2017-05-12 13:46     ` Janusz Lisiecki
2017-05-07  7:03   ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-12  9:10     ` Greg Kroah-Hartman
2017-04-29 20:58 ` Janusz Lisiecki [this message]
2017-04-29 20:58 ` [PATCH 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
2017-04-30  8:59   ` Tobin C. Harding
2017-04-29 20:58 ` [PATCH 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
2017-04-29 20:58 ` [PATCH 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-07  7:07   ` [PATCH v2 " Janusz Lisiecki
2017-04-30  9:01 ` [PATCH 0/8] Avoid CamelCases in ks7010 driver Tobin C. Harding
2017-05-12 13:42 ` [PATCH v2 " Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t Janusz Lisiecki
2017-05-15 10:03     ` Greg Kroah-Hartman
2017-05-12 13:42   ` [PATCH v2 2/8] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 3/8] staging: ks7010: avoid CamelCase: FhParms_t fields Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 4/8] staging: ks7010: avoid CamelCase: link_ap_info_t fields Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 5/8] staging: ks7010: avoid CamelCase: CfParms_t fields Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 6/8] staging: ks7010: avoid CamelCase: atimWindow Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 7/8] staging: ks7010: avoid CamelCase: reqIEs_size and respIEs_size Janusz Lisiecki
2017-05-12 13:42   ` [PATCH v2 8/8] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-15 18:55   ` [PATCH v3 0/2] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-15 18:55     ` [PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-16 11:53       ` Greg Kroah-Hartman
2017-05-15 18:55     ` [PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c Janusz Lisiecki
2017-05-16 15:29     ` [PATCH v4 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-16 15:29       ` [PATCH v4 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki
2017-05-16 15:34       ` [PATCH v5 0/1] Avoid CamelCases in ks7010 driver Janusz Lisiecki
2017-05-16 15:34         ` [PATCH v5 1/1] staging: ks7010: avoid CamelCase: receiveDTIMs Janusz Lisiecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493499528-27307-3-git-send-email-janusz.lisiecki@gmail.com \
    --to=janusz.lisiecki@gmail.com \
    --cc=driverdev-devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.