All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Dai <wei.dai@intel.com>
To: wenzhuo.lu@intel.com, thomas@monjalon.net,
	harish.patil@cavium.com, rasesh.mody@cavium.com,
	stephen.hurd@broadcom.com, ajit.khaparde@broadcom.com,
	helin.zhang@intel.com, konstantin.ananyev@intel.com,
	jingjing.wu@intel.com, jing.d.chen@intel.com,
	adrien.mazarguil@6wind.com, nelio.laranjeiro@6wind.com,
	bruce.richardson@intel.com, yuanhan.liu@linux.intel.com,
	maxime.coquelin@redhat.com, shepard.siegel@atomicrules.com,
	ed.czeck@atomicrules.com, john.miller@atomicrules.com
Cc: dev@dpdk.org, Wei Dai <wei.dai@intel.com>
Subject: [PATCH v6 0/3] MAC address fail to be added shouldn't be stored
Date: Tue,  2 May 2017 20:44:22 +0800	[thread overview]
Message-ID: <1493729065-17090-1-git-send-email-wei.dai@intel.com> (raw)
In-Reply-To: <1493525507-56304-1-git-send-email-wei.dai@intel.com>

Current ethdev always stores MAC address even it fails to be added.
Other function may regard the failed MAC address valid and lead to
some errors. So There is a need to check if the addr is added
successfully or not and discard it if it fails.

In 3rd patch, add a command "add_more_mac_addr port_id base_mac_addr count"
to add more than one MAC address one time.
This command can simplify the test for the first patch.
Normally a MAC address may fails to be added only after many MAC
addresses have been added.
Without this command, a tester may only trigger failed MAC address
by running many times of testpmd command 'mac_addr add' .

For v4 patch set, have got acknowledgements from
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>  for mlx changes
Yuanhan Liu <yuanhan.liu@linux.intel.com>  for virtio changes

---
Changes
v6:
  1. rebase master branch to v17.05-rc3
  2. not touch e1000 base driver code
  3. fix some minor defects

v5:
  1. rebase master branch
  2. add support to drivers/net/ark
  3. fix some minor defects
  
v4:
  1. rebase master branch
  2. follow code style
	
v3:
  1. Change return value for some specific NIC according to feedbacks
     from the community;
  2. Add ABI change in release note;
  3. Add more detailed commit message.

v2:
  fix warnings and erros from check-git-log.sh and checkpatch.pl

Wei Dai (3):
  ethdev: fix adding invalid MAC addr
  doc: change type of return value of adding MAC addr
  app/testpmd: add a command to add many MAC addrs

 app/test-pmd/cmdline.c                 | 55 ++++++++++++++++++++++++++++++++++
 doc/guides/rel_notes/release_17_05.rst |  7 +++++
 drivers/net/ark/ark_ethdev.c           | 15 ++++++----
 drivers/net/bnx2x/bnx2x_ethdev.c       |  7 +++--
 drivers/net/bnxt/bnxt_ethdev.c         | 16 +++++-----
 drivers/net/e1000/em_ethdev.c          |  8 ++---
 drivers/net/e1000/igb_ethdev.c         |  9 +++---
 drivers/net/enic/enic.h                |  2 +-
 drivers/net/enic/enic_ethdev.c         |  4 +--
 drivers/net/enic/enic_main.c           |  9 +++---
 drivers/net/fm10k/fm10k_ethdev.c       |  3 +-
 drivers/net/i40e/i40e_ethdev.c         | 17 ++++++-----
 drivers/net/i40e/i40e_ethdev_vf.c      | 14 ++++-----
 drivers/net/ixgbe/ixgbe_ethdev.c       | 33 ++++++++++++--------
 drivers/net/mlx4/mlx4.c                | 16 ++++++----
 drivers/net/mlx5/mlx5.h                |  4 +--
 drivers/net/mlx5/mlx5_mac.c            | 16 ++++++----
 drivers/net/qede/qede_ethdev.c         |  6 ++--
 drivers/net/ring/rte_eth_ring.c        |  3 +-
 drivers/net/virtio/virtio_ethdev.c     | 13 ++++----
 lib/librte_ether/rte_ethdev.c          | 15 ++++++----
 lib/librte_ether/rte_ethdev.h          |  2 +-
 22 files changed, 184 insertions(+), 90 deletions(-)

-- 
2.7.4

  parent reply	other threads:[~2017-05-02 12:52 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30  4:11 [PATCH v5 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-04-30  4:11 ` [PATCH v5 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-04-30  4:11 ` [PATCH v5 2/3] doc: change type of return value of adding " Wei Dai
2017-04-30  4:11 ` [PATCH v5 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-04-30 22:59 ` [PATCH v5 0/3] MAC address fail to be added shouldn't be stored Thomas Monjalon
2017-05-02 12:44 ` Wei Dai [this message]
2017-05-02 12:44   ` [PATCH v6 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-03  0:57     ` Lu, Wenzhuo
2017-05-03  1:46     ` Yuanhan Liu
2017-05-05  0:16       ` Dai, Wei
2017-05-02 12:44   ` [PATCH v6 2/3] doc: change type of return value of adding " Wei Dai
2017-05-02 12:44   ` [PATCH v6 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05  0:39   ` [PATCH v7 0/3] MAC address fail to be added shouldn't be stored Wei Dai
2017-05-05  0:40     ` [PATCH v7 1/3] ethdev: fix adding invalid MAC addr Wei Dai
2017-05-05  1:46       ` Yang, Qiming
2017-05-05 14:07         ` Thomas Monjalon
2017-05-05 14:21       ` Thomas Monjalon
2017-05-07  4:39         ` Yuanhan Liu
2017-05-05 14:24       ` Thomas Monjalon
2017-05-05  0:40     ` [PATCH v7 2/3] doc: change type of return value of adding " Wei Dai
2017-05-05 14:23       ` Thomas Monjalon
2017-05-05  0:40     ` [PATCH v7 3/3] app/testpmd: add a command to add many MAC addrs Wei Dai
2017-05-05 14:24       ` Thomas Monjalon
2017-05-08  1:01         ` Wu, Jingjing
2017-05-08  6:17           ` Wu, Jingjing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493729065-17090-1-git-send-email-wei.dai@intel.com \
    --to=wei.dai@intel.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ed.czeck@atomicrules.com \
    --cc=harish.patil@cavium.com \
    --cc=helin.zhang@intel.com \
    --cc=jing.d.chen@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=john.miller@atomicrules.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=rasesh.mody@cavium.com \
    --cc=shepard.siegel@atomicrules.com \
    --cc=stephen.hurd@broadcom.com \
    --cc=thomas@monjalon.net \
    --cc=wenzhuo.lu@intel.com \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.