From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932618AbdEDSqY (ORCPT ); Thu, 4 May 2017 14:46:24 -0400 Received: from mail-qt0-f176.google.com ([209.85.216.176]:35750 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932285AbdEDSp5 (ORCPT ); Thu, 4 May 2017 14:45:57 -0400 From: Laura Abbott To: Daniel Vetter , Chris Wilson , Sean Paul Cc: Laura Abbott , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sumit Semwal , intel-gfx@lists.freedesktop.org, Joonas Lahtinen Subject: [PATCHv4 1/3] drm/vgem: Add a dummy platform device Date: Thu, 4 May 2017 11:45:46 -0700 Message-Id: <1493923548-20878-2-git-send-email-labbott@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1493923548-20878-1-git-send-email-labbott@redhat.com> References: <1493923548-20878-1-git-send-email-labbott@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The vgem driver is currently registered independent of any actual device. Some usage of the dmabuf APIs require an actual device structure to do anything. Register a dummy platform device for use with dmabuf. Reviewed-by: Chris Wilson Signed-off-by: Laura Abbott --- v4: Switch from the now removed platformdev to a static platform device. --- drivers/gpu/drm/vgem/vgem_drv.c | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 9fee38a..d1d98af 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -42,6 +42,8 @@ #define DRIVER_MAJOR 1 #define DRIVER_MINOR 0 +static struct platform_device *vgem_platform; + static void vgem_gem_free_object(struct drm_gem_object *obj) { struct drm_vgem_gem_object *vgem_obj = to_vgem_bo(obj); @@ -335,11 +337,20 @@ static int __init vgem_init(void) int ret; vgem_device = drm_dev_alloc(&vgem_driver, NULL); - if (IS_ERR(vgem_device)) { - ret = PTR_ERR(vgem_device); + if (IS_ERR(vgem_device)) + return PTR_ERR(vgem_device); + + vgem_platform = platform_device_register_simple("vgem", + -1, NULL, 0); + + if (!vgem_platform) { + ret = -ENODEV; goto out; } + dma_coerce_mask_and_coherent(&vgem_platform->dev, + DMA_BIT_MASK(64)); + ret = drm_dev_register(vgem_device, 0); if (ret) goto out_unref; @@ -347,13 +358,15 @@ static int __init vgem_init(void) return 0; out_unref: - drm_dev_unref(vgem_device); + platform_device_unregister(vgem_platform); out: + drm_dev_unref(vgem_device); return ret; } static void __exit vgem_exit(void) { + platform_device_unregister(vgem_platform); drm_dev_unregister(vgem_device); drm_dev_unref(vgem_device); } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laura Abbott Subject: [PATCHv4 1/3] drm/vgem: Add a dummy platform device Date: Thu, 4 May 2017 11:45:46 -0700 Message-ID: <1493923548-20878-2-git-send-email-labbott@redhat.com> References: <1493923548-20878-1-git-send-email-labbott@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qt0-f175.google.com (mail-qt0-f175.google.com [209.85.216.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CAC16E5AC for ; Thu, 4 May 2017 18:45:56 +0000 (UTC) Received: by mail-qt0-f175.google.com with SMTP id m36so17610551qtb.0 for ; Thu, 04 May 2017 11:45:56 -0700 (PDT) In-Reply-To: <1493923548-20878-1-git-send-email-labbott@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Chris Wilson , Sean Paul Cc: intel-gfx@lists.freedesktop.org, Joonas Lahtinen , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ClRoZSB2Z2VtIGRyaXZlciBpcyBjdXJyZW50bHkgcmVnaXN0ZXJlZCBpbmRlcGVuZGVudCBvZiBh bnkgYWN0dWFsCmRldmljZS4gU29tZSB1c2FnZSBvZiB0aGUgZG1hYnVmIEFQSXMgcmVxdWlyZSBh biBhY3R1YWwgZGV2aWNlIHN0cnVjdHVyZQp0byBkbyBhbnl0aGluZy4gUmVnaXN0ZXIgYSBkdW1t eSBwbGF0Zm9ybSBkZXZpY2UgZm9yIHVzZSB3aXRoIGRtYWJ1Zi4KClJldmlld2VkLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KU2lnbmVkLW9mZi1ieTogTGF1cmEg QWJib3R0IDxsYWJib3R0QHJlZGhhdC5jb20+Ci0tLQp2NDogU3dpdGNoIGZyb20gdGhlIG5vdyBy ZW1vdmVkIHBsYXRmb3JtZGV2IHRvIGEgc3RhdGljIHBsYXRmb3JtIGRldmljZS4KLS0tCiBkcml2 ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Rydi5jIHwgMTkgKysrKysrKysrKysrKysrKy0tLQogMSBm aWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL3ZnZW0vdmdlbV9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS92Z2Vt L3ZnZW1fZHJ2LmMKaW5kZXggOWZlZTM4YS4uZDFkOThhZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL3ZnZW0vdmdlbV9kcnYuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vdmdlbS92Z2VtX2Ry di5jCkBAIC00Miw2ICs0Miw4IEBACiAjZGVmaW5lIERSSVZFUl9NQUpPUgkxCiAjZGVmaW5lIERS SVZFUl9NSU5PUgkwCiAKK3N0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICp2Z2VtX3BsYXRm b3JtOworCiBzdGF0aWMgdm9pZCB2Z2VtX2dlbV9mcmVlX29iamVjdChzdHJ1Y3QgZHJtX2dlbV9v YmplY3QgKm9iaikKIHsKIAlzdHJ1Y3QgZHJtX3ZnZW1fZ2VtX29iamVjdCAqdmdlbV9vYmogPSB0 b192Z2VtX2JvKG9iaik7CkBAIC0zMzUsMTEgKzMzNywyMCBAQCBzdGF0aWMgaW50IF9faW5pdCB2 Z2VtX2luaXQodm9pZCkKIAlpbnQgcmV0OwogCiAJdmdlbV9kZXZpY2UgPSBkcm1fZGV2X2FsbG9j KCZ2Z2VtX2RyaXZlciwgTlVMTCk7Ci0JaWYgKElTX0VSUih2Z2VtX2RldmljZSkpIHsKLQkJcmV0 ID0gUFRSX0VSUih2Z2VtX2RldmljZSk7CisJaWYgKElTX0VSUih2Z2VtX2RldmljZSkpCisJCXJl dHVybiBQVFJfRVJSKHZnZW1fZGV2aWNlKTsKKworCXZnZW1fcGxhdGZvcm0gPSBwbGF0Zm9ybV9k ZXZpY2VfcmVnaXN0ZXJfc2ltcGxlKCJ2Z2VtIiwKKwkJCQkJLTEsIE5VTEwsIDApOworCisJaWYg KCF2Z2VtX3BsYXRmb3JtKSB7CisJCXJldCA9IC1FTk9ERVY7CiAJCWdvdG8gb3V0OwogCX0KIAor CWRtYV9jb2VyY2VfbWFza19hbmRfY29oZXJlbnQoJnZnZW1fcGxhdGZvcm0tPmRldiwKKwkJCQkJ RE1BX0JJVF9NQVNLKDY0KSk7CisKIAlyZXQgID0gZHJtX2Rldl9yZWdpc3Rlcih2Z2VtX2Rldmlj ZSwgMCk7CiAJaWYgKHJldCkKIAkJZ290byBvdXRfdW5yZWY7CkBAIC0zNDcsMTMgKzM1OCwxNSBA QCBzdGF0aWMgaW50IF9faW5pdCB2Z2VtX2luaXQodm9pZCkKIAlyZXR1cm4gMDsKIAogb3V0X3Vu cmVmOgotCWRybV9kZXZfdW5yZWYodmdlbV9kZXZpY2UpOworCXBsYXRmb3JtX2RldmljZV91bnJl Z2lzdGVyKHZnZW1fcGxhdGZvcm0pOwogb3V0OgorCWRybV9kZXZfdW5yZWYodmdlbV9kZXZpY2Up OwogCXJldHVybiByZXQ7CiB9CiAKIHN0YXRpYyB2b2lkIF9fZXhpdCB2Z2VtX2V4aXQodm9pZCkK IHsKKwlwbGF0Zm9ybV9kZXZpY2VfdW5yZWdpc3Rlcih2Z2VtX3BsYXRmb3JtKTsKIAlkcm1fZGV2 X3VucmVnaXN0ZXIodmdlbV9kZXZpY2UpOwogCWRybV9kZXZfdW5yZWYodmdlbV9kZXZpY2UpOwog fQotLSAKMi43LjQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=