All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <don.brace@microsemi.com>
To: joseph.szczypek@hpe.com, gerry.morong@microsemi.com,
	john.hall@microsemi.com, jejb@linux.vnet.ibm.com,
	Kevin.Barnett@microsemi.com, Mahesh.Rajashekhara@microsemi.com,
	bader.alisaleh@microsemi.com, hch@infradead.org,
	scott.teel@microsemi.com, Viswas.G@microsemi.com,
	Justin.Lindley@microsemi.com, scott.benesh@microsemi.com,
	POSWALD@suse.com
Cc: linux-scsi@vger.kernel.org
Subject: [PATCH V4 02/12] hpsa: do not get enclosure info for external devices
Date: Thu, 4 May 2017 17:50:50 -0500	[thread overview]
Message-ID: <149393825045.19382.1499323455847186656.stgit@brunhilda> (raw)
In-Reply-To: <149393820493.19382.11709906672864416473.stgit@brunhilda>

external shelves do not support BMICs.

Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Reviewed-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
---
 drivers/scsi/hpsa.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 73daace..8e22aed 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -3353,6 +3353,11 @@ static void hpsa_get_enclosure_info(struct ctlr_info *h,
 
 	bmic_device_index = GET_BMIC_DRIVE_NUMBER(&rle->lunid[0]);
 
+	if (encl_dev->target == -1 || encl_dev->lun == -1) {
+		rc = IO_OK;
+		goto out;
+	}
+
 	if (bmic_device_index == 0xFF00 || MASKED_DEVICE(&rle->lunid[0])) {
 		rc = IO_OK;
 		goto out;

  parent reply	other threads:[~2017-05-04 22:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 22:50 [PATCH V4 00/12] hpsa updates Don Brace
2017-05-04 22:50 ` [PATCH V4 01/12] hpsa: update identify physical device structure Don Brace
2017-05-04 22:50 ` Don Brace [this message]
2017-05-04 22:50 ` [PATCH V4 03/12] hpsa: update reset handler Don Brace
2017-05-04 22:51 ` [PATCH V4 04/12] hpsa: do not reset enclosures Don Brace
2017-05-04 22:51 ` [PATCH V4 05/12] hpsa: rescan later if reset in progress Don Brace
2017-05-04 22:51 ` [PATCH V4 06/12] hpsa: correct resets on retried commands Don Brace
2017-05-04 22:51 ` [PATCH V4 07/12] hpsa: cleanup reset handler Don Brace
2017-05-05 13:27   ` Tomas Henzl
2017-05-05 16:10     ` Don Brace
2017-05-04 22:51 ` [PATCH V4 08/12] hpsa: correct queue depth for externals Don Brace
2017-05-04 22:51 ` [PATCH V4 09/12] hpsa: separate monitor events from rescan worker Don Brace
2017-05-04 22:51 ` [PATCH V4 10/12] hpsa: send ioaccel requests with 0 length down raid path Don Brace
2017-05-04 22:51 ` [PATCH V4 11/12] hpsa: remove abort handler Don Brace
2017-05-04 22:51 ` [PATCH V4 12/12] hpsa: bump driver version Don Brace
2017-05-12  3:07 ` [PATCH V4 00/12] hpsa updates Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149393825045.19382.1499323455847186656.stgit@brunhilda \
    --to=don.brace@microsemi.com \
    --cc=Justin.Lindley@microsemi.com \
    --cc=Kevin.Barnett@microsemi.com \
    --cc=Mahesh.Rajashekhara@microsemi.com \
    --cc=POSWALD@suse.com \
    --cc=Viswas.G@microsemi.com \
    --cc=bader.alisaleh@microsemi.com \
    --cc=gerry.morong@microsemi.com \
    --cc=hch@infradead.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.hall@microsemi.com \
    --cc=joseph.szczypek@hpe.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=scott.benesh@microsemi.com \
    --cc=scott.teel@microsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.