From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755186AbdEEC3t (ORCPT ); Thu, 4 May 2017 22:29:49 -0400 Received: from mga06.intel.com ([134.134.136.31]:54805 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836AbdEEC3o (ORCPT ); Thu, 4 May 2017 22:29:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,290,1491289200"; d="scan'208";a="853092183" From: Jin Yao To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com, milian.wolff@kdab.com, Jin Yao Subject: [PATCH v2 0/2] perf report: Add titles for percent/ipc/cycle in annotate browser Date: Fri, 5 May 2017 18:27:28 +0800 Message-Id: <1493980050-17210-1-git-send-email-yao.jin@linux.intel.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v2: --- Thanks for the comments and ideas from Arnaldo and Milian. 1. Change "Percnt" to "Percent" 2. Add explanations for "Percent", "IPC" and "Cycle". When user hit hotkey 'h', the help window is popup. Explanations are added at the bottom of window. │Report explanation: │ │ Percent: sample percentage for a block │ │ IPC: instructions per cycle for a block │ │ cycle: average number of cycles for a block │ I don't use a new window to display the report explanation, instead, I just display the info in current help window so that user doesn't need to press one more hotkey to get the explanation. Changed patch: -------------- perf report: Display titles in left frame of annotate browser Unchanged patch: ---------------- perf report: Remove the unnecessary checking in annotate_browser_write Initial post ------------ The patch series adds the titles "Percnt", "IPC" and "Cycle" in annotate browser. It helps user to understand easily for what the columns in left frame represents for. For example: Percnt IPC Cycle │ │25 __attribute__((noinline)) │26 int compute_flag() │27 { 22.80 1.20 │ sub $0x8,%rsp │25 int i; │ │27 i = rand() % 2; 22.78 1.20 1 │ → callq rand@plt The patch "perf report: Remove the unnecessary checking in annotate_browser_write" removes the invalid condition checking in current code. Jin Yao (2): perf report: Remove the unnecessary checking in annotate_browser_write perf report: Display titles in left frame of annotate browser tools/perf/ui/browsers/annotate.c | 59 +++++++++++++++++++++++++++------------ 1 file changed, 41 insertions(+), 18 deletions(-) -- 2.7.4