From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.hgst.iphmx.com ([216.71.154.42]:37683 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951AbdEEPvX (ORCPT ); Fri, 5 May 2017 11:51:23 -0400 From: Bart Van Assche To: "hch@lst.de" CC: "ddiss@suse.de" , "hare@suse.com" , "target-devel@vger.kernel.org" , "agrover@redhat.com" , "nab@linux-iscsi.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 06/19] target: Fix data buffer size for VERIFY and WRITE AND VERIFY commands Date: Fri, 5 May 2017 15:51:20 +0000 Message-ID: <1493999479.2744.5.camel@sandisk.com> References: <20170504225102.8931-1-bart.vanassche@sandisk.com> <20170504225102.8931-7-bart.vanassche@sandisk.com> <20170505094250.GA6138@lst.de> In-Reply-To: <20170505094250.GA6138@lst.de> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Fri, 2017-05-05 at 11:42 +0200, Christoph Hellwig wrote: > what do you think about the variant below instead which avoids > overloading the size variable? Hello Christoph, That should also work but results in slightly more code. I don't have a str= ong opinion about which approach to select. Bart.=