From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA0EC433FE for ; Sat, 11 Sep 2021 16:35:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27B6261212 for ; Sat, 11 Sep 2021 16:35:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbhIKQgi (ORCPT ); Sat, 11 Sep 2021 12:36:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbhIKQgh (ORCPT ); Sat, 11 Sep 2021 12:36:37 -0400 Received: from relay04.th.seeweb.it (relay04.th.seeweb.it [IPv6:2001:4b7a:2000:18::165]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 521E4C061574 for ; Sat, 11 Sep 2021 09:35:23 -0700 (PDT) Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id A1A1A1F500; Sat, 11 Sep 2021 18:35:21 +0200 (CEST) Subject: Re: [PATCH 2/2] drm/msm/dpu: Fix timeout issues on command mode panels To: Marijn Suijten Cc: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dmitry.baryshkov@linaro.org, abhinavk@codeaurora.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org References: <20210901174347.1012129-1-angelogioacchino.delregno@somainline.org> <20210901174347.1012129-2-angelogioacchino.delregno@somainline.org> <20210910214820.h6in2ffl5pwu7xtv@Marijn-Arch-PC.localdomain> From: AngeloGioacchino Del Regno Message-ID: <1493d3a8-e4a6-d3f9-be4d-87bddd593997@somainline.org> Date: Sat, 11 Sep 2021 18:35:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210910214820.h6in2ffl5pwu7xtv@Marijn-Arch-PC.localdomain> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Il 10/09/21 23:48, Marijn Suijten ha scritto: > Hi Angelo! > > On 2021-09-01 19:43:47, AngeloGioacchino Del Regno wrote: >> In function dpu_encoder_phys_cmd_wait_for_commit_done we are always >> checking if the relative CTL is started by waiting for an interrupt >> to fire: it is fine to do that, but then sometimes we call this >> function while the CTL is up and has never been put down, but that >> interrupt gets raised only when the CTL gets a state change from >> 0 to 1 (disabled to enabled), so we're going to wait for something >> that will never happen on its own. >> >> Solving this while avoiding to restart the CTL is actually possible >> and can be done by just checking if it is already up and running >> when the wait_for_commit_done function is called: in this case, so, >> if the CTL was already running, we can say that the commit is done >> if the command transmission is complete (in other terms, if the >> interface has been flushed). >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> index aa01698d6b25..b5b1b555ac4e 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> @@ -682,6 +682,9 @@ static int dpu_encoder_phys_cmd_wait_for_commit_done( >> if (!dpu_encoder_phys_cmd_is_master(phys_enc)) >> return 0; >> >> + if (phys_enc->hw_ctl->ops.is_started) >> + return dpu_encoder_phys_cmd_wait_for_tx_complete(phys_enc); > > In the previous commit you introduced is_started to the ops struct as > function pointer, and you probably intend to call it here instead of > just checking whether it might be NULL. > > As far as I remember this was also the reason for previously mentioning > that it was faulty and required a v2 in: > https://lore.kernel.org/linux-arm-msm/bdc67afc-3736-5497-c43f-5165c55e0354@somainline.org/ > > Thanks! > > - Marijn > Ugh. I've pulled this from the wrong tree. Sending a v2 asap. >> + >> return _dpu_encoder_phys_cmd_wait_for_ctl_start(phys_enc); >> } >> >> -- >> 2.32.0 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A2FC4332F for ; Sat, 11 Sep 2021 16:35:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D3161100 for ; Sat, 11 Sep 2021 16:35:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 08D3161100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=somainline.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FAFD6EC01; Sat, 11 Sep 2021 16:35:25 +0000 (UTC) Received: from relay01.th.seeweb.it (relay01.th.seeweb.it [IPv6:2001:4b7a:2000:18::162]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3B326EBFB for ; Sat, 11 Sep 2021 16:35:23 +0000 (UTC) Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id A1A1A1F500; Sat, 11 Sep 2021 18:35:21 +0200 (CEST) Subject: Re: [PATCH 2/2] drm/msm/dpu: Fix timeout issues on command mode panels To: Marijn Suijten Cc: robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, dmitry.baryshkov@linaro.org, abhinavk@codeaurora.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org References: <20210901174347.1012129-1-angelogioacchino.delregno@somainline.org> <20210901174347.1012129-2-angelogioacchino.delregno@somainline.org> <20210910214820.h6in2ffl5pwu7xtv@Marijn-Arch-PC.localdomain> From: AngeloGioacchino Del Regno Message-ID: <1493d3a8-e4a6-d3f9-be4d-87bddd593997@somainline.org> Date: Sat, 11 Sep 2021 18:35:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210910214820.h6in2ffl5pwu7xtv@Marijn-Arch-PC.localdomain> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 10/09/21 23:48, Marijn Suijten ha scritto: > Hi Angelo! > > On 2021-09-01 19:43:47, AngeloGioacchino Del Regno wrote: >> In function dpu_encoder_phys_cmd_wait_for_commit_done we are always >> checking if the relative CTL is started by waiting for an interrupt >> to fire: it is fine to do that, but then sometimes we call this >> function while the CTL is up and has never been put down, but that >> interrupt gets raised only when the CTL gets a state change from >> 0 to 1 (disabled to enabled), so we're going to wait for something >> that will never happen on its own. >> >> Solving this while avoiding to restart the CTL is actually possible >> and can be done by just checking if it is already up and running >> when the wait_for_commit_done function is called: in this case, so, >> if the CTL was already running, we can say that the commit is done >> if the command transmission is complete (in other terms, if the >> interface has been flushed). >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> index aa01698d6b25..b5b1b555ac4e 100644 >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c >> @@ -682,6 +682,9 @@ static int dpu_encoder_phys_cmd_wait_for_commit_done( >> if (!dpu_encoder_phys_cmd_is_master(phys_enc)) >> return 0; >> >> + if (phys_enc->hw_ctl->ops.is_started) >> + return dpu_encoder_phys_cmd_wait_for_tx_complete(phys_enc); > > In the previous commit you introduced is_started to the ops struct as > function pointer, and you probably intend to call it here instead of > just checking whether it might be NULL. > > As far as I remember this was also the reason for previously mentioning > that it was faulty and required a v2 in: > https://lore.kernel.org/linux-arm-msm/bdc67afc-3736-5497-c43f-5165c55e0354@somainline.org/ > > Thanks! > > - Marijn > Ugh. I've pulled this from the wrong tree. Sending a v2 asap. >> + >> return _dpu_encoder_phys_cmd_wait_for_ctl_start(phys_enc); >> } >> >> -- >> 2.32.0 >>