From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbdEHQk1 (ORCPT ); Mon, 8 May 2017 12:40:27 -0400 Received: from mga01.intel.com ([192.55.52.88]:29224 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751848AbdEHQkY (ORCPT ); Mon, 8 May 2017 12:40:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,309,1491289200"; d="scan'208";a="965878519" Message-ID: <1494261618.30052.67.camel@linux.intel.com> Subject: Re: [PATCH v9 6/6] i2c: designware: enable SLAVE in platform module From: Andy Shevchenko To: Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Mon, 08 May 2017 19:40:18 +0300 In-Reply-To: References: Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2017-05-08 at 11:37 +0100, Luis Oliveira wrote: > - Slave mode selected in platform module if the support is detected in >   the DT. >  config I2C_DESIGNWARE_PLATFORM >   tristate "Synopsys DesignWare Platform" >   select I2C_DESIGNWARE_CORE > + select I2C_DESIGNWARE_SLAVE >   depends on (ACPI && COMMON_CLK) || !ACPI >   help >     If you say yes to this option, support will be included for > the > @@ -483,6 +484,7 @@ config I2C_DESIGNWARE_SLAVE >   bool "Synopsys DesignWare Slave" >   select I2C_SLAVE >   depends on I2C_DESIGNWARE_PLATFORM > + default y Can you elaborate why this line is needed? -- Andy Shevchenko Intel Finland Oy