From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754232AbdEIO22 (ORCPT ); Tue, 9 May 2017 10:28:28 -0400 Received: from mail-by2nam01on0045.outbound.protection.outlook.com ([104.47.34.45]:16869 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752856AbdEIO20 (ORCPT ); Tue, 9 May 2017 10:28:26 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=fail action=none header.from=nxp.com; Message-ID: <1494340101.24555.37.camel@nxp.com> Subject: Re: [PATCH v3 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge From: Leonard Crestez To: Rob Herring , Philipp Zabel CC: , , "Cristina Ciocan" , Octavian Purdila Date: Tue, 9 May 2017 17:28:21 +0300 In-Reply-To: <1490194865.2285.43.camel@pengutronix.de> References: <20170322132608.17353-1-robh@kernel.org> <20170322132608.17353-5-robh@kernel.org> <1490194865.2285.43.camel@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131388137043632537;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39860400002)(39840400002)(39400400002)(39380400002)(39450400003)(39410400002)(39850400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(24454002)(377454003)(377424004)(9170700003)(105606002)(106466001)(2950100002)(36756003)(104016004)(85426001)(53936002)(54906002)(76176999)(50986999)(103116003)(8936002)(5820100001)(50226002)(50466002)(2906002)(86362001)(2870700001)(81166006)(8656002)(53546009)(77096006)(23676002)(5660300001)(47776003)(305945005)(356003)(189998001)(229853002)(8676002)(6246003)(38730400002)(498600001)(4326008)(33646002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0301MB0912;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD036;1:slNBmiWLrYIr4X4HyGIl70A2xqwYe/NQUGvyl78hw6OJWaJMVqAZ4bVHHnxWBobNrtXcSSFaF7PIUB7pgtAoZwLMoOg3OzlzxRPd2gKGoLZNd8QI95GcWom1gX/qlJZyLFNSo4k+mu9m3WC4cByqxmS3YPdBVmPNTYSsbvZRWywQuqYobo4DJNg2uoOogNh+xLoD/jLz1yJojVNyXA6tlhEFpiZScZkiI6T+Acuds6F1q1uPXi0I3dVuZaRx7pgWi5wdrMSeGD8Tlj3IhUZe8jeTdBafOzRQC5pMm3GMcf9Un77ViJdOl6FQ+4uHxI5f3FlznbTsSIGUfCIlFPvSQ2iiRXIdpWN4aY27Vtn85gjF/S6LHCM5ZMf0tbLmq5rGkGbzYvxo11doPUWxCcXbU67PySRviBNSfblDItASNLqyd4EwOgevZ01hJXMAM5B667hOttXyWrvlz7IzqzGmP5LhjmGoChXXMiZLmd5ay7PAf0rImnrqnb9NJNgQmPFyjr0u8cSjqQsJONj5nM1tg9DmxBMrxRSGyyowliL0YloKAwtqlafSN+kuXaWRb5am9NbUIHRopraUkIIC0NQ3t2NKx0PVW0ZE28bG4+AqgZMGdEwfyKxrOdiHn+xgsoTtfMqeoJQte8IYv9iO2s951HAAoPvnzvscq3MvMejmu+nuCwJxcOagoh9GklT3N3eIlbrFjf/RDnzHhHF/9gOdjEK8ZZ3CP8MsjYktj/hVjLQ= X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 662bfa67-ec4a-4e3c-4038-08d496e7a6a4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:DM2PR0301MB0912; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;3:PWmQ3VYcXWZTbVPaJhLWi3SIBNs+JTt6dyN5S3GGP0hBefI9oG94GoECCD9+1qkcehfjtclxtom9TJi32e3eHzHHiTT6FyRi94J6cUs97kKeUaqaonkE13cpZzn/va6kZMdPxgrrEgPhikuHWKUm/dEORhBi9YWiAQ3/G34tQDKSQ2Af1CEFvoJaiEusLwQ2b42oAvYWquc6lNRRevE7UTlUF2BmvsaPk4oOY0ApUFjvKlscbwFRr+/wkqPJJE/8KqXrZM9T2rVbH3BavwKRd/IQmzCttS+DzWdtgONUQs/4ASNBvD3AXqTvF4yxDLL5CEE4c58XScGo0KT3/eOE3pzqVpnTDdH5VILU2dV0PfmpD5prQbfXGQ4KYbQVLvTgU8+SKX9tChRyk/mnfPs8dDbpVS64Kmt3A4yo0PQ9C/L78LtwFuPyqDgcW4tx3Mpv;25:R5/6DoEaBjR9EPYyZyu2oOzhQK0xkyRC+WhZ1jVLyB+HPS1fLSo+ljtq+GPyXlW11fs/xPzveB5IOqTLmPmlUahYxeemBxMgGpkgKbJwsGSr6Iyv/sqCGG5Tv//23oIHQULkjAMHVumlZoo0t5fGwchg+ce/pBt6Yu+jDZxV9zFVB6y6rUSwXCoOsGRg7CxQPMSqImtvxLbMx2NnGqyB1XgzGvJg7TzV5WP7qSt3g74YI10uWuNecbKYHsSsLlE00ZrM5YFdlT6w8nDjXaVi0O1fdwCdfYp0/0hESlP2oZXjIsjeFbO2ArgFG5PKmlcnB5Yd/vZ7UBBtA7IDr5FHXi1vH+pJ9Ev16RNEAisLk+rRPr3irbTTEj20gGOLbAkIRrhRNjOH2GigX3c6U1ldwgT+/4KYgE6wpAgk2zpupf51+qDk5lDflWDY7w3jxe6/aO85lQj6zocDId0G5nsPxg== X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;31:WIVN+BUtx4y2Xr/oolcmdZLr2l5hhSkNF9zrrgcNbgtdXHriE/UCyNP1NUuvyAoG0tLlSv132w3inGAkpw2CCrihGP4Wha4Ur94K6rB8OW3O+fM4eGI3jR7KQh7Re3FJyZxMj1cuhji/lvO+hpirthOqo7ukIfRrCms+9CXfzh22D3ahcblEbS4cEddI5d2P5rSHmi/Bbp4dEVPCE6Q/fwuwiCkpCYYdUpbBGCY1VewhNGUCxR7PlAJj5cppX9kO8OtTPWTz+Ss1Zkuae7OViQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095135)(601004)(2401047)(8121501046)(13023025)(13024025)(13018025)(13017025)(5005006)(13015025)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123565025)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123559100)(20161123556025)(20161123561025)(20161123563025);SRVR:DM2PR0301MB0912;BCL:0;PCL:0;RULEID:(400006);SRVR:DM2PR0301MB0912; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;4:OEJ6myTj9dOV7QHCK6tVcVa2iuFiPjafxq3ogsF8kwN06DZtqS5uN45vUrOmF5PKgrEPMPNJNYW5wrxBA59VD5ueOzTcTTXe9pfDA57wiUY8tHIGrNrFCbCpMr43xvPqNaF9Xi58qi5jI/SoesVpTTXGlALgCksDxAxmvrErTrtJt1fjxdynqMlxo0UtCWda3DyhyGukgfTHWGgVtgL+wtvt3KPyD+uGHeTtawYBywdF0c2rNPt839n1rhSSYEmrdQdi31OTrr+rMhNk50ZSs/P+UUuzuNJ1yIisDZo/jGPaC0NUf+0PFhOjSQMCjqsWbUJNiqAPrDkRJbkKLg6auoX8NXwhXgkya7pxMwXfxZvKiWXcB/iWFAec+QbMC6RSQnz7OWJrU0ICFL4V8BWGztVTLAqGSDkGXHoFYeU6PiXdb3A4uRB9v7oBZJlWwKuR0CUwNFIMjQWMzOL/t9o1DBFISEFEOQce6X1iWTqz3vnPD1NBLXyN6KpnlGXcXGdtq3lKXLMkDYHDMwqg7SKZujj0znHlkUzkN6g2o6iSRoduJAnSR+fqEOhEscTMbs6bvLvkeq6Kns2FUjMtXF83Sp405zO9v8h79BVQQJpfZH/t++Mn3Oln30rWYIsAH0yw7QEbsFu5IpGR9samyqITd3Gi67bkRQaKhfoCb3H6Q3U+VOjTxx+lLfICHi7OrxG0DqLOdndwGrmZM5Ec+PoHqmAY+CFz+raDTtRUVhQ/KjTV7cfbCdaf6sFZec5JeXGBAfuJy5pLR6/XemTx3U+BVAYEnKZ+27OfDKTqAqXH5DIRl7xfz7wBzI1ItqXKNXhPKBIPhueaV65lLeTunii/6BhClt5mhLZfHDEM8TCEoJUJXhHU1tUZ3M0ybFirKnd1qrPShAqydjAC1cYNNAdScrvnLiCpUm5S3RvBC15RsLU= X-Forefront-PRVS: 0302D4F392 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjA5MTI7MjM6dGZya200WE1peXdERlZ1S2hxNW90WkJ2?= =?utf-8?B?a2RrdzhDYmJwSDBQUGRhYWtSQ09YOXp6dnFKWWVlMkxnYklYUVcxT0ZFZk9m?= =?utf-8?B?eVBBOUV4aTIwQlVwUkJFTGREQ2ZpV1pzeHpGRjIxajdTc05QamZTMkljMjdB?= =?utf-8?B?aU1SeGJoR1hTNTlyNDBkaDJlOXJPSktzWGJCMk5JakV5ZHhwWGE2ekdDOEJH?= =?utf-8?B?TFJqbmlET0NjVGEwUkpFQUFFcGsvUnpYVzI1ZTdXUG5JRXRBM2JDZlc4eU1Y?= =?utf-8?B?bVVrd3R0UGphbUJYbThIYWY2UWFkV0NiR1pMU3g5cGVUeXBKSUVPbEo1cVQ4?= =?utf-8?B?S0NhTXhUQVdlKzRBTlZZM3UycGI3V0dUUmRtZVgvdVh5QVIxNUoyeFdhTHFC?= =?utf-8?B?VnRFUzV2UUZKNHh4MnN2NzQrRlJHbUIyaEhBb2JyNTg4UGZCYS8yY20wNVEv?= =?utf-8?B?S29PUnBjUi9LS3Vqa1ZQQzJUZEdxNFNYK29GSTIxdTFwcVkzdGViOW9qOUU4?= =?utf-8?B?akxtaHo0ei8xdE5JSEQvNlFiKzE2M3lDZDlTZDlmQytCNXdHeFkxVjZTT00y?= =?utf-8?B?REN1QjNiL3dNOGx3b3FjUkE3RHpTRE1hYkJmZ1dXdTNsN29CNjA0dXYrNGNI?= =?utf-8?B?WDFtNExBYzdiemFWWktpS3RiYVIvMUVKNGk1NUdybzNLbW9LNnVvdEVzLy90?= =?utf-8?B?VTZyQzEza3o1R09qTEtET1RJV3NjWVBZQW91bElhOFA4eGM2ODRZaTVFTVpP?= =?utf-8?B?TTdvKzBtdEhGK1VTUWdrV2xNdktXRTAzS1JiMHNBWE5SM1Z6SFpaS3hqd3pF?= =?utf-8?B?azlXT2ljODh4dmdlbU4xMHpWZ2JIVGFyQmU5VEpnTjg4WlNFdUpUVFZWcUhT?= =?utf-8?B?ajliZG14ZWJsMEdFcVVhaXp5OGdXS3Z0Y1Q3eDc1UWhoQWtzOUNKN3pVNkdh?= =?utf-8?B?eGhlV0tFelJKTlYwdkJjdnF3TEZzYU9PT0JMK1lkMkVHaTI0ZEJlZTc2RkJs?= =?utf-8?B?M0h5MTdqSTdGNDJDYUN0TTZYam5kY2g3TnYya2dIU3E1RXMwUEIyUUJPMU1h?= =?utf-8?B?bDZrVmhQMndjUzg3V0kzdm05aEpKUTNJODdhTzBiRi91SjM1TEswamZYVkIz?= =?utf-8?B?d0xnbTB2K2ZBMDNwQVNQNEMzN3R2cTd2b1Fzd3MxaDlyZkxhazZNY0dsM2g1?= =?utf-8?B?VTZ6aytQcTcvOXgxUGtZTXVVVElBblhOc0grNjBvRURPTkpadkhiajV2YW8w?= =?utf-8?B?Mkp3UnRuWGJGTC93T2t2TFIrdFc2eXQ5dXpzTjRFOGEzQjlZakJxMVpnUG5z?= =?utf-8?B?V0ZEZmNFbUpvUkZxeE9yNkppSXl1aXRFdytEMU0vWG1RVTI1ZU1aNk1lL3Vh?= =?utf-8?B?TVNFZ0NuYUs3Y1ZwV2haSVlTTEVuN3g1RkcrZzV1UDhVMGYxckMxTTlUVnpG?= =?utf-8?B?M0RUOWhpaCtvRCtGZ2lmQllmL2dCM01lUFBaSTM5TmJxVnFKN2Y2UGNJS2pw?= =?utf-8?B?aGs2NmpVS2ZuTVliQ3Ura0YyN1BJcHdUT1BBMFlnM1ZDdU1PNGliblhBYnJX?= =?utf-8?B?ZWw5bHJDdVRTLzFVS0NZZjhaVG1Ta1p0SHgwcGlST3BQbVUwd0d2R0FHVDEw?= =?utf-8?B?ZDhMK05STVpBNE15ZGVPdjJMQVBRK0ZvMmRpZy9iNjIxR2F1V080V3RzMUdx?= =?utf-8?B?NEtrMjJjU3Fud0pqTW4vTDNod0FCVGM0MjFFWnYrWHp3RGJtUTNpNHpNSURi?= =?utf-8?B?STFPdnlHWlVlbXpBaDM4VGp5ZWtoN3hoVE5PRzcwSWxoQzBTVkNqSGYxaG1D?= =?utf-8?B?ay9MVXUrQ0ZuMTIzWjZvL1hwbUt1RGs4WThhd3RRTG5lVnlydz09?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;6:LCc/jVYI0CQZ+0dNg4f42K4DQCRT+6Z0etk7azUhDQHP6FK3yqgJbPwsFDo3Y3lk4mOO0Dfejxf4T5PgGL0FNtRh3Tz6XBz8PTlTAsFi68fhgbaYOL3OXBQTSoRUI1Xuwb+ZQAfBe2wFa89uMn1NCWFCIcfqgNXEBKx+iZ12eyNnjPU37uCZLsTTUGLI+MeNa4NQy8uTHSMDXi2MnuGlSZft0zb9jyoE/tvFCdjW3s1PVmftEPazudQ4u26XhDDWprKDNta0X4c5ySk8esKtYWkUjHhyOOnMbkFoy7c3lcWQDHHDfstAjuMTqcxp3WdxQc+KCE4keIijOJs+95qnfFJanXUW3B58apphDr2HBBy/EuuTu8vD/tbNCchxK5uibxMleOrOUyKzUnCz22IkxtDeb4cldqoQ+EWHa3qAEoK0Xsrq9rdg7NokYKAdEHtphIMC7uDxAKv3Mlpk/Tubt01ayPVBD05R1eHIuJbC1APNo2L6fBx/7125f0Lb4wBNpDfggkH52xcVOMlWZ8hR0A==;5:lvSu9zWvPzR4X5tWWFaOITHH7fSooBBBQ7MA/DtiD2D+FpVs8XEnbb4DL3CZhEFnOcU7pHaFAoKaFGP0bcNR3ZTKNDOaL9qVeva55xHTznErbbbBSPUrB/0+JGtTWwwfmm6hSp38L90pU8+W6mvfEaaw7PbkSvhCRzPiaTlqKLqBvTkpADRZvEG3rcQ7DzXr;24:vDJQWE52sVRR8meUE7hQfooJZxgUWX4MQtW/hfLzW2VLKVUkcBSyhgnBFY4a1f1WV/gDzpJFdPG36DgUXYs8KcWA45tSGqBJZ0CQCRjq8MY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0912;7:/sVVig0hx2dvRe3o969owG2ttnPHITOsQGne/KCX5EI6FXy+3EQx0KckWZTR7BHU33M8G2zUf0aHGJzSZsCnaf9/E6cP1V7mdaKgpTBxuIbnln4We3wcB02bYd/pdVqw5J4+4Edg7NvosiNkeO4MMhhhZBa0UUCp0THHTfl92vPLcshb2awcHjuft2EYxeGzCKZSqDYA/Uw5GFrFHLxTHV1QjUk4mSu5sU5LWLaWd4gFJC3jmH66rkvjIl46u3wG6vCKZ1NuJx8MigglvBiEi/wwFshcDB8dbti9brdUBCDcJEGaxvcZyL4iPKH8a1dmf+WEK7pLQ6ylEF445KQXYQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2017 14:28:24.1448 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB0912 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 5:01 PM, Philipp Zabel wrote: > On Wed, 2017-03-22 at 08:26 -0500, Rob Herring wrote: > > > > Similar to the previous commit, convert drivers open coding OF graph > > parsing to use drm_of_find_panel_or_bridge instead. > > > > This changes some error messages to debug messages (in the graph core). > > Graph connections are often "no connects" depending on the particular > > board, so we want to avoid spurious messages. Plus the kernel is not a > > DT validator. > > > > Signed-off-by: Rob Herring > > Reviewed-by: Archit Taneja > Tested-by: Philipp Zabel > (imx-ldb on i.MX6) It seems that this breaks on (at least) imx6qdl-sabreauto. The relevant section of the boot log looks like this: imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops ipu_crtc_ops) imx-drm display-subsystem: bound imx-ipuv3-crtc.3 (ops ipu_crtc_ops) dwhdmi-imx 120000.hdmi: Detected HDMI TX controller v1.31a with HDCP (DWC HDMI 3D TX PHY) dwhdmi-imx 120000.hdmi: registered DesignWare HDMI I2C bus driver imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdmi_imx_ops) imx-drm display-subsystem: failed to bind 2000000.aips-bus:ldb (ops imx_ldb_ops): -19 imx-drm display-subsystem: master bind failed: -19 It seems that imx6qdl-sabreauto does not have any panel defined in dts. This used to be ignored when of_graph_get_endpoint_by_regs returned NULL but now drm_of_find_panel_or_bridge returns -ENODEV and this causes imx_ldb_bind to fail altogether. Defining a panel works (including showing stuff on a LVDS panel). Ignoring -ENODEV also fixes this: --- drivers/gpu/drm/imx/imx-ldb.c +++ drivers/gpu/drm/imx/imx-ldb.c @@ -673,7 +673,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data)                 ret = drm_of_find_panel_or_bridge(child,                                                   imx_ldb->lvds_mux ? 4 : 2, 0,                                                   &channel->panel, &channel->bridge); -               if (ret) +               if (ret != -ENODEV)                         return ret;                   /* panel ddc only if there is no bridge */ I don't know much about drm and it's not clear if failing to find a panel should be an error here or not and the hack above is likely the wrong way to handle it anyway. I was bisecting the fact that suspend now breaks on upstream. The fact that a probe error later breaks suspend is possibly an unrelated issue, right? --  Regards, Leonard From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leonard Crestez Subject: Re: [PATCH v3 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge Date: Tue, 9 May 2017 17:28:21 +0300 Message-ID: <1494340101.24555.37.camel@nxp.com> References: <20170322132608.17353-1-robh@kernel.org> <20170322132608.17353-5-robh@kernel.org> <1490194865.2285.43.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1490194865.2285.43.camel@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Cristina Ciocan , Octavian Purdila List-Id: dri-devel@lists.freedesktop.org On Wed, Mar 22, 2017 at 5:01 PM, Philipp Zabel wrote: > On Wed, 2017-03-22 at 08:26 -0500, Rob Herring wrote: > > > > Similar to the previous commit, convert drivers open coding OF graph > > parsing to use drm_of_find_panel_or_bridge instead. > > > > This changes some error messages to debug messages (in the graph core). > > Graph connections are often "no connects" depending on the particular > > board, so we want to avoid spurious messages. Plus the kernel is not a > > DT validator. > > > > Signed-off-by: Rob Herring > > Reviewed-by: Archit Taneja > Tested-by: Philipp Zabel > (imx-ldb on i.MX6) It seems that this breaks on (at least) imx6qdl-sabreauto. The relevant section of the boot log looks like this: imx-drm display-subsystem: bound imx-ipuv3-crtc.2 (ops ipu_crtc_ops) imx-drm display-subsystem: bound imx-ipuv3-crtc.3 (ops ipu_crtc_ops) dwhdmi-imx 120000.hdmi: Detected HDMI TX controller v1.31a with HDCP (DWC HDMI 3D TX PHY) dwhdmi-imx 120000.hdmi: registered DesignWare HDMI I2C bus driver imx-drm display-subsystem: bound 120000.hdmi (ops dw_hdmi_imx_ops) imx-drm display-subsystem: failed to bind 2000000.aips-bus:ldb (ops imx_ldb_ops): -19 imx-drm display-subsystem: master bind failed: -19 It seems that imx6qdl-sabreauto does not have any panel defined in dts. This used to be ignored when of_graph_get_endpoint_by_regs returned NULL but now drm_of_find_panel_or_bridge returns -ENODEV and this causes imx_ldb_bind to fail altogether. Defining a panel works (including showing stuff on a LVDS panel). Ignoring -ENODEV also fixes this: --- drivers/gpu/drm/imx/imx-ldb.c +++ drivers/gpu/drm/imx/imx-ldb.c @@ -673,7 +673,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data)                 ret = drm_of_find_panel_or_bridge(child,                                                   imx_ldb->lvds_mux ? 4 : 2, 0,                                                   &channel->panel, &channel->bridge); -               if (ret) +               if (ret != -ENODEV)                         return ret;                   /* panel ddc only if there is no bridge */ I don't know much about drm and it's not clear if failing to find a panel should be an error here or not and the hack above is likely the wrong way to handle it anyway. I was bisecting the fact that suspend now breaks on upstream. The fact that a probe error later breaks suspend is possibly an unrelated issue, right? --  Regards, Leonard