From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8ART-0001gl-HZ for qemu-devel@nongnu.org; Tue, 09 May 2017 15:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8ARP-0001DD-Is for qemu-devel@nongnu.org; Tue, 09 May 2017 15:05:03 -0400 Received: from mail.kernel.org ([198.145.29.136]:43438) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d8ARP-0001Ct-Cy for qemu-devel@nongnu.org; Tue, 09 May 2017 15:04:59 -0400 From: Stefano Stabellini Date: Tue, 9 May 2017 12:04:51 -0700 Message-Id: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> Subject: [Qemu-devel] [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: xen-devel@lists.xen.org, sstabellini@kernel.org, anthony.perard@citrix.com, groug@kaod.org, aneesh.kumar@linux.vnet.ibm.com CID: 1374836 Signed-off-by: Stefano Stabellini CC: anthony.perard@citrix.com CC: groug@kaod.org CC: aneesh.kumar@linux.vnet.ibm.com --- hw/9pfs/xen-9p-backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c index 9c7f41a..a1fdede 100644 --- a/hw/9pfs/xen-9p-backend.c +++ b/hw/9pfs/xen-9p-backend.c @@ -332,12 +332,14 @@ static int xen_9pfs_connect(struct XenDevice *xendev) str = g_strdup_printf("ring-ref%u", i); if (xenstore_read_fe_int(&xen_9pdev->xendev, str, &xen_9pdev->rings[i].ref) == -1) { + g_free(str); goto out; } g_free(str); str = g_strdup_printf("event-channel-%u", i); if (xenstore_read_fe_int(&xen_9pdev->xendev, str, &xen_9pdev->rings[i].evtchn) == -1) { + g_free(str); goto out; } g_free(str); -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Stabellini Subject: [PATCH v2 1/3] xen/9pfs: fix two resource leaks on error paths, discovered by Coverity Date: Tue, 9 May 2017 12:04:51 -0700 Message-ID: <1494356693-13190-1-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: qemu-devel@nongnu.org Cc: anthony.perard@citrix.com, aneesh.kumar@linux.vnet.ibm.com, sstabellini@kernel.org, groug@kaod.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Q0lEOiAxMzc0ODM2CgpTaWduZWQtb2ZmLWJ5OiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+CkNDOiBhbnRob255LnBlcmFyZEBjaXRyaXguY29tCkNDOiBncm91Z0Br YW9kLm9yZwpDQzogYW5lZXNoLmt1bWFyQGxpbnV4LnZuZXQuaWJtLmNvbQotLS0KIGh3LzlwZnMv eGVuLTlwLWJhY2tlbmQuYyB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9ody85cGZzL3hlbi05cC1iYWNrZW5kLmMgYi9ody85cGZzL3hlbi05cC1i YWNrZW5kLmMKaW5kZXggOWM3ZjQxYS4uYTFmZGVkZSAxMDA2NDQKLS0tIGEvaHcvOXBmcy94ZW4t OXAtYmFja2VuZC5jCisrKyBiL2h3LzlwZnMveGVuLTlwLWJhY2tlbmQuYwpAQCAtMzMyLDEyICsz MzIsMTQgQEAgc3RhdGljIGludCB4ZW5fOXBmc19jb25uZWN0KHN0cnVjdCBYZW5EZXZpY2UgKnhl bmRldikKICAgICAgICAgc3RyID0gZ19zdHJkdXBfcHJpbnRmKCJyaW5nLXJlZiV1IiwgaSk7CiAg ICAgICAgIGlmICh4ZW5zdG9yZV9yZWFkX2ZlX2ludCgmeGVuXzlwZGV2LT54ZW5kZXYsIHN0ciwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ4ZW5fOXBkZXYtPnJpbmdzW2ldLnJl ZikgPT0gLTEpIHsKKyAgICAgICAgICAgIGdfZnJlZShzdHIpOwogICAgICAgICAgICAgZ290byBv dXQ7CiAgICAgICAgIH0KICAgICAgICAgZ19mcmVlKHN0cik7CiAgICAgICAgIHN0ciA9IGdfc3Ry ZHVwX3ByaW50ZigiZXZlbnQtY2hhbm5lbC0ldSIsIGkpOwogICAgICAgICBpZiAoeGVuc3RvcmVf cmVhZF9mZV9pbnQoJnhlbl85cGRldi0+eGVuZGV2LCBzdHIsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAmeGVuXzlwZGV2LT5yaW5nc1tpXS5ldnRjaG4pID09IC0xKSB7CisgICAg ICAgICAgICBnX2ZyZWUoc3RyKTsKICAgICAgICAgICAgIGdvdG8gb3V0OwogICAgICAgICB9CiAg ICAgICAgIGdfZnJlZShzdHIpOwotLSAKMS45LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK