Re: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20170510083259.3900-1-xiaoguangrong@tencent.com
Type: series
Subject: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20170510092333.8890-1-famz@redhat.com -> patchew/20170510092333.8890-1-famz@redhat.com
 * [new tag]         patchew/20170510092903.23649-1-marcel@redhat.com -> patchew/20170510092903.23649-1-marcel@redhat.com
Switched to a new branch 'test'
e739ce9 mc146818rtc: embrace all x86 specific code
1aa2c5e mc146818rtc: drop unnecessary '#ifdef TARGET_I386'
0ab5312 mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386
f90b3ba mc146818rtc: precisely count the clock for periodic timer
95f013c mc146818rtc: update periodic timer only if it is needed

=== OUTPUT BEGIN ===
Checking PATCH 1/5: mc146818rtc: update periodic timer only if it is needed...
Checking PATCH 2/5: mc146818rtc: precisely count the clock for periodic timer...
ERROR: braces {} are necessary for all arms of this statement
#130: FILE: hw/timer/mc146818rtc.c:216:
+        if (s->lost_tick_policy == LOST_TICK_POLICY_SLEW) {
[...]
+        } else
[...]

total: 1 errors, 0 warnings, 187 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/5: mc146818rtc: ensure LOST_TICK_POLICY_SLEW is only enabled on TARGET_I386...
Checking PATCH 4/5: mc146818rtc: drop unnecessary '#ifdef TARGET_I386'...
Checking PATCH 5/5: mc146818rtc: embrace all x86 specific code...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org