All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org"
	<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>,
	"rf-PKu+Ek1N2UGzQB+pC5nmwQ@public.gmane.org"
	<rf-PKu+Ek1N2UGzQB+pC5nmwQ@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: srp_daemon :    targets      by default
Date: Wed, 10 May 2017 16:06:59 +0000	[thread overview]
Message-ID: <1494432414.2578.9.camel@sandisk.com> (raw)
In-Reply-To: <22803.7541.113159.214164-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>

On Wed, 2017-05-10 at 16:02 +0200, Roland Fehrenbacher wrote:
> it's hard to judge what is the most wanted default setup. The reason why
> this was changed was the cited Debian bug report. I'm also a friend of
> well-defined configs, so I agree with that opinion. I believe,
> adding a '#' in front of a line of a config file shouldn't overburden an
> admin who deals with IB storage under Linux, if she/he prefers the most
> simple config. The change in Debian is also clearly communicated (NEWS
> file), so I don't really see a problem. Finally: There are many packages
> in Debian that have a different default config as compared to upstream.

Hello Roland,

Thanks for chiming in. Are you perhaps referring to
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740945 ? If so, are you
aware that changing /etc/srp_daemon.conf was not necessary because of the
PORTS=NONE setting in /etc/default/srptools? BTW, I just reinstalled srptools
on an Ubuntu 17.04 system (apt-get remove -y srptools && dpkg --purge srptools
&& rm -f /etc/default/srptools /etc/srp_daemon.conf && rm -rf
/var/cache/apt/archives && apt-get install -y srptools). From what I see in
the installed configuration files it looks like the change you mentioned has
either not been applied or it has been reverted?

# head -n 99 /etc/default/srptools /etc/srp_daemon.conf   
==> /etc/default/srptools <==
#How often should srpdeamon  rescan the fabric (seconds)
RETRIES=60

#Where should srp-deamon log to
LOG=/var/log/srp_daemon.log

# What ports should srp-deamon be started on.
# Format is CA:port
# ALL or NONE will run on all ports on none
# respectively

PORTS=NONE
#PORTS=ALL
#PORTS="mthca0:1 mlx4_0:2"

==> /etc/srp_daemon.conf <==
## This is an example rules configuration file for srp_daemon.
##
#This is a comment
## disallow the following dgid
#d       dgid=fe800000000000000002c90200402bd5
## allow target with the following ioc_guid
#a       ioc_guid=00a0b80200402bd7
## allow target with the following pkey
#a       pkey=ffff
## allow target with the following id_ext and ioc_guid
#a       id_ext=200500A0B81146A1,ioc_guid=00a0b80200402bef
## disallow all the rest
#d
##
## Here is another example:
##
## Allow all targets and set queue size to 128.
# a      queue_size=128,max_cmd_per_lun=128

Thanks,

Bart.--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-05-10 16:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 17:07 srp_daemon : ​Disallow ​all targets ​if ​not ​explicitly ​allowed by default Benjamin Drung
     [not found] ` <1494349653.3752.4.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-09 17:11   ` Bart Van Assche
     [not found]     ` <021b0a17-0552-6ee4-ec19-0e86ead527ef-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-09 17:41       ` Laurence Oberman
     [not found]         ` <1050725096.6555338.1494351706650.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-05-09 18:01           ` Leon Romanovsky
     [not found]             ` <20170509180159.GK10073-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-09 18:04               ` srp_daemon : targets " Bart Van Assche
     [not found]                 ` <1494353077.2518.12.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-09 18:12                   ` Leon Romanovsky
2017-05-09 18:21                   ` Jason Gunthorpe
     [not found]                     ` <20170509182123.GC9715-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-09 18:41                       ` Laurence Oberman
2017-05-10 13:30               ` srp_daemon : ​Disallow ​all targets ​if ​not ​explicitly ​allowed " Benjamin Drung
     [not found]                 ` <1494423046.3739.8.camel-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
2017-05-10 14:02                   ` Roland Fehrenbacher
     [not found]                     ` <22803.7541.113159.214164-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2017-05-10 16:05                       ` Leon Romanovsky
2017-05-10 16:06                       ` Bart Van Assche [this message]
     [not found]                         ` <1494432414.2578.9.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-10 16:39                           ` srp_daemon : targets " Roland Fehrenbacher
     [not found]                             ` <22803.16933.196383.482890-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2017-05-10 16:46                               ` Bart Van Assche
     [not found]                                 ` <1494434801.2578.13.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-10 17:13                                   ` Roland Fehrenbacher
     [not found]                                     ` <22803.19010.749349.461444-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2017-05-10 17:15                                       ` Leon Romanovsky
2017-05-10 17:20                                       ` Bart Van Assche
     [not found]                                         ` <1494436821.2578.15.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-05-11  8:50                                           ` Roland Fehrenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494432414.2578.9.camel@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=rf-PKu+Ek1N2UGzQB+pC5nmwQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.