All of lore.kernel.org
 help / color / mirror / Atom feed
From: patrice.chotard at st.com <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 03/14] mmc: sti_sdhci: Use reset framework
Date: Wed, 10 May 2017 18:09:48 +0200	[thread overview]
Message-ID: <1494432599-17924-4-git-send-email-patrice.chotard@st.com> (raw)
In-Reply-To: <1494432599-17924-1-git-send-email-patrice.chotard@st.com>

From: Patrice Chotard <patrice.chotard@st.com>

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>
---

v5:	_ none
v4:	_ none
v3:	_ none
v2:	_ none


 drivers/mmc/sti_sdhci.c | 31 ++++++++++++++++++++++---------
 1 file changed, 22 insertions(+), 9 deletions(-)

diff --git a/drivers/mmc/sti_sdhci.c b/drivers/mmc/sti_sdhci.c
index d6c4d67..8b1b2c0 100644
--- a/drivers/mmc/sti_sdhci.c
+++ b/drivers/mmc/sti_sdhci.c
@@ -8,6 +8,7 @@
 #include <common.h>
 #include <dm.h>
 #include <mmc.h>
+#include <reset-uclass.h>
 #include <sdhci.h>
 #include <asm/arch/sdhci.h>
 
@@ -16,6 +17,7 @@ DECLARE_GLOBAL_DATA_PTR;
 struct sti_sdhci_plat {
 	struct mmc_config cfg;
 	struct mmc mmc;
+	struct reset_ctl reset;
 	int instance;
 };
 
@@ -37,17 +39,19 @@ struct sti_sdhci_plat {
  * W/o these settings the SDHCI could configure and use the embedded controller
  * with limited features.
  */
-static void sti_mmc_core_config(struct udevice *dev)
+static int sti_mmc_core_config(struct udevice *dev)
 {
 	struct sti_sdhci_plat *plat = dev_get_platdata(dev);
 	struct sdhci_host *host = dev_get_priv(dev);
-	unsigned long *sysconf;
+	int ret;
 
 	/* only MMC1 has a reset line */
 	if (plat->instance) {
-		sysconf = (unsigned long *)(STIH410_SYSCONF5_BASE +
-			  ST_MMC_CCONFIG_REG_5);
-		generic_set_bit(SYSCONF_MMC1_ENABLE_BIT, sysconf);
+		ret = reset_deassert(&plat->reset);
+		if (ret < 0) {
+			error("MMC1 deassert failed: %d", ret);
+			return ret;
+		}
 	}
 
 	writel(STI_FLASHSS_MMC_CORE_CONFIG_1,
@@ -66,6 +70,8 @@ static void sti_mmc_core_config(struct udevice *dev)
 	}
 	writel(STI_FLASHSS_MMC_CORE_CONFIG4,
 	       host->ioaddr + FLASHSS_MMC_CORE_CONFIG_4);
+
+	return 0;
 }
 
 static int sti_sdhci_probe(struct udevice *dev)
@@ -80,13 +86,20 @@ static int sti_sdhci_probe(struct udevice *dev)
 	 * MMC0 is wired to the SD slot,
 	 * MMC1 is wired on the high speed connector
 	 */
-
-	if (fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "resets", NULL))
+	if (fdt_getprop(gd->fdt_blob, dev_of_offset(dev), "resets", NULL)) {
 		plat->instance = 1;
-	else
+		ret = reset_get_by_name(dev, "softreset", &plat->reset);
+		if (ret) {
+			error("can't get reset for %s (%d)", dev->name, ret);
+			return ret;
+		}
+	} else {
 		plat->instance = 0;
+	}
 
-	sti_mmc_core_config(dev);
+	ret = sti_mmc_core_config(dev);
+	if (ret)
+		return ret;
 
 	host->quirks = SDHCI_QUIRK_WAIT_SEND_CMD |
 		       SDHCI_QUIRK_32BIT_DMA_ADDR |
-- 
1.9.1

  parent reply	other threads:[~2017-05-10 16:09 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10 16:09 [U-Boot] [PATCH v5 00/14] STiH410-B2260: add reset, usb and fastboot support patrice.chotard at st.com
2017-05-10 16:09 ` [U-Boot] [PATCH v5 01/14] mmc: sti_sdhci: Rework sti_mmc_core_config() patrice.chotard at st.com
2017-05-15  3:02   ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 02/14] ARM: dts: stih410-family: Add missing reset_names for mmc1 node patrice.chotard at st.com
2017-05-15  3:02   ` Simon Glass
2017-05-10 16:09 ` patrice.chotard at st.com [this message]
2017-05-15  3:02   ` [U-Boot] [PATCH v5 03/14] mmc: sti_sdhci: Use reset framework Simon Glass
2017-05-15  9:21     ` Patrice CHOTARD
2017-05-17  1:38       ` Simon Glass
2017-05-17  7:14         ` Patrice CHOTARD
2017-05-20  2:29           ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 04/14] usb: phy: Add STi USB2 PHY patrice.chotard at st.com
2017-05-10 16:09 ` [U-Boot] [PATCH v5 05/14] usb: xhci: Add STi xhci support patrice.chotard at st.com
2017-05-10 21:16   ` Marek Vasut
2017-05-11  7:08     ` Patrice CHOTARD
2017-05-11 11:54       ` Marek Vasut
2017-05-12  8:40         ` Patrice CHOTARD
2017-05-12 10:54           ` Marek Vasut
2017-05-12 11:15             ` Patrice CHOTARD
2017-05-12 11:20               ` Marek Vasut
2017-05-10 16:09 ` [U-Boot] [PATCH v5 06/14] usb: dwc3: Add dwc3 glue driver support for STi patrice.chotard at st.com
2017-05-15  3:02   ` Simon Glass
2017-05-15  9:24     ` Patrice CHOTARD
2017-05-10 16:09 ` [U-Boot] [PATCH v5 07/14] board: STiH410-B2260: add OHCI and XHCI related defines patrice.chotard at st.com
2017-05-15  3:02   ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 08/14] board: STiH410-B2260: add fastboot support patrice.chotard at st.com
2017-05-15  3:02   ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 09/14] STiH410-B2260: enable USB Host Networking patrice.chotard at st.com
2017-05-15  3:03   ` Simon Glass
2017-05-15  9:24     ` Patrice CHOTARD
2017-05-10 16:09 ` [U-Boot] [PATCH v5 10/14] usb: extend generic EHCI with PHY patrice.chotard at st.com
2017-05-10 21:18   ` Marek Vasut
2017-05-11  7:19     ` Patrice CHOTARD
2017-05-11 11:55       ` Marek Vasut
2017-05-12  8:49         ` Patrice CHOTARD
2017-05-12 10:54           ` Marek Vasut
2017-05-12 11:13             ` Patrice CHOTARD
2017-05-10 16:09 ` [U-Boot] [PATCH v5 11/14] ARM: DTS: STiH410: rework ehci nodes patrice.chotard at st.com
2017-05-15  3:03   ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 12/14] usb: extend generic OHCI with clock, reset and phy patrice.chotard at st.com
2017-05-10 21:20   ` Marek Vasut
2017-05-11  9:36     ` Patrice CHOTARD
2017-05-14  9:13   ` Simon Glass
2017-05-15  7:20     ` Patrice CHOTARD
2017-05-10 16:09 ` [U-Boot] [PATCH v5 13/14] ARM: DTS: STiH410: rework ohci nodes patrice.chotard at st.com
2017-05-15  3:03   ` Simon Glass
2017-05-10 16:09 ` [U-Boot] [PATCH v5 14/14] STiH410-B2260: enable USB, fastboot, reset related flags patrice.chotard at st.com
2017-05-15  3:03   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494432599-17924-4-git-send-email-patrice.chotard@st.com \
    --to=patrice.chotard@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.