From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.hgst.iphmx.com ([216.71.154.42]:38880 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbdEJUbG (ORCPT ); Wed, 10 May 2017 16:31:06 -0400 From: Bart Van Assche To: "nab@linux-iscsi.org" CC: "hch@lst.de" , "ddiss@suse.de" , "hare@suse.com" , "target-devel@vger.kernel.org" , "agrover@redhat.com" , "stable@vger.kernel.org" Subject: Re: [PATCH 05/19] target: Allocate sg-list correctly Date: Wed, 10 May 2017 20:31:01 +0000 Message-ID: <1494448260.2578.17.camel@sandisk.com> References: <20170504225102.8931-1-bart.vanassche@sandisk.com> <20170504225102.8931-6-bart.vanassche@sandisk.com> <1494197127.30469.30.camel@haakon3.risingtidesystems.com> <1494265568.2591.12.camel@sandisk.com> <1494389026.16894.69.camel@haakon3.risingtidesystems.com> In-Reply-To: <1494389026.16894.69.camel@haakon3.risingtidesystems.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <8FF3DF4A0E8AD847A95C3828FA1380F2@namprd04.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Tue, 2017-05-09 at 21:03 -0700, Nicholas A. Bellinger wrote: > In any event, the point is your patch to add sbc_parse_verify() broke > existing behavior of WRITE_VERIFY_* by dropping SCF_SCSI_DATA_CDB > assignment for all cases. As I had already explained in detail I disagree with this statement. BTW, d= id you know that your patch "target: Fix sbc_parse_verify bytchk =3D 0 handlin= g" is not sufficient to avoid a buffer overflow in the iSCSI target driver? One w= ay to trigger a buffer overflow is by making the initiator send more immediate data than the Data-Out buffer size derived from the CDB. Bart.=