From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755960AbdEKNcc (ORCPT ); Thu, 11 May 2017 09:32:32 -0400 Received: from mga03.intel.com ([134.134.136.65]:57470 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755478AbdEKNca (ORCPT ); Thu, 11 May 2017 09:32:30 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,324,1491289200"; d="scan'208";a="1167816854" Message-ID: <1494509544.6967.6.camel@linux.intel.com> Subject: Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions From: Andy Shevchenko To: Jarkko Nikula , Luis Oliveira , wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com, mika.westerberg@linux.intel.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ramiro.Oliveira@synopsys.com, Joao.Pinto@synopsys.com, CARLOS.PALMINHA@synopsys.com Date: Thu, 11 May 2017 16:32:24 +0300 In-Reply-To: References: <1494262399.30052.69.camel@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-05-11 at 16:20 +0300, Jarkko Nikula wrote: > On 05/08/2017 07:53 PM, Andy Shevchenko wrote: > > > + } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) { > > > > GENMASK(15, 0) > > > > I don't think this increase readability compared to 0x0000ffff here. If it's a defined constant it might do, otherwise I'm fine with explicit value. -- Andy Shevchenko Intel Finland Oy