From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755871AbdEKN4X (ORCPT ); Thu, 11 May 2017 09:56:23 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:43410 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755737AbdEKN4C (ORCPT ); Thu, 11 May 2017 09:56:02 -0400 X-IronPort-AV: E=Sophos;i="5.38,324,1491235200"; d="scan'208";a="16905353" From: Bart Van Assche To: "linux-scsi@vger.kernel.org" , "colin.king@canonical.com" , "target-devel@vger.kernel.org" , "nab@linux-iscsi.org" CC: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Thread-Topic: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Thread-Index: AQHSyj+jW9v0gz7ex0uWqkHOBl5ZjqHvKCGA Date: Thu, 11 May 2017 13:55:58 +0000 Message-ID: <1494510957.3018.1.camel@sandisk.com> References: <20170511101616.19790-1-colin.king@canonical.com> In-Reply-To: <20170511101616.19790-1-colin.king@canonical.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=sandisk.com; x-originating-ip: [76.102.111.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1535;7:2s67tkNxdNl0swSLytgNOuhnScZpYHUDQx86GDxBeJxYSug1vrNxP0LxFHTn0IB5p9+kScbQfC5t+56Qi9F8dRk1o+j/hR3nuxzldVBswJCXG9BRTivm4pbaY8rU28K3+RO+YMAkZqa3TO4EXOkObL/w7VJ4sX9e6LlqCb39T0vSY0nDI4S+rV43QbBmOukkwdoTHKL/h/mR2JBvehnvCEUvQOqSZv6qozecDiNjND2ZFVBGP3T3NFpRNdGpXkDjRlJT8RFnyCkQ2ELLAHB70pXU2a5f9eZvBtocdyArKi/QEZjTBq9quBq3TDsTue1VtIuTdpDfKIhFtbKzMfehGg==;20:LtZoHy5nuSlovcLQMuPwZ1bs+vjqkqnlZxSeCr5sENilfsg8gwyzcl6p0PiyeM1iaCyR3uEb8qnY1T8aWoyjb6fOUWad4q51XmIact2uVvPHd76yNu5EgFwy8Bknspqq4wVW/lAUsy+mfLaE0Popi9U1vGPae4CzI0kg/kZNP2s= x-ms-office365-filtering-correlation-id: 0eeba45a-c6a5-4cea-02e5-08d4987573a0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:CY1PR0401MB1535; wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(198206253151910); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148);SRVR:CY1PR0401MB1535;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0401MB1535; x-forefront-prvs: 0304E36CA3 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39400400002)(39850400002)(39840400002)(39860400002)(39410400002)(39450400003)(377424004)(51914003)(24454002)(36756003)(86362001)(4326008)(478600001)(25786009)(72206003)(103116003)(2906002)(5660300001)(50986999)(2201001)(6246003)(2900100001)(38730400002)(8936002)(6512007)(54356999)(76176999)(8676002)(81166006)(122556002)(6436002)(229853002)(66066001)(99286003)(6486002)(3660700001)(3846002)(7736002)(6116002)(102836003)(2950100002)(77096006)(305945005)(53936002)(6506006)(33646002)(2501003)(3280700002)(54906002)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1535;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2017 13:55:58.2356 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1535 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v4BDxRpj011021 On Thu, 2017-05-11 at 11:16 +0100, Colin King wrote: > From: Colin Ian King > > Making target_parse_xcopy_cmd static fixes sparse warning: > > "warning: symbol 'target_parse_xcopy_cmd' was not declared. Should > it be static?" > > Fixes: 1bd05294519f76 ("target/iscsi: Fix a deadlock between the XCOPY code and session shutdown") > Signed-off-by: Colin Ian King > --- > drivers/target/target_core_xcopy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/target_core_xcopy.c b/drivers/target/target_core_xcopy.c > index aecb36d955f0..00e0269e6be4 100644 > --- a/drivers/target/target_core_xcopy.c > +++ b/drivers/target/target_core_xcopy.c > @@ -886,7 +886,7 @@ static void target_xcopy_do_work(struct work_struct *work) > * Returns TCM_NO_SENSE upon success or a sense code != TCM_NO_SENSE if parsing > * fails. > */ > -sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) > +static sense_reason_t target_parse_xcopy_cmd(struct xcopy_op *xop) > { > struct se_cmd *se_cmd = xop->xop_se_cmd; > unsigned char *p = NULL, *seg_desc; Hello Colin, Thanks for the patch. I will merge it in patch "target/iscsi: Fix a deadlock between the XCOPY code and session shutdown". Bart. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Thu, 11 May 2017 13:55:58 +0000 Subject: Re: [PATCH] target/iscsi: make function target_parse_xcopy_cmd static Message-Id: <1494510957.3018.1.camel@sandisk.com> List-Id: References: <20170511101616.19790-1-colin.king@canonical.com> In-Reply-To: <20170511101616.19790-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "linux-scsi@vger.kernel.org" , "colin.king@canonical.com" , "target-devel@vger.kernel.org" , "nab@linux-iscsi.org" Cc: "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" T24gVGh1LCAyMDE3LTA1LTExIGF0IDExOjE2ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBG cm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gTWFr aW5nIHRhcmdldF9wYXJzZV94Y29weV9jbWQgc3RhdGljIGZpeGVzIHNwYXJzZSB3YXJuaW5nOg0K PiANCj4gIndhcm5pbmc6IHN5bWJvbCAndGFyZ2V0X3BhcnNlX3hjb3B5X2NtZCcgd2FzIG5vdCBk ZWNsYXJlZC4gIFNob3VsZA0KPiBpdCBiZSBzdGF0aWM/Ig0KPiANCj4gRml4ZXM6IDFiZDA1Mjk0 NTE5Zjc2ICgidGFyZ2V0L2lzY3NpOiBGaXggYSBkZWFkbG9jayBiZXR3ZWVuIHRoZSBYQ09QWSBj b2RlIGFuZCBzZXNzaW9uIHNodXRkb3duIikNCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtp bmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL3RhcmdldC90 YXJnZXRfY29yZV94Y29weS5jIHwgMiArLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy90YXJnZXQvdGFy Z2V0X2NvcmVfeGNvcHkuYyBiL2RyaXZlcnMvdGFyZ2V0L3RhcmdldF9jb3JlX3hjb3B5LmMNCj4g aW5kZXggYWVjYjM2ZDk1NWYwLi4wMGUwMjY5ZTZiZTQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMv dGFyZ2V0L3RhcmdldF9jb3JlX3hjb3B5LmMNCj4gKysrIGIvZHJpdmVycy90YXJnZXQvdGFyZ2V0 X2NvcmVfeGNvcHkuYw0KPiBAQCAtODg2LDcgKzg4Niw3IEBAIHN0YXRpYyB2b2lkIHRhcmdldF94 Y29weV9kb193b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykNCj4gICAqIFJldHVybnMgVENN X05PX1NFTlNFIHVwb24gc3VjY2VzcyBvciBhIHNlbnNlIGNvZGUgIT0gVENNX05PX1NFTlNFIGlm IHBhcnNpbmcNCj4gICAqIGZhaWxzLg0KPiAgICovDQo+IC1zZW5zZV9yZWFzb25fdCB0YXJnZXRf cGFyc2VfeGNvcHlfY21kKHN0cnVjdCB4Y29weV9vcCAqeG9wKQ0KPiArc3RhdGljIHNlbnNlX3Jl YXNvbl90IHRhcmdldF9wYXJzZV94Y29weV9jbWQoc3RydWN0IHhjb3B5X29wICp4b3ApDQo+ICB7 DQo+ICAJc3RydWN0IHNlX2NtZCAqc2VfY21kID0geG9wLT54b3Bfc2VfY21kOw0KPiAgCXVuc2ln bmVkIGNoYXIgKnAgPSBOVUxMLCAqc2VnX2Rlc2M7DQoNCkhlbGxvIENvbGluLA0KDQpUaGFua3Mg Zm9yIHRoZSBwYXRjaC4gSSB3aWxsIG1lcmdlIGl0IGluIHBhdGNoICJ0YXJnZXQvaXNjc2k6IEZp eCBhIGRlYWRsb2NrIGJldHdlZW4gdGhlDQpYQ09QWSBjb2RlIGFuZCBzZXNzaW9uIHNodXRkb3du Ii4NCg0KQmFydC4