From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756947AbdELFs6 (ORCPT ); Fri, 12 May 2017 01:48:58 -0400 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:55435 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752456AbdELFs4 (ORCPT ); Fri, 12 May 2017 01:48:56 -0400 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 165.244.249.23 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com From: Byungchul Park To: , CC: , , , , Subject: [PATCH v4 1/5] sched/deadline: Refer to cpudl.elements atomically Date: Fri, 12 May 2017 14:48:45 +0900 Message-ID: <1494568129-9985-2-git-send-email-byungchul.park@lge.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1494568129-9985-1-git-send-email-byungchul.park@lge.com> References: <1494568129-9985-1-git-send-email-byungchul.park@lge.com> X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/05/12 14:48:52, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/05/12 14:48:53, Serialize complete at 2017/05/12 14:48:53 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpudl.elements is an instance that should be protected with a spin lock. Without it, the code would be insane. Current cpudl_find() has problems like, 1. cpudl.elements[0].cpu might not match with cpudl.elements[0].dl. 2. cpudl.elements[0].dl(u64) might not be referred atomically. 3. Two cpudl_maximum()s might return different values. 4. It's just insane. Signed-off-by: Byungchul Park --- kernel/sched/cpudeadline.c | 37 ++++++++++++++++++++++++++++++------- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c index fba235c..6b67016 100644 --- a/kernel/sched/cpudeadline.c +++ b/kernel/sched/cpudeadline.c @@ -131,16 +131,39 @@ int cpudl_find(struct cpudl *cp, struct task_struct *p, cpumask_and(later_mask, cp->free_cpus, &p->cpus_allowed)) { best_cpu = cpumask_any(later_mask); goto out; - } else if (cpumask_test_cpu(cpudl_maximum(cp), &p->cpus_allowed) && - dl_time_before(dl_se->deadline, cp->elements[0].dl)) { - best_cpu = cpudl_maximum(cp); - if (later_mask) - cpumask_set_cpu(best_cpu, later_mask); + } else { + u64 cpudl_dl; + int cpudl_cpu; + int cpudl_valid; + unsigned long flags; + + /* + * Referring to cp->elements must be atomic ops. + */ + raw_spin_lock_irqsave(&cp->lock, flags); + /* + * No problem even in case of very initial heap tree + * to which no entry has been added yet, since + * cp->elements[0].cpu was initialized to zero and + * cp->elements[0].idx was initialized to IDX_INVALID, + * that means the case will be filtered out at the + * following condition. + */ + cpudl_cpu = cpudl_maximum(cp); + cpudl_dl = cp->elements[0].dl; + cpudl_valid = cp->elements[cpudl_cpu].idx; + raw_spin_unlock_irqrestore(&cp->lock, flags); + + if (cpudl_valid != IDX_INVALID && + cpumask_test_cpu(cpudl_cpu, &p->cpus_allowed) && + dl_time_before(dl_se->deadline, cpudl_dl)) { + best_cpu = cpudl_cpu; + if (later_mask) + cpumask_set_cpu(best_cpu, later_mask); + } } out: - WARN_ON(best_cpu != -1 && !cpu_present(best_cpu)); - return best_cpu; } -- 1.9.1