From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 17/19] crypto/ccp: support cpu based md5
	and sha2 family authentication algo
Date: Sun, 22 Apr 2018 22:08:59 +0200
Message-ID: <14946114.ASIPbkMQcp@xps>
References: <1520584520-130522-1-git-send-email-Ravi1.kumar@amd.com>
 <1521462233-13590-1-git-send-email-Ravi1.kumar@amd.com>
 <1521462233-13590-17-git-send-email-Ravi1.kumar@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, hemant.agrawal@nxp.com
To: Ravi Kumar <Ravi1.kumar@amd.com>, pablo.de.lara.guarch@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 94F081066
 for <dev@dpdk.org>; Sun, 22 Apr 2018 22:09:03 +0200 (CEST)
In-Reply-To: <1521462233-13590-17-git-send-email-Ravi1.kumar@amd.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

I am doing some late comments because I have a quick look when trying
to pull next-crypto in master branch.
Unfortunately, it doesn't met the basic quality criterias.


19/03/2018 13:23, Ravi Kumar:
> Signed-off-by: Ravi Kumar <Ravi1.kumar@amd.com>
> ---
>  config/common_base                   |   1 +
>  drivers/crypto/ccp/ccp_crypto.c      | 282 ++++++++++++++++++++++++++++++++++-
>  drivers/crypto/ccp/ccp_crypto.h      |   5 +-
>  drivers/crypto/ccp/ccp_pmd_ops.c     |  23 +++
>  drivers/crypto/ccp/ccp_pmd_private.h |  10 ++
>  5 files changed, 316 insertions(+), 5 deletions(-)
[...]
> +CONFIG_RTE_LIBRTE_PMD_CCP_CPU_AUTH=n

Why introducing a compile-time option?
Can it be a run-time option of the device?
We must not add compile-time device option if not well justified.

Talking about justification, there is 0 explanation in the commit messages.
But there are some in next-crypto tree. Where do they come from?