Re: [PATCH v2 4/4] drm/i915: enable guest full ppgtt when device model supports

[Joonas Lahtinen <joonas.lahtinen@linux.intel.com>]

On pe, 2017-05-12 at 17:37 +0800, Tina Zhang wrote:
> Add full ppgtt capability check in guest i915 driver and enable the full
> ppgtt in guest only when device mode supports.
> 
> Changes since v1:
> - Use u32 instead of uint32_t. (Joonas)
> - Rewrite the vgpu full ppgtt capability checking logic. (Joonas)
> - Some coding style refine. (Joonas)
> 
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>

This patch should be prior to GVT patches in the series to avoid
breaking bisecting, which means that when the patches are applied one-
by-one, each intermediary step produces a working kernel.

Thi could be squashed to the patch that includes the declarations and
#define in i915 side so that this series would be one patch in i915
side to add the declaration and one patch in GVT side which implements
the functionality and enables the capability.

One comment below.

<SNIP>

> @@ -139,13 +139,12 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
>  
>  	has_aliasing_ppgtt = dev_priv->info.has_aliasing_ppgtt;
>  	has_full_ppgtt = dev_priv->info.has_full_ppgtt;
> -	has_full_48bit_ppgtt = dev_priv->info.has_full_48bit_ppgtt;
>  
> -	if (intel_vgpu_active(dev_priv)) {
> -		/* emulation is too hard */
> -		has_full_ppgtt = false;
> -		has_full_48bit_ppgtt = false;
> -	}
> +	if (intel_vgpu_active(dev_priv))
> +		has_full_ppgtt = intel_vgpu_has_full_ppgtt(dev_priv);
> +
> +	has_full_48bit_ppgtt = has_full_ppgtt &&
> +				dev_priv->info.has_full_48bit_ppgtt;

This line is not correctly aligned.

With the alignment fixed, this is:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx