Re: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine types

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine types
Message-id: 149484833874.20089.4164801378197848306.stgit@bahia.lan
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/149484833874.20089.4164801378197848306.stgit@bahia.lan -> patchew/149484833874.20089.4164801378197848306.stgit@bahia.lan
Switched to a new branch 'test'
3c3824a spapr: fix migration of ICP objects from/to older QEMU
280164f spapr-cpu-core: release ICP object when realization fails
5bc72eb spapr: sanitize error handling in spapr_ics_create()
fa15d00 spapr: fix error reporting in xics_system_init()
ecbe234 spapr: fix error path of required kernel-irqchip
b7cf73d ppc/xics: simplify prototype of xics_spapr_init()

=== OUTPUT BEGIN ===
Checking PATCH 1/6: ppc/xics: simplify prototype of xics_spapr_init()...
Checking PATCH 2/6: spapr: fix error path of required kernel-irqchip...
Checking PATCH 3/6: spapr: fix error reporting in xics_system_init()...
Checking PATCH 4/6: spapr: sanitize error handling in spapr_ics_create()...
Checking PATCH 5/6: spapr-cpu-core: release ICP object when realization fails...
Checking PATCH 6/6: spapr: fix migration of ICP objects from/to older QEMU...
ERROR: "foo* bar" should be "foo *bar"
#50: FILE: hw/ppc/spapr.c:167:
+            void* obj = &spapr->legacy_icps[i];

total: 1 errors, 0 warnings, 122 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org