Re: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

[no-reply@patchew.org]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM
Message-id: 1da30c06-46bd-47fa-b0ef-886ea9ab84e5@ONE.local

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d9e7e6b Add code to connect to external panel, for ARM

=== OUTPUT BEGIN ===
Checking PATCH 1/1: Add code to connect to external panel, for ARM...
WARNING: line over 80 characters
#169: FILE: hw/arm/bcm2835_peripherals.c:307:
+    memory_region_add_subregion(&s->mbox_mr, MBOX_CHAN_POWER << MBOX_AS_CHAN_SHIFT,

ERROR: spaces required around that '=' (ctx:VxV)
#182: FILE: hw/arm/bcm2835_peripherals.c:444:
+    dc->user_creatable=false;
                       ^

WARNING: line over 80 characters
#450: FILE: hw/gpio/bcm2835_gpio.c:397:
+                                           .instance_size = sizeof(BCM2835GpioState),

WARNING: line over 80 characters
#452: FILE: hw/gpio/bcm2835_gpio.c:399:
+                                           .class_init = bcm2835_gpio_class_init,

WARNING: architecture specific defines should be avoided
#500: FILE: include/qemu/PanelEmu.h:17:
+#ifdef __cplusplus

ERROR: code indent should never use tabs
#517: FILE: include/qemu/PanelEmu.h:34:
+^I                       unless something changed */$

WARNING: architecture specific defines should be avoided
#531: FILE: include/qemu/PanelEmu.h:48:
+#ifdef __cplusplus

WARNING: architecture specific defines should be avoided
#555: FILE: util/PanelEmu.c:13:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#686: FILE: util/PanelEmu.c:144:
+#ifdef __MINGW32__

ERROR: space required after that ',' (ctx:VxV)
#710: FILE: util/PanelEmu.c:168:
+    int i,j;
          ^

WARNING: architecture specific defines should be avoided
#780: FILE: util/PanelEmu.c:238:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#800: FILE: util/PanelEmu.c:258:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#808: FILE: util/PanelEmu.c:266:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#817: FILE: util/PanelEmu.c:275:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#825: FILE: util/PanelEmu.c:283:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#839: FILE: util/PanelEmu.c:297:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#856: FILE: util/PanelEmu.c:314:
+#ifdef __MINGW32__

WARNING: architecture specific defines should be avoided
#864: FILE: util/PanelEmu.c:322:
+#ifdef __MINGW32__

total: 3 errors, 15 warnings, 794 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org