From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967723AbdEXJVI (ORCPT ); Wed, 24 May 2017 05:21:08 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47558 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S967544AbdEXJUw (ORCPT ); Wed, 24 May 2017 05:20:52 -0400 Message-ID: <1495617645.15919.6.camel@mtksdaap41> Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions From: CK Hu To: Daniel Vetter , Bibby Hsieh CC: David Airlie , Matthias Brugger , Daniel Vetter , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , Cawa Cheng =?UTF-8?Q?=28=E9=84=AD=E6=9B=84=E7=A6=A7=29?= , Daniel Kurtz , Philipp Zabel , YT Shen =?UTF-8?Q?=28=E6=B2=88=E5=B2=B3=E9=9C=86=29?= , Thierry Reding , Mao Huang , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Sascha Hauer Date: Wed, 24 May 2017 17:20:45 +0800 In-Reply-To: <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> <1495531695.20811.19.camel@mtksdaap41> <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote: > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote: > > Hi, Bibby: > > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1, > > thanks. > > > > Regards, > > CK > > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote: > > > Current Mediatek DRM driver does not support interlaced mode, and > > > will hang if such resolution is used: Filter those to prevent > > > kernel hangs, until the DRM driver is fixed properly. > > > > > > Signed-off-by: Bibby Hsieh > > > --- > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > index 0e8c4d9..e33678d 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, > > > return MODE_BAD; > > > } > > > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > > > + return MODE_NO_INTERLACE; > > > if (mode->clock < 27000) > > > return MODE_CLOCK_LOW; > > > if (mode->clock > 297000) > > You probably want to check out Jose's mode_valid work, since only > filtering in the connector's ->mode_valid callback isn't enough. You also > need to filter in ->mode_fixup (or some other place called at atomic_check > time). > -Daniel Hi, Daniel: Yes, I still need to filter in ->mode_fixup. Hi, Bibby: Because Jose's work plan to use mode_valid to replace mode_fixup, so it's better to refine this patch after Jose's work is done. And I would now remove this patch from my branch. Regards, CK From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions Date: Wed, 24 May 2017 17:20:45 +0800 Message-ID: <1495617645.15919.6.camel@mtksdaap41> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> <1495531695.20811.19.camel@mtksdaap41> <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Bibby Hsieh Cc: "linux-kernel@vger.kernel.org" , Sascha Hauer , Daniel Vetter , Cawa Cheng =?UTF-8?Q?=28=E9=84=AD=E6=9B=84=E7=A6=A7=29?= , "dri-devel@lists.freedesktop.org" , Mao Huang , "linux-mediatek@lists.infradead.org" , Matthias Brugger , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org T24gVHVlLCAyMDE3LTA1LTIzIGF0IDE1OjEyICswMjAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IE9uIFR1ZSwgTWF5IDIzLCAyMDE3IGF0IDA1OjI4OjE1UE0gKzA4MDAsIENLIEh1IHdyb3RlOgo+ ID4gSGksIEJpYmJ5Ogo+ID4gCj4gPiBJJ3ZlIGFwcGxpZWQgdGhpcyBwYXRjaCB0byBteSBicmFu Y2ggbWVkaWF0ZWstZHJtLWZpeGVzLTQuMTItcmMxLAo+ID4gdGhhbmtzLgo+ID4gCj4gPiBSZWdh cmRzLAo+ID4gQ0sKPiA+IAo+ID4gT24gVHVlLCAyMDE3LTAxLTI0IGF0IDEzOjEwICswODAwLCBC aWJieSBIc2llaCB3cm90ZToKPiA+ID4gQ3VycmVudCBNZWRpYXRlayBEUk0gZHJpdmVyIGRvZXMg bm90IHN1cHBvcnQgaW50ZXJsYWNlZCBtb2RlLCBhbmQKPiA+ID4gd2lsbCBoYW5nIGlmIHN1Y2gg cmVzb2x1dGlvbiBpcyB1c2VkOiBGaWx0ZXIgdGhvc2UgdG8gcHJldmVudAo+ID4gPiBrZXJuZWwg aGFuZ3MsIHVudGlsIHRoZSBEUk0gZHJpdmVyIGlzIGZpeGVkIHByb3Blcmx5Lgo+ID4gPiAKPiA+ ID4gU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVrLmNvbT4K PiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2hkbWkuYyB8IDIg KysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+ID4gCj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVkaWF0ZWsvbXRrX2hkbWkuYyBiL2RyaXZlcnMv Z3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jCj4gPiA+IGluZGV4IDBlOGM0ZDkuLmUzMzY3OGQg MTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jCj4g PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfaGRtaS5jCj4gPiA+IEBAIC0x MjQ0LDYgKzEyNDQsOCBAQCBzdGF0aWMgaW50IG10a19oZG1pX2Nvbm5fbW9kZV92YWxpZChzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubiwKPiA+ID4gIAkJCXJldHVybiBNT0RFX0JBRDsKPiA+ID4g IAl9Cj4gPiA+ICAKPiA+ID4gKwlpZiAobW9kZS0+ZmxhZ3MgJiBEUk1fTU9ERV9GTEFHX0lOVEVS TEFDRSkKPiA+ID4gKwkJcmV0dXJuIE1PREVfTk9fSU5URVJMQUNFOwo+ID4gPiAgCWlmIChtb2Rl LT5jbG9jayA8IDI3MDAwKQo+ID4gPiAgCQlyZXR1cm4gTU9ERV9DTE9DS19MT1c7Cj4gPiA+ICAJ aWYgKG1vZGUtPmNsb2NrID4gMjk3MDAwKQo+IAo+IFlvdSBwcm9iYWJseSB3YW50IHRvIGNoZWNr IG91dCBKb3NlJ3MgbW9kZV92YWxpZCB3b3JrLCBzaW5jZSBvbmx5Cj4gZmlsdGVyaW5nIGluIHRo ZSBjb25uZWN0b3IncyAtPm1vZGVfdmFsaWQgY2FsbGJhY2sgaXNuJ3QgZW5vdWdoLiBZb3UgYWxz bwo+IG5lZWQgdG8gZmlsdGVyIGluIC0+bW9kZV9maXh1cCAob3Igc29tZSBvdGhlciBwbGFjZSBj YWxsZWQgYXQgYXRvbWljX2NoZWNrCj4gdGltZSkuCj4gLURhbmllbAoKSGksIERhbmllbDoKClll cywgSSBzdGlsbCBuZWVkIHRvIGZpbHRlciBpbiAtPm1vZGVfZml4dXAuCgpIaSwgQmliYnk6CgpC ZWNhdXNlIEpvc2UncyB3b3JrIHBsYW4gdG8gdXNlIG1vZGVfdmFsaWQgdG8gcmVwbGFjZSBtb2Rl X2ZpeHVwLCBzbwppdCdzIGJldHRlciB0byByZWZpbmUgdGhpcyBwYXRjaCBhZnRlciBKb3NlJ3Mg d29yayBpcyBkb25lLiBBbmQgSSB3b3VsZApub3cgcmVtb3ZlIHRoaXMgcGF0Y2ggZnJvbSBteSBi cmFuY2guCgpSZWdhcmRzLApDSwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Wed, 24 May 2017 17:20:45 +0800 Subject: [PATCH] drm/mediatek: hdmi: Filter interlaced resolutions In-Reply-To: <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> References: <1485234604-19889-1-git-send-email-bibby.hsieh@mediatek.com> <1495531695.20811.19.camel@mtksdaap41> <20170523131243.5bjz5n4uv73r2l7j@phenom.ffwll.local> Message-ID: <1495617645.15919.6.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-05-23 at 15:12 +0200, Daniel Vetter wrote: > On Tue, May 23, 2017 at 05:28:15PM +0800, CK Hu wrote: > > Hi, Bibby: > > > > I've applied this patch to my branch mediatek-drm-fixes-4.12-rc1, > > thanks. > > > > Regards, > > CK > > > > On Tue, 2017-01-24 at 13:10 +0800, Bibby Hsieh wrote: > > > Current Mediatek DRM driver does not support interlaced mode, and > > > will hang if such resolution is used: Filter those to prevent > > > kernel hangs, until the DRM driver is fixed properly. > > > > > > Signed-off-by: Bibby Hsieh > > > --- > > > drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > index 0e8c4d9..e33678d 100644 > > > --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c > > > @@ -1244,6 +1244,8 @@ static int mtk_hdmi_conn_mode_valid(struct drm_connector *conn, > > > return MODE_BAD; > > > } > > > > > > + if (mode->flags & DRM_MODE_FLAG_INTERLACE) > > > + return MODE_NO_INTERLACE; > > > if (mode->clock < 27000) > > > return MODE_CLOCK_LOW; > > > if (mode->clock > 297000) > > You probably want to check out Jose's mode_valid work, since only > filtering in the connector's ->mode_valid callback isn't enough. You also > need to filter in ->mode_fixup (or some other place called at atomic_check > time). > -Daniel Hi, Daniel: Yes, I still need to filter in ->mode_fixup. Hi, Bibby: Because Jose's work plan to use mode_valid to replace mode_fixup, so it's better to refine this patch after Jose's work is done. And I would now remove this patch from my branch. Regards, CK