From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "James.Bottomley@HansenPartnership.com" , "hare@suse.de" , "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "hch@lst.de" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "axboe@fb.com" , "hare@suse.com" Subject: Re: [PATCH 11/31] block: Introduce queue flag QUEUE_FLAG_SCSI_SUP Date: Wed, 24 May 2017 15:05:28 +0000 Message-ID: <1495638326.2823.1.camel@sandisk.com> References: <20170524003420.5381-1-bart.vanassche@sandisk.com> <20170524003420.5381-12-bart.vanassche@sandisk.com> In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-scsi-owner@vger.kernel.org List-ID: On Wed, 2017-05-24 at 08:01 +0200, Hannes Reinecke wrote: > On 05/24/2017 02:34 AM, Bart Van Assche wrote: > > From the context where a SCSI command is submitted it is not always > > possible to figure out whether or not the queue the command is > > submitted to has struct scsi_request as the first member of its > > private data. Hence introduce the flag QUEUE_FLAG_SCSI_SUP. > >=20 > > Signed-off-by: Bart Van Assche > > Cc: Jens Axboe > > Cc: Christoph Hellwig > > Cc: Omar Sandoval > > Cc: Hannes Reinecke > > --- > > block/bsg-lib.c | 1 + > > drivers/block/cciss.c | 1 + > > drivers/ide/ide-probe.c | 1 + > > drivers/scsi/scsi_lib.c | 2 ++ > > drivers/scsi/scsi_transport_sas.c | 1 + > > include/linux/blkdev.h | 2 ++ > > 6 files changed, 8 insertions(+) > >=20 >=20 > Bit of an odd name; what about QUEUE_FLAG_SCSI_PDU? Hello Hannes, That sounds like a good idea to me. I will rename the flag when I repost th= is series. Bart.= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 11/31] block: Introduce queue flag QUEUE_FLAG_SCSI_SUP Date: Wed, 24 May 2017 15:05:28 +0000 Message-ID: <1495638326.2823.1.camel@sandisk.com> References: <20170524003420.5381-1-bart.vanassche@sandisk.com> <20170524003420.5381-12-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from esa4.hgst.iphmx.com ([216.71.154.42]:62400 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968318AbdEXPFc (ORCPT ); Wed, 24 May 2017 11:05:32 -0400 In-Reply-To: Content-Language: en-US Content-ID: <20F66673948DB74E8B23632E296A85FB@namprd04.prod.outlook.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "James.Bottomley@HansenPartnership.com" , "hare@suse.de" , "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "hch@lst.de" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "axboe@fb.com" , "hare@suse.com" On Wed, 2017-05-24 at 08:01 +0200, Hannes Reinecke wrote: > On 05/24/2017 02:34 AM, Bart Van Assche wrote: > > From the context where a SCSI command is submitted it is not always > > possible to figure out whether or not the queue the command is > > submitted to has struct scsi_request as the first member of its > > private data. Hence introduce the flag QUEUE_FLAG_SCSI_SUP. > >=20 > > Signed-off-by: Bart Van Assche > > Cc: Jens Axboe > > Cc: Christoph Hellwig > > Cc: Omar Sandoval > > Cc: Hannes Reinecke > > --- > > block/bsg-lib.c | 1 + > > drivers/block/cciss.c | 1 + > > drivers/ide/ide-probe.c | 1 + > > drivers/scsi/scsi_lib.c | 2 ++ > > drivers/scsi/scsi_transport_sas.c | 1 + > > include/linux/blkdev.h | 2 ++ > > 6 files changed, 8 insertions(+) > >=20 >=20 > Bit of an odd name; what about QUEUE_FLAG_SCSI_PDU? Hello Hannes, That sounds like a good idea to me. I will rename the flag when I repost th= is series. Bart.=