From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1035434AbdEXUmF (ORCPT ); Wed, 24 May 2017 16:42:05 -0400 Received: from mail-by2nam03on0041.outbound.protection.outlook.com ([104.47.42.41]:7584 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031752AbdEXUmC (ORCPT ); Wed, 24 May 2017 16:42:02 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; From: Yazen Ghannam To: CC: Borislav Petkov , Tony Luck , , , Yazen Ghannam Subject: [PATCH 1/3] x86/mce/AMD: Use msr_stat when clearing MCA_STATUS Date: Wed, 24 May 2017 15:41:45 -0500 Message-ID: <1495658507-7413-1-git-send-email-Yazen.Ghannam@amd.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR20CA0046.namprd20.prod.outlook.com (10.171.161.160) To CY4PR1201MB0133.namprd12.prod.outlook.com (10.172.78.15) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR1201MB0133: X-MS-Office365-Filtering-Correlation-Id: 82a04f04-fa3c-4c61-f571-08d4a2e55379 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:CY4PR1201MB0133; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0133;3:rYfzT96nvT8Q5ByXZ1EdlzrsDa0GLAhxpWwMGd/upCrlk73RFvaKI7Fok1e5G5CjC3S6aTLmZCadNzqo8U15vfcUNnw2GIQWMoj9VT4ueaBquacD4CRqeofpdgFqIednyp7vW/f/VxMw9KsljNEdRncJmlNlsA8/QBridlNi4GhjrBpDli/8BFS7Sg7EkTMhkL2Q35nlyMkLeM9yS0pUrgNH2OCVRq+2Gg4GpmYhVZk4lc/MdvuGPvb9Si8n9/hwXkUvn8SUBHlgmTKZJ+9YtxwUdhIakQ5dbMFQ4JKTEEEdz4cszoyPyz+XyqGjimSSYxVQy5azGJaDZhig+Y81OwhyJbxW7/uZQ1kDz/4n8Is=;25:0ZJtuNCNAMusQar1wztXa1IgtVHkz+gpJ3tIq6WRgtaR861AXH8iTCJLsW6uPOJqWq06uY5SQa8sfm8Pq0pAhQ9rHTMsYfSTcva5wXDMuYn8wUQm7AtC/9tGdwGw3cC54iNOkQzLdmmC9nD75/B/MKVULuMBGnc4zJpKdCghMzVME4oFHit0uE4lin/jEgAvEkmZFNFPiUzEiX9QQB+Wb9lnoYnCjuu/9Hq28TGbqlIHpVHrMr5Z1QgUpdXWa6BRjkcIFbdr386A+TWxgAm3M7izSdw7QHVzwwf+nZDfC9kj14ckRSKQEZdGokryP3q3/o2uXb2le2S6KbmzyHAfNA2mD1nbZNzYuVI2ifzJB/KG0ntfTOVSApM1ToaIdAEIxOKTjyYqJoQq0GzEL3ilYgzbYJvTSB42YnRkM0KzVpB03jMDcPfVUqljLgD2Q/PFnwG4MK7mYMjfjfYN95aK/jDMPzwGWPlH1N8xt5gwcIc= X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0133;31:tqUU8MoB+Xm7MJ8x2Ty2fQk7Sc/E8travlyplWDEnvAyvc7c9BFirbn9bcDWr8HuE74SiCZX6Z+foxzQ+duWUlRR05ZU9nXJaZo/hAwaDNF7StwxVVq9I8KnDV85RuPr7Hcwnkd+TcS8y1bKtoHL9Az/D4MvYKStN/TmeKgWvvQIxQtgOf/XcZN4b44BOC+9kCQ3Ry6jdb1MuGqGrF0XUOwy4Bm8TktssrSlivXbwtw=;20:uk2kzWXVtcHQ3FPz78bEqr5HGzAeolFzTpm+8YeqT/0LJ0XPpfZb+az2nTH0wnq9/zT3tzaJW5fp9dqdNzUbwr/oRlsdxa52K/QD1C9m5PmK1SLpavO4a9mX7As3eNHdggN3ohqiuV20f7QVTvOH2Jn/jo6jClrbic4l2bAuq4Dsx4VPvOxIHcd5kMtxBDUDkn6uJZ5aV9XNdkHwpGyc5f7ndGCduThwi98/5CeQQ62WTiTlCnXNDMABNTYJtAtg2BL83WAxBSs84GLrwGjQCIBc4Fi03B3N6azoh3h36uZCD75fyHo65DemWyEJrwr8fPBLfYviG+CidDXcxzL5iRemTeT91Zt/9bTubXYn7rX6mf7y50tepRqvMRPLNZYcdg+5HuPAeMMfb28QaPU3PCxqCrBunr8t71pY+03FwGkwz/11OpfaR05t1bEUVzwu27PyO9phvwopAqYjbke1+1PlMAYIDv40LvXDl3W+FOlrY7aBNddzlOkL5VUIHvbU X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123560025)(20161123562025)(6072148);SRVR:CY4PR1201MB0133;BCL:0;PCL:0;RULEID:;SRVR:CY4PR1201MB0133; X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0133;4:olHfm5QGXPwNKd3cIJ3AB0m4bhd/5pNRKWcYHkxdsyfB9aOxpmhlsib6Z/WOFkTsdwSIAJMVDwYn7EFrPP96scCFBIZ1pMFvG6ZQpEpiXLnofPPuifaXSDyU7AYd3XKmuj0yB+VAhHB+WmqEeWqPQm9jJjbr9KU+RP6g7ZMEJuzRW7JyOXb6djiBm2LEUcRJRXeudJIgVnhwVPI04HAuR0k/wgI0rkPmWEt4FivzfWOYoO8wisrTjKe0OI1wEJVGzoSuBMIof7Pu+rPmbWcZB0hHmLcbhw0ZOyzGw3Zkb4YTTCDQVhKRHR19cHOGFl5jp8r7LxopccdZ8bdKuaNGweGzalvuwYcRQ3gPBM2uih/XFA0B3DIzvD7dfrXYwjo60FlEq9oeXawDzf9kvkJ2NRRnz6+Cy5gL4FJi+6RoLTu2GqDhaBqdbbu7BVZBTqaX7TGx95ilPiEOPq1twC5OH6I/j88U2QiF0wVDxCpzIB7yCJJHqK8nTNreyOHZ3asmyWJwzySnqR21djEuIUgzBnXzWj0wePi5eytlavfYwrKSaI3PAmNdI614YB7bV+MXzxEpvkDp2Nw3wSrS7B1VztMrqT38+DYGVdyeIbh3PRcUhOlVbNEo6ScBingElzkWXCKqxn0VFaapYGxhRBqeenFPIRLiLYWW/eeALOJsL/Y7SAGOkWqnuhGzdBfASTvihOhqFdRIXYdUreBHWO4m6cX1xPZnybPDwo28GHrvXvdhriP9ST5Zmzx7NXpU2QEm0WuelDhm5W4LuXNl+hfOOsKlCpSsWV+yLJFN5Cbh1fh5IX50uioL4Y+ezmzZSp2Kq/pomDzJ8+8OiyQBYedhCboJyKuRDtpLJASPD4MNQBI= X-Forefront-PRVS: 031763BCAF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39850400002)(39400400002)(39410400002)(39860400002)(39840400002)(39450400003)(42186005)(72206003)(6116002)(53416004)(54906002)(3846002)(50986999)(6916009)(305945005)(2351001)(86362001)(7736002)(6486002)(5003940100001)(53936002)(25786009)(110136004)(38730400002)(47776003)(2906002)(50226002)(8676002)(81166006)(478600001)(66066001)(189998001)(4326008)(50466002)(5660300001)(36756003)(6666003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR1201MB0133;H:yaz-diesel.amd.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR1201MB0133;23:PEc1DEhAGVMIcvAmIBt5iGySSTCD3EE65tTumRU?= =?us-ascii?Q?LrUUY+59hdj49pBMXMQi1/MM0DoUHzOPKvBUtteW8IyT1vlIOpjMQYcPauKY?= =?us-ascii?Q?ocHGhQJ/jTXZvDZtLfjLp3DFzWEV4fVtD+6HUXRpQ7PPppS2jESoJn8izei3?= =?us-ascii?Q?IwpoGUkScPdrIgp5sWqEKn/B/SL7TcwX2Aqmw8SuFV8/FCQNZ7OMroh6/YTU?= =?us-ascii?Q?lxc0+ESvTDCOn+p2TI2LJmo9CvrpM2N4G6YZOIla5X12k8XpTG1v01gMXhu9?= =?us-ascii?Q?OTAn1b7bfkID/8WpqFU/tZGmFkcqaizlY1w1jXi1S6wprltAYxiSrtkUGaHV?= =?us-ascii?Q?UHiZekIpeiieR576hjON8Ot2rQGOjNWADhAwu+PVORTMxzH5GfPLErl2m+9J?= =?us-ascii?Q?dU609bH7Rj7k9rRSqLRk5spZh/zTkBXilZL5GFS9V6Q5CKVSZh3UA73YCU0V?= =?us-ascii?Q?gxIU57hxMmyPd7OSdkakHNEVPip+lzPU/OzfONGCd2hdTs4hmBadtpaYo9PO?= =?us-ascii?Q?O5aRzhGig8zANK8uNGlgadLx6xsP+cvv5eth7nzIIw/Keyp75TA+vyLRtuqc?= =?us-ascii?Q?fZb0iJv01eesjcPOJwspeB3wolDdqiYGakb6/NS0Of5m5GZxEifBWyTxIbj6?= =?us-ascii?Q?wRbSs2O/M8jYIWnrDCIuf0sL0NkO12nNiUVUcbXiyYNvxR5o6pcG1gDxTyHs?= =?us-ascii?Q?Mfosjs+SHAzXmKtMJOctOradDJB+80snHHlt4Jg1jQqwlj+aLVOcjxiRdOf8?= =?us-ascii?Q?BqlFzW798NFI7bfEzcSjqp3M56hDKDCrubub3YOn7tjE5y4/l1Ydg0QSsieM?= =?us-ascii?Q?wP/PcA36VO/PoUB+m5AJq8fYuhnSgK4qSBpWB/dZprKx/5DVAnuvQd8wA23W?= =?us-ascii?Q?4lrjVAJ0qkwniqdH7bNybasK9E4Xna3/RP4amm8r3bVbOkoDKdhFEev2Ce+B?= =?us-ascii?Q?4aqXU8UsT6wowKt78s6qcQHTZTckBCrLPyjbIfkA4W3C4D50cpW+lW4wRTdL?= =?us-ascii?Q?+9XU/C1XsZUOA5IU9CSbjzr5X?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0133;6:Aek2LVoc2gj4uE1jEtIGNAwe1N9pYIH7WZngr6n/iwvJmJjLPlq32qcS2mSrPGh0/KtWq0OobGiAvdu1Lw3mdrQFLn3Xkf99FSeL7xNAtdPHkK9w9HV5ua+ZH8oVVCShNjrqxFj2CuqRbyXftNQcdhdRzBCS9h0ypidPWgeHqNsQ4rT8EXSe17Dbxz8JErkXY2DAkNSqJKp5DIXXwCtPnQRn1tVJ3hATvxw6JEbrnxa2ehKy81x9m8nMEpv1uSI7CZdcD3zu/3bS3akAl/C5uO1BRg3P2ZLW4hTzqZIPh+i77XBA+cZ9/NKHxmjM2gwzWC/vY99cfjj3jfABiLBYNqlrme3CaXItMEXLtbbfavDdze8bYX8gv7x7rkZ9Zx720oEO9lERpU3VzgejbtwYQQM3y8SqpOu+zbT3wmKiO6X4vwYWtcKNHEr7rggu7UfaFQ1xN/q8do76owHzA7mrxc1FkAmbcdCbgUiJv+FbCPdsU79H2oua2b8Kc/Hs2YsJSw+lbMmoDEkq9xuZM9glGuybU2eMiy2dXS+LhCPeUvM=;5:wSYkk52S4dqQptGCo1GaDDQivbpMJIOGdieGamh2VBhLRKBlx2nYuWmCH9mjit2s3wA6LoDsZB+6YcVqGDjA0n5kAJmX8B0chCU5v83ucE+5h8ccCmFigodXFFVFDAyK9tS745CBBMtPDyOgryFb5ROTAlLEC6pu9iVCc5HY5+E=;24:xFdqiZX+1JKjN2EqaoTm3+10uI/9PSrkRF7No1ghIDVjSBMCyUdn8JQbRuSdDepxB7hBfuNHPvayOc1K02Em6aDg4wTEt8TsAvzauABSCRQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR1201MB0133;7:HgjK+JA4nO47B3zrAa6VmDBlEnMWRbaVjpRo9HZ7A4ZmPmMFjcFvB14DaMiO6uH7Sxp89k4XQmaK3mNCOCZ6S4mYVDuXs6yMijj0fe7+Khryom8mGU5S1RTdeU5T0IlrCe78NolRdlzKJei94LN4eEkQyhXFThae0+D9hk/Rm3ydklVdUxUw+tRpWWlQZf2BJd0ltrEjDHcjwe3JPIa4ozF5CI0kyzNei7q/RVLUJ3iUqFOp9exzdo4bl+RZ/96QRuE2IO+DyogujvKfyHOwixzxt0yOWKaYqk65FsxWp8jlOIuBCmuZdmArAiszKHqJQ9k8LwDPxwapvtV6Z52c0w==;20:ayjQHoAYwqJpS4mbpRPJMcH+wQCLbVS+1j0zj/PDbiJoSM1cGVyKKWZay9bH39DRc0euPRJJuHg8ISOk1RKlD/+LSjAjZVnYXS4DZ+CtPoUewOp/PYlLs0Wr+/cv+NsADYSJWHh3MlvRAIO5mulcdlVJbkU2Vftg1kxJkMpHLw2RndKh6IVcbTIZBEo3k6vJj4V7MCpQQAS6K9mr7I9eslSoLzEmT7SNA5qZoLa4meiVlanaEIy8bMUfVIVi1dg+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2017 20:41:59.4221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0133 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yazen Ghannam The value of MCA_STATUS is used as the MSR when clearing MCA_STATUS. This may cause the following warning: unchecked MSR access error: WRMSR to 0x11b (tried to write 0x0000000000000000) Call Trace: ? amd_threshold_interrupt+0x209/0x220 smp_threshold_interrupt+0x1b/0x40 threshold_interrupt+0x89/0x90 Use msr_stat instead which has the MSR address. Fixes: 37d43acfd79f ("x86/mce/AMD: Redo error logging from APIC LVT interrupt handlers") Signed-off-by: Yazen Ghannam --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index d00f299..d11f94e 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -815,7 +815,7 @@ _log_error_bank(unsigned int bank, u32 msr_stat, u32 msr_addr, u64 misc) __log_error(bank, status, addr, misc); - wrmsrl(status, 0); + wrmsrl(msr_stat, 0); return status & MCI_STATUS_DEFERRED; } -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] x86/mce/AMD: Use msr_stat when clearing MCA_STATUS From: Yazen Ghannam Message-Id: <1495658507-7413-1-git-send-email-Yazen.Ghannam@amd.com> Date: Wed, 24 May 2017 15:41:45 -0500 To: linux-edac@vger.kernel.org Cc: Borislav Petkov , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, Yazen Ghannam List-ID: RnJvbTogWWF6ZW4gR2hhbm5hbSA8eWF6ZW4uZ2hhbm5hbUBhbWQuY29tPgoKVGhlIHZhbHVlIG9m IE1DQV9TVEFUVVMgaXMgdXNlZCBhcyB0aGUgTVNSIHdoZW4gY2xlYXJpbmcgTUNBX1NUQVRVUy4K ClRoaXMgbWF5IGNhdXNlIHRoZSBmb2xsb3dpbmcgd2FybmluZzoKIHVuY2hlY2tlZCBNU1IgYWNj ZXNzIGVycm9yOiBXUk1TUiB0byAweDExYiAodHJpZWQgdG8gd3JpdGUgMHgwMDAwMDAwMDAwMDAw MDAwKQogQ2FsbCBUcmFjZToKICA8SVJRPgogID8gYW1kX3RocmVzaG9sZF9pbnRlcnJ1cHQrMHgy MDkvMHgyMjAKICBzbXBfdGhyZXNob2xkX2ludGVycnVwdCsweDFiLzB4NDAKICB0aHJlc2hvbGRf aW50ZXJydXB0KzB4ODkvMHg5MAoKVXNlIG1zcl9zdGF0IGluc3RlYWQgd2hpY2ggaGFzIHRoZSBN U1IgYWRkcmVzcy4KCkZpeGVzOiAzN2Q0M2FjZmQ3OWYgKCJ4ODYvbWNlL0FNRDogUmVkbyBlcnJv ciBsb2dnaW5nIGZyb20gQVBJQyBMVlQgaW50ZXJydXB0IGhhbmRsZXJzIikKU2lnbmVkLW9mZi1i eTogWWF6ZW4gR2hhbm5hbSA8eWF6ZW4uZ2hhbm5hbUBhbWQuY29tPgotLS0KIGFyY2gveDg2L2tl cm5lbC9jcHUvbWNoZWNrL21jZV9hbWQuYyB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2Vy dGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2L2tlcm5lbC9jcHUv bWNoZWNrL21jZV9hbWQuYyBiL2FyY2gveDg2L2tlcm5lbC9jcHUvbWNoZWNrL21jZV9hbWQuYwpp bmRleCBkMDBmMjk5Li5kMTFmOTRlIDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9rZXJuZWwvY3B1L21j aGVjay9tY2VfYW1kLmMKKysrIGIvYXJjaC94ODYva2VybmVsL2NwdS9tY2hlY2svbWNlX2FtZC5j CkBAIC04MTUsNyArODE1LDcgQEAgX2xvZ19lcnJvcl9iYW5rKHVuc2lnbmVkIGludCBiYW5rLCB1 MzIgbXNyX3N0YXQsIHUzMiBtc3JfYWRkciwgdTY0IG1pc2MpCiAKIAlfX2xvZ19lcnJvcihiYW5r LCBzdGF0dXMsIGFkZHIsIG1pc2MpOwogCi0Jd3Jtc3JsKHN0YXR1cywgMCk7CisJd3Jtc3JsKG1z cl9zdGF0LCAwKTsKIAogCXJldHVybiBzdGF0dXMgJiBNQ0lfU1RBVFVTX0RFRkVSUkVEOwogfQo=