All of lore.kernel.org
 help / color / mirror / Atom feed
From: Quanxian Wang <quanxian.wang@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH] drm/i915/audio:Defined M/N doesn't work on KBL and uses automatic M/N.
Date: Fri, 26 May 2017 18:24:39 +0800	[thread overview]
Message-ID: <1495794279-6928-1-git-send-email-quanxian.wang@intel.com> (raw)

According to the bspec, when set M/N, should disable
and enable transcoder which attaching DP audio. However
the implementation will affect performance much more.

Therefore, only KBL changed to use automatic M/N.

Testing: 
DP audio testing on SKL/KBL works (MP4, speaker test case).
no audio delay in multiple resolution including 4K.

Signed-off-by: Quanxian Wang <quanxian.wang@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index d805b6e..ba4994e 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -289,6 +289,10 @@ hsw_dp_audio_config_update(struct intel_crtc *intel_crtc, enum port port,
 	enum pipe pipe = intel_crtc->pipe;
 	u32 tmp;
 
+	/* It doesn't work on KBL and uses automatic M/N. */
+	if (IS_KABYLAKE(dev_priv))
+		nm = NULL;
+
 	if (nm)
 		DRM_DEBUG_KMS("using Maud %u, Naud %u\n", nm->m, nm->n);
 	else
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2017-05-26 10:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 10:24 Quanxian Wang [this message]
2017-05-26 11:07 ` ✗ Fi.CI.BAT: warning for drm/i915/audio:Defined M/N doesn't work on KBL and uses automatic M/N Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495794279-6928-1-git-send-email-quanxian.wang@intel.com \
    --to=quanxian.wang@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.