From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1037076AbdEZOnu (ORCPT ); Fri, 26 May 2017 10:43:50 -0400 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:51593 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030623AbdEZOns (ORCPT ); Fri, 26 May 2017 10:43:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:69:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:4250:4321:5007:6238:9010:9040:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12266:12296:12438:12555:12683:12698:12737:12740:12760:12895:13069:13149:13172:13229:13230:13311:13357:13439:13870:14110:14659:14721:21080:21365:21451:21627:30054:30080:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: table73_77ec35ebf155b X-Filterd-Recvd-Size: 2207 Message-ID: <1495809822.29207.33.camel@perches.com> Subject: Re: [tip:timers/core] mmtimer: Remove the SGI SN2 mmtimer driver From: Joe Perches To: tglx@linutronix.de, hpa@zytor.com, hch@lst.de, mike.travis@hpe.com, mingo@kernel.org, sivanich@hpe.com, linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org Date: Fri, 26 May 2017 07:43:42 -0700 In-Reply-To: References: <20170526090311.3377-2-hch@lst.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-05-26 at 03:58 -0700, tip-bot for Christoph Hellwig wrote: > Commit-ID: 07903ada96139ced48f2f893fe57a26a8fbc6043 Couple trivial comments: > mmtimer: Remove the SGI SN2 mmtimer driver [] > drivers/char/mmtimer.c | 858 ---------------------------------------------- > include/uapi/linux/time.h | 6 +- [] > diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c > deleted file mode 100644 > index 0e7fcb0..0000000 > --- a/drivers/char/mmtimer.c > +++ /dev/null > @@ -1,858 +0,0 @@ > -/* [ etc...] In the future, please use git format-patch -M to avoid listing the contents of the file deletion. > diff --git a/include/uapi/linux/time.h b/include/uapi/linux/time.h [] > @@ -54,7 +54,11 @@ struct itimerval { > #define CLOCK_BOOTTIME 7 > #define CLOCK_REALTIME_ALARM 8 > #define CLOCK_BOOTTIME_ALARM 9 > -#define CLOCK_SGI_CYCLE 10 /* Hardware specific */ > +/* > + * The driver implementing this got removed. The clock ID is kept as a > + * place holder. Do not reuse! > + */ > +#define CLOCK_SGI_CYCLE 10 > #define CLOCK_TAI 11 > > #define MAX_CLOCKS 16 Here the "this" comment is a bit ambiguous. It might be better to rename CLOCK_SGI_CYCLE as well. Maybe something like CLOCK_SGI_CYCLE_DELETED_DRIVER_DONT_REUSE.