From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa6.hgst.iphmx.com ([216.71.154.45]:42683 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbdE0Vqu (ORCPT ); Sat, 27 May 2017 17:46:50 -0400 From: Bart Van Assche To: "hch@infradead.org" , "linux-block@vger.kernel.org" , "axboe@fb.com" , "ming.lei@redhat.com" Subject: Re: [PATCH v2 4/8] blk-mq: fix blk_mq_quiesce_queue Date: Sat, 27 May 2017 21:46:45 +0000 Message-ID: <1495921605.13651.2.camel@sandisk.com> References: <20170527142126.26079-1-ming.lei@redhat.com> <20170527142126.26079-5-ming.lei@redhat.com> In-Reply-To: <20170527142126.26079-5-ming.lei@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org T24gU2F0LCAyMDE3LTA1LTI3IGF0IDIyOjIxICswODAwLCBNaW5nIExlaSB3cm90ZToNCj4gSXQg aXMgcmVxdWlyZWQgdGhhdCBubyBkaXNwYXRjaCBjYW4gaGFwcGVuIGFueSBtb3JlIG9uY2UNCj4g YmxrX21xX3F1aWVzY2VfcXVldWUoKSByZXR1cm5zLCBhbmQgd2UgZG9uJ3QgaGF2ZSBzdWNoIHJl cXVpcmVtZW50DQo+IG9uIEFQSXMgb2Ygc3RvcHBpbmcgcXVldWUuDQo+IA0KPiBCdXQgYmxrX21x X3F1aWVzY2VfcXVldWUoKSBzdGlsbCBtYXkgbm90IGJsb2NrL2RyYWluIGRpc3BhdGNoIGluIHRo ZQ0KPiBmb2xsb3dpbmcgY2FzZXM6DQo+IA0KPiAtIGRpcmVjdCBpc3N1ZSBvciBCTEtfTVFfU19T VEFSVF9PTl9SVU4NCj4gLSBpbiB0aGVvcnksIG5ldyBSQ1UgcmVhZC1zaWRlIGNyaXRpY2FsIHNl Y3Rpb25zIG1heSBiZWdpbiB3aGlsZQ0KPiBzeW5jaHJvbml6ZV9yY3UoKSB3YXMgd2FpdGluZywg YW5kIGVuZCBhZnRlciBzeW5jaHJvbml6ZV9yY3UoKQ0KPiByZXR1cm5zLCBkdXJpbmcgdGhlIHBl cmlvZCBkaXNwYXRjaCBzdGlsbCBtYXkgaGFwcGVuDQoNCkhlbGxvIE1pbmcsDQoNCkkgdGhpbmsg dGhlIHRpdGxlIGFuZCB0aGUgZGVzY3JpcHRpb24gb2YgdGhpcyBwYXRjaCBhcmUgd3JvbmcuIFNp bmNlDQp0aGUgY3VycmVudCBxdWV1ZSBxdWllc2NpbmcgbWVjaGFuaXNtIHdvcmtzIGZpbmUgZm9y IGRyaXZlcnMgdGhhdCBkbw0Kbm90IHN0b3AgYW5kIHJlc3RhcnQgYSBxdWV1ZSAoZS5nLiBTQ1NJ IGFuZCBkbS1jb3JlKSwgcGxlYXNlIGNoYW5nZSB0aGUNCnRpdGxlIGFuZCBkZXNjcmlwdGlvbiB0 byByZWZsZWN0IHRoYXQgdGhlIHB1cnBvc2Ugb2YgdGhpcyBwYXRjaCBpcw0KdG8gYWxsb3cgZHJp dmVycyB0aGF0IHVzZSB0aGUgcXVpZXNjZSBtZWNoYW5pc20gdG8gcmVzdGFydCBhIHF1ZXVlDQp3 aXRob3V0IHVucXVpZXNjaW5nIGl0Lg0KDQo+IEBAIC0yMDksNiArMjE3LDkgQEAgdm9pZCBibGtf bXFfd2FrZV93YWl0ZXJzKHN0cnVjdCByZXF1ZXN0X3F1ZXVlICpxKQ0KPiAgCSAqIHRoZSBxdWV1 ZSBhcmUgbm90aWZpZWQgYXMgd2VsbC4NCj4gIAkgKi8NCj4gIAl3YWtlX3VwX2FsbCgmcS0+bXFf ZnJlZXplX3dxKTsNCj4gKw0KPiArCS8qIEZvcmNpYmx5IHVucXVpZXNjZSB0aGUgcXVldWUgdG8g YXZvaWQgaGF2aW5nIHN0dWNrIHJlcXVlc3RzICovDQo+ICsJYmxrX21xX3VucXVpZXNjZV9xdWV1 ZShxKTsNCj4gIH0NCg0KU2hvdWxkIHRoZSBibG9jayBsYXllciB1bnF1aWVzY2UgYSBxdWV1ZSBp ZiBhIGJsb2NrIGRyaXZlciBoYXNuJ3QgDQpkb25lIHRoYXQgYmVmb3JlIHF1ZXVlIHJlbW92YWwg c3RhcnRzIG9yIHNob3VsZCB0aGUgYmxvY2sgZHJpdmVyDQppdHNlbGYgZG8gdGhhdD8gVGhlIGJs b2NrIGxheWVyIGRvZXNuJ3QgcmVzdGFydCBzdG9wcGVkIHF1ZXVlcyBmcm9tDQppbnNpZGUgYmxr X3NldF9xdWV1ZV9keWluZygpIHNvIHdoeSBzaG91bGQgaXQgdW5xdWllc2NlIGEgcXVpZXNjZWQN CnF1ZXVlPw0KIA0KPiAgYm9vbCBibGtfbXFfY2FuX3F1ZXVlKHN0cnVjdCBibGtfbXFfaHdfY3R4 ICpoY3R4KQ0KPiBAQCAtMTEwOCwxMyArMTExOSwxNSBAQCBzdGF0aWMgdm9pZCBfX2Jsa19tcV9y dW5faHdfcXVldWUoc3RydWN0IGJsa19tcV9od19jdHggKmhjdHgpDQo+ICANCj4gIAlpZiAoISho Y3R4LT5mbGFncyAmIEJMS19NUV9GX0JMT0NLSU5HKSkgew0KPiAgCQlyY3VfcmVhZF9sb2NrKCk7 DQo+IC0JCWJsa19tcV9zY2hlZF9kaXNwYXRjaF9yZXF1ZXN0cyhoY3R4KTsNCj4gKwkJaWYgKCFi bGtfcXVldWVfcXVpZXNjZWQoaGN0eC0+cXVldWUpKQ0KPiArCQkJYmxrX21xX3NjaGVkX2Rpc3Bh dGNoX3JlcXVlc3RzKGhjdHgpOw0KPiAgCQlyY3VfcmVhZF91bmxvY2soKTsNCj4gIAl9IGVsc2Ug ew0KPiAgCQltaWdodF9zbGVlcCgpOw0KPiAgDQo+ICAJCXNyY3VfaWR4ID0gc3JjdV9yZWFkX2xv Y2soJmhjdHgtPnF1ZXVlX3JxX3NyY3UpOw0KPiAtCQlibGtfbXFfc2NoZWRfZGlzcGF0Y2hfcmVx dWVzdHMoaGN0eCk7DQo+ICsJCWlmICghYmxrX3F1ZXVlX3F1aWVzY2VkKGhjdHgtPnF1ZXVlKSkN Cj4gKwkJCWJsa19tcV9zY2hlZF9kaXNwYXRjaF9yZXF1ZXN0cyhoY3R4KTsNCj4gIAkJc3JjdV9y ZWFkX3VubG9jaygmaGN0eC0+cXVldWVfcnFfc3JjdSwgc3JjdV9pZHgpOw0KPiAgCX0NCj4gIH0N Cg0KU29ycnkgYnV0IEkgZG9uJ3QgbGlrZSB0aGVzZSBjaGFuZ2VzLiBXaHkgaGF2ZSB0aGUgYmxr X3F1ZXVlX3F1aWVzY2VkKCkNCmNhbGxzIGJlIGFkZGVkIGF0IG90aGVyIGNvZGUgbG9jYXRpb25z IHRoYW4gdGhlIGJsa19tcV9oY3R4X3N0b3BwZWQoKSBjYWxscz8NClRoaXMgd2lsbCBtYWtlIHRo ZSBibG9jayBsYXllciB1bm5lY2Vzc2FyeSBoYXJkIHRvIG1haW50YWluLiBQbGVhc2UgY29uc2lk ZXINCnRvIGNoYW5nZSB0aGUgYmxrX21xX2hjdHhfc3RvcHBlZChoY3R4KSBjYWxscyBpbiBibGtf bXFfc2NoZWRfZGlzcGF0Y2hfcmVxdWVzdHMoKQ0KYW5kICpibGtfbXFfKnJ1bl9od19xdWV1ZSoo KSBpbnRvIGJsa19tcV9oY3R4X3N0b3BwZWQoaGN0eCkgfHwgYmxrX3F1ZXVlX3F1aWVzY2VkKHEp Lg0KDQpUaGFua3MsDQoNCkJhcnQu