From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751251AbdE2L6q (ORCPT ); Mon, 29 May 2017 07:58:46 -0400 Received: from mail-sn1nam02on0062.outbound.protection.outlook.com ([104.47.36.62]:47980 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750954AbdE2L6n (ORCPT ); Mon, 29 May 2017 07:58:43 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; Message-ID: <1496059116.31994.6.camel@nxp.com> Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Explicitly restore CONFIG_DEBUG_FS From: Leonard Crestez To: CC: Shawn Guo , Fabio Estevam , Dong Aisheng , , Matt Fleming , Octavian Purdila , Stephen Rothwell , Date: Mon, 29 May 2017 14:58:36 +0300 In-Reply-To: <20170526154236.GY3956@linux.vnet.ibm.com> References: <49b2579b9ad2e5ce0a7c4b163dffb5a885ac7dae.1495797565.git.leonard.crestez@nxp.com> <20170526154236.GY3956@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131405327213849842;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39400400002)(39410400002)(39380400002)(39850400002)(39860400002)(39840400002)(39450400003)(2980300002)(1109001)(1110001)(339900001)(377424004)(199003)(189002)(24454002)(9170700003)(85426001)(33646002)(106466001)(47776003)(38730400002)(86362001)(36756003)(356003)(50466002)(2351001)(305945005)(104016004)(105606002)(5820100001)(498600001)(76176999)(50986999)(110136004)(8676002)(23676002)(81166006)(6246003)(229853002)(4326008)(8936002)(8656002)(50226002)(53936002)(5660300001)(54906002)(2870700001)(2950100002)(6916009)(189998001)(103116003)(2906002)(77096006)(15760500002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR03MB2565;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD026;1:adV3gjjcQfIYRe6GP91N4enKTc1IzVuMhFz6UjAsBJxNfnFkl6NDVWNHA+tC7GAE8hLQvM6kg/IUKo+J0/IapZGOgpBx28ylU95WHnJLTsJ1sj1+RNYtU3K3P14Jb+Bx+HDswQEaqNsAGLt/ZixS7+lJVBgYp770XoY7tp8j3FhcBFbddqo4H1fGEb5wabJknxpKQlLamstGWyr31n07WsSxJLVjAKc1xMss2rQqrQJaFS3ujZb+ZR1psBN+0UHqJwjTwT519GAFybLA5Uk3Omx0bmM48dsMIYl0DJLrKJ8d3ELlOzg2fY5YeKaRh4h3O3BOOymjKFVcRKlrSrG/WwVv6aSYONXPOd13lA+jCJN8uUqVVLXpDKJ46d+TGynw8XUqhcWpGy+jz5I9UPlNBdiLDkvffUi9U8Gmj9DbjkOcfmhkqwRRdsvSvho0RD1GlAJukN1t9vHtvs7JWCM2RKbF7kGuFcXtwz5tcjsrBYx8zWHjAyh9+rwp3CJXb6M3tze1aGls9k3ZFHIfuvTCK0wesN8u/GJ0MxlvWLRfaHAPNvgAqwvnUYSulEesLHDW X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR03MB2565: X-MS-Office365-Filtering-Correlation-Id: f37e4f11-9bfd-4610-8b91-08d4a68a0ca1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131430075)(201703131517081);SRVR:CY4PR03MB2565; X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2565;3:4wme72gJm5V/BULRFEWOl4run85H7obS/Bvlu062BJ/oJijV+c4AorA16Ph7HJ0CExPBglXqUnv1ksnqniWH05OaGitPSPeI/HFTKs29kB668ggC3/4RXJVxrEddhmTgZgJg6N4PS2/ybqYvl2yXdKX7dGV2Nwer/rNLsYVykrI1MHPriJBBTx/GT2MB30hwYcli/yphPIJ8lGYKPp311kXGM5D6/6w0o2EpArrKnBHDo0VldvXYv9QboF3shrcsc+P0bv2WtsnCu3ORXxB8LHFKGb06LpAZa9eW1oXyVnYz0sS3BllWh9kDP5u55pozsU2QyPLU9jQftXHVPD5MLElK0oKoCfa4ryUtXn/L935Fb1FFzx5zhmINE0hYNtVRyVri4J7LSbFBKgQacCfckFkxU7V3hrBCvnhyxVfYIEt5YBeDRel2WbP2LksSqLsE;25:L06lp+kAPUrx6vFbTkBzUeVnzXu+ZcaehzLGYkNZlokMSYtoFjNhsawLqCkZryRrD0U+mavetVN+yhbyX3MyH2RBlxLdOHdXzhzcQMU1Vuf3vD5fpXhWgCz5wLNa34kiMCapnsE5Pcq7dzlvIfWhfT6ig+5YW8fGMAYVMlTm94+6sS92SccJPxhRAq4Qs0hjD/JJeF7ONN6YRFc91lEjYFuAftVI+bvOYBzs20Lot9y7CHHxg0HYOWTgbq/TBvuJdiM/pFqtKC0rtZ2t6EVHrPGk23qKrdY7EgrmoxHnHZsTCoOVHd8ibTyNEo7We03v4R8e/U/I4EXgBz1hl8SpzTh2LpvA8bKKM32TLqYZ7w/IuuxOUgey3JD5u9QYbaFIvco71gJ/UG2GRT+mUdCW79uUaeh1fs/wXvcV+rA/N2v5fxpTPPbmNCNUI4If1vu0NXQ1XKgaeCqiZ754IxMt2LfJYramQr9p2TT1qg1QLyU= X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2565;31:CERhMPmrMLFThcuIE6tlXuvFsiWRqfsrxgc1NfzvQ4EhnFvI9c5ZA4XqhvOuyrMgAFRQtai9jCEJrY8V2qkLkb2rihj9ykhgs4zPhw/JHTz/rEN+COEx/XFKO9u++MnL64byCId0p/geRrhIGY87t7xQmLMBdLYFhMGOgPYGNPF0ayJXA9AlGW5yx/KPSKCRWJScro4QUANU0SpyoYxtvcziGw7Y/hYGXP3e8XH929VsRwYanZOxSdiGKb8Blem5Etvs4qpLBofyzOCuYtE8gA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(17755550239193); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700073)(100105000095)(100000701073)(100105300095)(100000702073)(100105100095)(6095135)(601004)(2401047)(5005006)(8121501046)(13018025)(13016025)(10201501046)(100000703073)(100105400095)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123559100)(20161123565025)(20161123563025)(20161123556025)(20161123561025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(100000704073)(100105200095)(100000705073)(100105500095);SRVR:CY4PR03MB2565;BCL:0;PCL:0;RULEID:(100000800073)(100110000095)(100000801073)(100110300095)(100000802073)(100110100095)(100000803073)(100110400095)(400006)(100000804073)(100110200095)(100000805073)(100110500095);SRVR:CY4PR03MB2565; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNTY1OzQ6SGkzY3VtZG1QUWRRRUZXR1BUNEEyNkNOQ0hG?= =?utf-8?B?ZFRYQjZNc0F5MDRBQVRFRklCQTU2ZE1kTjRuUGt5Zk9JNEpHSEtRKzhoS1BJ?= =?utf-8?B?Uk1OdU9wVWIzbS92NjNoSWhma0llMDFYTFRabnZsZWwya1REZFRWMUJwY2hU?= =?utf-8?B?MmdPOWhjUVJsazZ0T2RLMmJWbDNYTVMvWkxBLzcvVUtCU1RvN2JQbzEvY05G?= =?utf-8?B?ZEc2dDVGR0x1dUdhWjJxaGxsblRNTytoaW5WV0tNMU45bVROK0pXdVpIelpL?= =?utf-8?B?eVd3NTdBcnRKV3QxbENhMHZGbFlvb29lT1crS01kNEpocGY1WGZIdkk1OUJJ?= =?utf-8?B?bCtZTmVyQnUzaXZncUhMR05aL29KSlg4bXdUMksxRFhUeUc2K3d5OUZnelRk?= =?utf-8?B?OW13azJyZEFFSS92Z01TTkdKdUtwS0dUVUt3cW1MeGtDM3J6R2I0Tzl6VktS?= =?utf-8?B?Zm1ueGEzVnZGOGVDMXoxVG5OOG9ZOG5Uby9iQ1ltNk1ldXI1Rm1FL0RXdDhq?= =?utf-8?B?SmFRd0VWYkE2cjBNT1UwcTNybW9nMVlPQmZtcDB2VmlvM1lBTXZnVHRRcGFR?= =?utf-8?B?OWFSQ3pKeFFlMTNhamdTZnRKbVVCVkxUbFFYL3FpSE1rZ3l5Z1lSL0J1eTVn?= =?utf-8?B?RExrcDBhNS96MVhHVm5EcVlUM0NiMXNsdWRGTTcwK2w5a3ppUWl6ZTlKY252?= =?utf-8?B?SmxjZDE0cFlKT0lKNzNZMi9DTWxlZFYzVFFRUzByRUI3MTJuZXpmR1RUNTJE?= =?utf-8?B?a0FUNjVBaUh0YWRET2JpL1gwYmVQMTNMc295L2d2S0doZWlkZ2VFWlBrbWoz?= =?utf-8?B?dzJvaWVLTDZFVi9KSTRJWDY0MWh3aVVmbTB4WU1lQW9adjBCcnpjUVdOUEhW?= =?utf-8?B?ZzRTRC96blZ6M295ZGNQNDhGWGt1b1crc29ITDY3NmVoWHlmb01mTU1qWjlz?= =?utf-8?B?djBwYUg4WVE2OXdCYVU3NUZFQVhPMm1tYXVYWnBwclF4ajNlOXhFZENDclpU?= =?utf-8?B?cno4Rmp5VXMzVlNldWJ0aEVKTENWU2plUElTTTVVWGxHMnYxN1dyaWNFVk9y?= =?utf-8?B?eFJDVkZuZmx2L1VjTnJXdTE5Smh1Q3FVbWVDREFHQXFJekorMFE0RjdEZUN2?= =?utf-8?B?b3d6K0xzVVZGM04zTm9sMzFLNXBlYm92ZHlCYnI1Q2xGa2hyYUxiUVNhZG5Y?= =?utf-8?B?ZGsyM2UyK3o4T2hmcHZZTmlJZFpqdE5jNmZEWjJVTkY2b0c5VUxmSTliU1g3?= =?utf-8?B?WlNqT0lsVklud1dyUlN5M3ZsTG12MzFLMDNoTktRdm5TSnpSc04rMUNVck54?= =?utf-8?B?b0FZVzJlSU03VXRQaTRQak9NbE5aMzlremZsRFRKVkNxOEFBTDhVc0dTWXVq?= =?utf-8?B?UU50V2VFbUhXU0g2aXVNWGp1eTZab28vNldEZkptQmR3bUY3eWk2RTZUMGJ6?= =?utf-8?B?UjV2dU1hNjRralE1a0k4U3pFeWRaZG9qNDNEYUszdGN6S0ZlNEdZK1pkTzdD?= =?utf-8?B?WlpLSTdJWnBFdEpBcWVVUmdhcDN4QlUrTm1QN1QyTEdObmZVTFhreHBWb0Vk?= =?utf-8?B?TXhzVldxdUNvbWJXUmpqcUg2VjlDWGhLaklGb3JmclBDNUxxZmFRSVVXWjVl?= =?utf-8?B?cmhSTnB3ejJ5M1BObGZUVFBtdDVyNDBlV0ZuZ3FPRWZhaURLcFhTc3ZHSFk4?= =?utf-8?Q?1hnllF48mLfSprsBn1xidTylx/59tOxsp8g7Bs?= X-Forefront-PRVS: 0322B4EDE1 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjAzTUIyNTY1OzIzOm02RXR4c3Q4a28zbXp1dFhkaXdPUXRQNGlP?= =?utf-8?B?a0tza1NlRzNKSzNTaUxjVTdJTHQzV1p1YlBjWGRTSGNkakxiT3M0YkZ6OHYz?= =?utf-8?B?OFNhQ2FsK2s0Z0tRcFkzZkdESUg2OWQyOUZzZFBXOGh4UFQ3QVdQR3pBWUVi?= =?utf-8?B?b2hiSkFlMGlhYkdvT01QVVpxeTdhTisrS0JGaXpid1RxcTlEM0g0V1BZaU12?= =?utf-8?B?bWJ6ZmJIQkJ6OUkzNXVBeFpvRnZqaWFoMzhYYkN3UitlRGgvYzR1QVAxM2lh?= =?utf-8?B?Tkl6emhDSHZNTmg0a0N4YXpYWlZZNnJPQXFlSGJuOHYyMWZOVGlBdm1RVmxi?= =?utf-8?B?RzdjWlIwN2U1K0hGUmFsb2k4THB6dGkwNG5jYlB4UjhIcDhEUjUwcmdaNVA5?= =?utf-8?B?NnBPcThWOTdqZU84eUhaVW05TnJPVGlwS0JPQVhJZ2luMEl5Ym5xYVpmYytw?= =?utf-8?B?NDhuekJlVjJ0QzhhekZzNzdTeDJNTExBWDFiSk10T01KSnJPRGlnNVJSVWxi?= =?utf-8?B?MXcva2VEUTVkUERrOUFJTkZadTY2cFZ5ek9GTGdOVTNSYi9maUcvWEVFajNI?= =?utf-8?B?MXRzQ2dtR1pVSjJJalcrT1VkTHdmdE9aMDdqTDRnSm15VFJXeThLRmcvS1E4?= =?utf-8?B?N3RqT0VYcGc4TVBWVS9zbWsyOWErRlhrNWxLV2Q5UXB6OEhVWi9IaU50V1pG?= =?utf-8?B?SEtVN0h2dmc0M1liRkZzV3owd01FS3lQQzU2MDJPUWN0VzRhdDFUUWxJU1Z6?= =?utf-8?B?bS9OTnl5dGlIaVlVYnd1cTViMTdFeWF3VDJqa1h3cmZVQWtqLzJTanBiTWI1?= =?utf-8?B?NFRPalBxbHJ3QTVZSERURkNiSmNrRjdoc2x6eGF4SkF3b3Z6b1l5bWV5WE4z?= =?utf-8?B?WE9YVmdjbytGQnRSNmhGWEJhY05NT3BSVXQzSmRwMldUd3lCcldHZGpBNTdZ?= =?utf-8?B?RWxvQzJUM2oxeGFJWlJTSGhRWHFodCtoV2VVTFpENHR0UlNRVTJITmpmM0RV?= =?utf-8?B?SEZ0cXhuVnFGbW1Sd3RxTGxhL1ZkQllIRWlTV3VNbjZ4SVVmakk2QXJzd05a?= =?utf-8?B?WkFjdEM2SExXTTViMGFFa0wvTjA4aTRPMnRodDU1NVhLcTRsTWl4eWNoYm00?= =?utf-8?B?R212OWVlUy9TTVk0TDNKYVhLZVNsRS9icGYrQW54dkpMOXIyOEt2UlYyWWVr?= =?utf-8?B?dThPcEludWQrNDh3V3lydGtBT3JZSWdVcEttN1FOblA4VlhDeEc4by9DTk0z?= =?utf-8?B?NHFBdFE0WkZZMndtOWNQVzNGQWhGMHpvdVgzcm52RW9yMkZPemY0aTY0azRj?= =?utf-8?B?ZkhzTEkzUzZ5ZkhJOEhnajZ6T0tsUGlnMFQzUGE1cGpaNmYzWVdsMllabVRQ?= =?utf-8?B?a2IvUU9yaVNkQVhjUmhnMXlMbG1waW12WmczckhWNU9GQlFzVndnVVV5UVAy?= =?utf-8?B?cUNJTjhwMkRSVVRWVWFuNWlja21nOEZYWm8rWEJSK0UzTitON2s2Vnh4MzBW?= =?utf-8?B?YXBvVDhCNnpPSXRWMlJDVDJhdkdYNzVSM3ZacllJdlN0U3MwME05YlVOOURs?= =?utf-8?B?VWlJUktVWmVYSHRiblVUMmtKQ0QxeVBjS1EvMUVVNnFVNDYzVTQrcDcwQlZh?= =?utf-8?B?SmptMDZ4SDdzak5WbEJ4WXZLUENldHdYbFlOTk9xYVhLRFJtN3ZQaUgvZVRG?= =?utf-8?B?anV0RzYwUVZISEFHMHR0RElLcWRib1hvOXdLZ1QzK0VpN0N0enZkUHNYU0Jy?= =?utf-8?B?bUwzUTJEN1R0TVRqSEJlUnlBUHJmUHU1ZGlXN3VoSjFYUTZPWGUwS0g4QlVy?= =?utf-8?B?bmQ1akM1ZER3ZytUa2ZIUTZJQWxDdlNxWlhaVmlTeGNPQmhtNU8vRmVGNnJr?= =?utf-8?Q?vEATQVNUIMk0+CBLIDzt4OsTOHKc/7LI?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2565;6:NJY/N4F9R8F/jBnBM1Feb1oyRukiA+mmCeJmmx6q+YjzliJ6UdENH2kg8Fq4wLlgtz9Zt2oW6EM0I3102X2HbdaIjriAwfFl+GeJbFZokm1kQhhekxLiwqwRmiRLUPjOrCnM12FRs63ASXvkXonDua29h9oDaP2kIYCAY8/w82K/WDUfiu5/5Y+hFhUd2MCZvyCqeFFI1GQ18nGRJRzYhE4sMQsQafSEfIX9+4uf3qP1U1hb7gmCyUFaDI+7IRNUcdErsvvFIQ2LDaIUuEcLGAyNNbFdBTJgIqjW4adj9wJBgWKHE44B0g7y4IIik68rRI4yirVO4mTwMuBrOyHDcgR/z5D9NbsmrEmeet3HBL6eV6IRWQflJ7+dHcTlSJuKRezhD6ukdtDIg9Jas21YCjim2U5ZE7MEljLqY9kKEQ76dU03JvvWZNhArpXXIY19cqqG3hiz1DUyOHVqlwHckVfZQZz5dhP25XeL6S1JbsCs5IPB01uI7EU3NGly35FnjUROB7sb4DRoxc12SBiAow== X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2565;5:I/QuoXREMI0UGy88EHvlMQnu/IrRKurCKcGYIkBKN2YvDgybw7Cyp/b9D06JYCXRTzc0EPo2SQwZ75veKyfMwK+ncVWGfn63PY1zu9sAjB6UQt52fdzwS2OB8mDL8dnvsi9Xb2d+n73/FhcIwGCq7wcBJCZfY+6uGsAIqIRbu9W3Cz4iyZ3u6zLOcZ6KFvG5ANcDGd/HT1O6fAiQPrGPuXYG+QBrKcvrATvh3AsblJr66qoMyj75aUpH8TkZbKhsNwa18kxjRoW3Kj4AdoSHow33B84mOsdalPUDCFqcwMy784PTpV1TsDl6zCNedJwgVgXFqZsnfkSrQmtz7Pkrt1Wq/H4wRtbJ4g95qsIAtX07QnmD5M/SXaTtPlUemA6+GJxtBAsQss6QHuasURMpndvn9r5LzI+KU6GA7QRGVeeqIj8xZ6XNp60EATtofXtuIJJQ8Fpk97MIPyj9SIJ1+GnxNveAcyipHU2pu3gvLGcsk8oY3OV+5Du8ZsVdY99jNbHkHs4HLrSP+VzcPc8Qbg==;24:mtGWZ8or2aVlkD2evRNwSQkDhRX1gW/xkWhLYcbI2T5hV/sfwWKGIvH6s/motk2V7E5I/rvxxzgQ7RO/cHRByJyCHoDJn86v5QsJ1SnKPRA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR03MB2565;7:knpmFOkJOUsVzXIR+qm+ssx0VL+FyRxsVPDmfTKTHREncNpxJMeWA3S1RsQV2D9Ur3pVmktpdo1Ndr1UH21QgmzQMBYM57WlKI5y+Io7mhqQQeqHsrkl05HxXY+Pc6Q+QYd5Sp487JlohiFgB3QRw29ho4iuMSsUrj2OaLa6Z6QkuJTskfQLdXv/FdErdwf0/aOwzKN90nGg0d4MrbViMtwqfrZhb8P6Be1v0E5+evuNRAVY9JaCeDsXRJ1zh4J0L7L1WYGgzELixMYh4okBG0T+JaCC/iNwg/1y3DBjf2/iKDsWVHcQu7GngCW0xNaMqzeBHQbTf+746CEcAna4mw== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2017 11:58:41.1665 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2565 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-05-26 at 08:42 -0700, Paul E. McKenney wrote: > On Fri, May 26, 2017 at 02:26:06PM +0300, Leonard Crestez wrote: > > > > This option was removed by "make savedefconfig" in > > commit c5054a98bce4 ("ARM: imx_v6_v7_defconfig: Select SMSC_PHY") > > > > This happened because CONFIG_DEBUG_FS was implicitly selected by > > CONFIG_TREE_RCU_TRACE which defaulted to true because CONFIG_RCU_TRACE > > was enabled by default by commit 961518259b3b ("rcu: Enable RCU > > tracepoints by default to aid in debugging") > > > > Recently however CONFIG_RCU_TRACE was completely removed by > > commit 6e74c237c410 ("rcu: Remove debugfs tracing") > CONFIG_RCU_TRACE is still very much alive in its new home at > kernel/rcu/Kconfig.debug: Sorry, what was removed is the dependency on DEBUG_FS. In particular this snippet: diff --git a/init/Kconfig b/init/Kconfig index 2aa14ff..3025383 100644 -- - a/init/Kconfig +++ b/init/Kconfig @@ -659,14 +659,6 @@ config RCU_FAST_NO_HZ             Say N if you are unsure.   -config TREE_RCU_TRACE -       def_bool RCU_TRACE && ( TREE_RCU || PREEMPT_RCU ) -       select DEBUG_FS -       help -         This option provides tracing for the TREE_RCU and -         PREEMPT_RCU implementations, permitting Makefile to -         trivially select kernel/rcutree_trace.c. -  config RCU_BOOST         bool "Enable RCU priority boosting"         depends on RT_MUTEXES && PREEMPT_RCU && RCU_EXPERT > config RCU_TRACE > bool "Enable tracing for RCU" > depends on DEBUG_KERNEL > default y if TREE_RCU > select TRACE_CLOCK > help >   This option enables additional tracepoints for ftrace-style >   event tracing. > >   Say Y here if you want to enable RCU tracing >   Say N if you are unsure. > > That said, I need to make it default to "y" if PREEMPT_RCU as well as > the current TREE_RCU.  Would that help? I don't think you can help unless you want to make RCU_TRACE depend on DEBUG_FS for no reason. The proper fix is to have DEBUG_FS inside the imx_v6_v7_defconfig. My problem is just an unfortunate accident with default dependencies and overzealous savedefconfig. As far as I understand after recent changes RCU_TRACE is now only useful with tracepoints. Shouldn't it depend on TRACEPOINTS in some way? It's still possible to compile with RCU_TRACE on and TRACEPOINTS off, is this intentional? It seems that when this happens you're just relying on tracepoint macros to expand to nothing. Fr example maybe RCU_TRACE should be "default y if (TREE_RCU && TRACEPOINTS); depends on TRACEPOINTS"? In theory you could also "select TRACEPOINTS" but then you would end up enabling TRACEPOINTS by default in all configurations that use TREE_RCU but don't explicitly disable RCU_TRACE. I'd say that if $SUBSYSTEM_DEBUG depends on $MAJOR_DEBUG_FEATURE it should try to avoid selecting $MAJOR_DEBUG_FEATURE by default if it's not otherwise enabled. As far as I can tell this is how RCU ended up indirectly pulling in DEBUG_FS and later unexpectedly removed it. Or I could be completely wrong, kconfig can be very confusing. --  Regards, Leonard From mboxrd@z Thu Jan 1 00:00:00 1970 From: leonard.crestez@nxp.com (Leonard Crestez) Date: Mon, 29 May 2017 14:58:36 +0300 Subject: [PATCH] ARM: imx_v6_v7_defconfig: Explicitly restore CONFIG_DEBUG_FS In-Reply-To: <20170526154236.GY3956@linux.vnet.ibm.com> References: <49b2579b9ad2e5ce0a7c4b163dffb5a885ac7dae.1495797565.git.leonard.crestez@nxp.com> <20170526154236.GY3956@linux.vnet.ibm.com> Message-ID: <1496059116.31994.6.camel@nxp.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-05-26 at 08:42 -0700, Paul E. McKenney wrote: > On Fri, May 26, 2017 at 02:26:06PM +0300, Leonard Crestez wrote: > > > > This option was removed by "make savedefconfig" in > > commit c5054a98bce4 ("ARM: imx_v6_v7_defconfig: Select SMSC_PHY") > > > > This happened because CONFIG_DEBUG_FS was implicitly selected by > > CONFIG_TREE_RCU_TRACE which defaulted to true because CONFIG_RCU_TRACE > > was enabled by default by commit 961518259b3b ("rcu: Enable RCU > > tracepoints by default to aid in debugging") > > > > Recently however CONFIG_RCU_TRACE was completely removed by > > commit 6e74c237c410 ("rcu: Remove debugfs tracing") > CONFIG_RCU_TRACE is still very much alive in its new home at > kernel/rcu/Kconfig.debug: Sorry, what was removed is the dependency on DEBUG_FS. In particular this snippet: diff --git a/init/Kconfig b/init/Kconfig index 2aa14ff..3025383 100644 -- - a/init/Kconfig +++ b/init/Kconfig @@ -659,14 +659,6 @@ config RCU_FAST_NO_HZ ? ??????????Say N if you are unsure. ? -config TREE_RCU_TRACE -???????def_bool RCU_TRACE && ( TREE_RCU || PREEMPT_RCU ) -???????select DEBUG_FS -???????help -?????????This option provides tracing for the TREE_RCU and -?????????PREEMPT_RCU implementations, permitting Makefile to -?????????trivially select kernel/rcutree_trace.c. - ?config RCU_BOOST ????????bool "Enable RCU priority boosting" ????????depends on RT_MUTEXES && PREEMPT_RCU && RCU_EXPERT > config RCU_TRACE > bool "Enable tracing for RCU" > depends on DEBUG_KERNEL > default y if TREE_RCU > select TRACE_CLOCK > help > ??This option enables additional tracepoints for ftrace-style > ??event tracing. > > ??Say Y here if you want to enable RCU tracing > ??Say N if you are unsure. > > That said, I need to make it default to "y" if PREEMPT_RCU as well as > the current TREE_RCU.??Would that help? I don't think you can help unless you want to make RCU_TRACE depend on DEBUG_FS for no reason. The proper fix is to have DEBUG_FS inside the imx_v6_v7_defconfig. My problem is just an unfortunate accident with default dependencies and overzealous savedefconfig. As far as I understand after recent changes RCU_TRACE is now only useful with tracepoints. Shouldn't it depend on TRACEPOINTS in some way? It's still possible to compile with RCU_TRACE on and TRACEPOINTS off, is this intentional? It seems that when this happens you're just relying on tracepoint macros to expand to nothing. Fr example maybe RCU_TRACE should be "default y if (TREE_RCU && TRACEPOINTS); depends on TRACEPOINTS"? In theory you could also "select TRACEPOINTS" but then you would end up enabling TRACEPOINTS by default in all configurations that use TREE_RCU but don't explicitly disable RCU_TRACE. I'd say that if $SUBSYSTEM_DEBUG depends on $MAJOR_DEBUG_FEATURE it should try to avoid selecting $MAJOR_DEBUG_FEATURE by default if it's not otherwise enabled. As far as I can tell this is how RCU ended up indirectly pulling in DEBUG_FS and later unexpectedly removed it. Or I could be completely wrong, kconfig can be very confusing. --? Regards, Leonard