From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751150AbdE2MQE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 29 May 2017 08:16:04 -0400
Received: from mga06.intel.com ([134.134.136.31]:15985 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751118AbdE2MQD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 29 May 2017 08:16:03 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,414,1491289200"; 
   d="scan'208";a="93080174"
Message-ID: <1496060062.28981.15.camel@linux.intel.com>
Subject: Re: [PATCH v2 07/27] thunderbolt: Allow passing NULL to
 tb_ctl_free()
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <yehezkel.bernat@intel.com>,
        Lukas Wunner <lukas@wunner.de>, Amir Levy <amir.jer.levy@intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Mario Limonciello <Mario.Limonciello@dell.com>,
        Jared.Dominguez@dell.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date: Mon, 29 May 2017 15:14:22 +0300
In-Reply-To: <20170528081315.GF2784@lahna.fi.intel.com>
References: <20170526160936.54265-1-mika.westerberg@linux.intel.com>
         <20170526160936.54265-8-mika.westerberg@linux.intel.com>
         <CAHp75Vco+nmN_ZRv8ggWRqw-wXtpdpebCJZXTUbHq8AVVEwm3Q@mail.gmail.com>
         <20170528081315.GF2784@lahna.fi.intel.com>
Organization: Intel Finland Oy
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2017-05-28 at 11:13 +0300, Mika Westerberg wrote:
> On Sat, May 27, 2017 at 06:41:28PM +0300, Andy Shevchenko wrote:
> > On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
> > <mika.westerberg@linux.intel.com> wrote:
> > > Following the usual pattern used in many places, we allow passing
> > > NULL
> > > pointer to tb_ctl_free(). Then the user can call the function
> > > regardless
> > > if it has allocated control channel or not making the code bit
> > > simpler.
> > > 
> > 
> > +Suggested-by as you mentioned in cover letter?
> 
> OK, I'll add it.
> 
> BTW, should I do it for the other patch that was suggested by Andreas
> as
> well?

Sure


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy