From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [Resend][PATCH 01/17] rb_tree: reorganize code in rb_erase() for additional changes Date: Thu, 1 Jun 2017 00:40:54 +0200 Message-ID: <1496270454.6267.5.camel@citrix.com> References: <20170531212056.10583-1-kpraveen.lkml@gmail.com> <20170531212056.10583-2-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5347334777354876211==" Return-path: In-Reply-To: <20170531212056.10583-2-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============5347334777354876211== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-L1j4cW7KjAo6XBkk9XWl" --=-L1j4cW7KjAo6XBkk9XWl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > First, move some code around in order to make the next change more > obvious. >=20 > commit 16c047add3ceaf0ab882e3e094d1ec904d02312d from linux tree >=20 > Signed-off-by: Praveen Kumar > Mmm... actually, I am not absolutely sure of what's the formal process that we follow in this case is, but I think that: *) it is legally required (or at least preferable) that, at least the=C2=A0 Signed-off-by, of the original authors of the patches are reported=C2=A0 here; *) legally required or not, I think it's very useful to have them, and=C2= =A0 not only the S-o-b, but also the Acks, and all the other tags (like=C2= =A0 you had in the first posting of this series). You probably should=C2=A0 add your own Signed-off-by, at the bottom of the list (this, you=C2=A0 didn't do it in first posting of the series) I appreciate that you probably removed the tags to prevent git-send- email to use the enclosed email address and spam everyone, but I'm sure there is a way of telling git-send-email itself, to avoid doing that, even if you leave the tags and the emails in the patches' changelogs (something like a command line options, or similar.. I don't use it, so I can't tell). Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-L1j4cW7KjAo6XBkk9XWl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZL0Z6AAoJEBZCeImluHPuXegP/RZ5CC+65JjhXxLonkHdn6+o uAm/wsei4YEu62Igz07JYq+nyuXtZdhy03FL8nucTm+wOCvE+QOAKNSoi+RfUA1+ tiMryh3wBt2TW3qg7pu3/K/Eph0WzUs1XeP3z1EmeYTp7nrtkxZ6wWJhRer0ND0C pFgaYAQCTm96G15HQMKzUwFTLgmC7FrbV946qxiVqlwAm8b5MVxeSw4vO4l1CMTc 7M5b7lpi+4QLHUSwViTD3noc95PVKW1t8wP59VSudGDi55HUvswPVHpD5hwkXDmr Kg4KTmBzVop1Di9HCQV0GpuzYBXv7sml49Slc4TZmEkfm8gl5IaUmB+y3VPm7a6/ qByNwPv+/7suafP7zjlLHCbJDf7j6sxxG9CUMMqeAgKMLbesBOmUH4bIfQIKqaHL Ukl7vuRFvoyHKWE3Pmlw/LcXjM5KN4cz8vq3PVBPjErzxWF5BWuTQ+TRjfmhknOY FI4KbstQgJdkAloWECatWtc5vbIhC1yKttrJ9Q6msR2xc3M+PolalU5VGsbs1HLV MomFJllWrxTUZAGnE/Z4TARCQhMbqzfGZnBb4/1fOqHJPbkIj7sg29l4VZumPiJ1 KCiZl5O2nsTefTfBuvGr/qXvNvb28ztlfccT7Gt9Sgqd5fhDZUhLjf/PVnv3WMi/ 9Cpku2R5IEpayS6rdQfy =j3JE -----END PGP SIGNATURE----- --=-L1j4cW7KjAo6XBkk9XWl-- --===============5347334777354876211== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5347334777354876211==--