From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [Xen-devel[PATCH Resend v2] xen: common: rbtree:
 ported updates from linux tree
Date: Thu, 1 Jun 2017 09:43:20 +0200
Message-ID: <1496303000.6267.8.camel@citrix.com>
References: <20170531212056.10583-1-kpraveen.lkml@gmail.com>
 <592FDDAF020000780015E918@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4981971732318692542=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <592FDDAF020000780015E918@prv-mh.provo.novell.com>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Jan Beulich <JBeulich@suse.com>, Praveen Kumar <kpraveen.lkml@gmail.com>
Cc: tim@xen.org, sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4981971732318692542==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="=-gRV5uBJobJ6g6MzRuXwB"

--=-gRV5uBJobJ6g6MzRuXwB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2017-06-01 at 01:26 -0600, Jan Beulich wrote:
> > > > On 31.05.17 at 23:20, <kpraveen.lkml@gmail.com> wrote:
> > I have not imported augmented and rcu rbtree functionality to the
> > xen tree,
> > as there was no specific requirement for current planned
> > implementation.
> >=20
> Bug fixes and improvements to existing code are clearly welcome
> and need no further rationale provided here. Having looked only
> over the titles so far I see two patches which look to add new
> functionality (13 and 17).=20
>
I also have only quickly skimmed through the series for now.

Indeed 17 adds stuff which I suspect we may not need, and in any case,
I don't think it belongs in this series.

If you really need those iterators when actually using rb-tree, you'll
add the patch at that time.

13, despite its own (poor, I agree) subject line, is actually doing
some decent refactoring of the code, so I'd keep it:
<<Add __rb_change_child() as an inline helper function to replace code=C2=
=A0
that would otherwise be duplicated 4 times in the source.>>

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
--=-gRV5uBJobJ6g6MzRuXwB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZL8WZAAoJEBZCeImluHPun2MQAJ60AADA4z/0D9MPQVD0Iyjf
+KYG+D0wf+LF1PDwN8rFlnaeCQUFPrvGHxxfahGEK+TebMhLcskvBxpeL3ivLrjR
JCDvqMsSlGTFVrarAXK9LTqtWuuXhRzgq2kRoZXnAGPgwYAs1+8joVfeSMU4t5qo
v5jCb52F9QJM2hYAB4A1r4JWm6/g6p/E67LpeKJzwW3tmX2tOf1+6Frc2nnZkgBu
I5kIf1JE0qktqC1HuDjcmzqzGLXxFEDa1wCuKYuic4ScTDYFGNnCLuHwMmMhgA6Y
feh2QUA16Qj6NpRBDzfghzQf3x+Hd5F/+z/AKAoUvNhhcYTfnWrshhSH1GbIp6nw
ZkB86rcJYbMllpzP6HzCRnifHriyUb+4uSZ73L0vbOaSNQ6vzBn4q4PktP1G4tTK
vTp0cdRTQw7jJWAYbU/KrXlERuMDScb96YuX3VOgcsHuRWb6gFIICyX6mGXhZjmS
emK/rBcx4gkBQSNvSKDs3Yqvj7WT0EN6ewvhnOT4dJawgSL5wXhEqaXNbb5oSOZK
NiTfHzmsWseW9V6XMZgtJSO/tWBU1tWhnBDpJCTD7dGvlfST/HP1gaUzZ+zPRUyy
grq2OQiNx/75yAuE0mL8AegErQUQz9AFHjvy7lj8pkvj+1CL2zWcyMzuEls+9lCn
5yhkupyMZJJkqG48KBOy
=nkId
-----END PGP SIGNATURE-----

--=-gRV5uBJobJ6g6MzRuXwB--


--===============4981971732318692542==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============4981971732318692542==--