All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bmeng.cn@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] x86: fsp: Remove the call to set up internal uart in fsp_init()
Date: Thu,  1 Jun 2017 03:41:14 -0700	[thread overview]
Message-ID: <1496313674-26642-2-git-send-email-bmeng.cn@gmail.com> (raw)
In-Reply-To: <1496313674-26642-1-git-send-email-bmeng.cn@gmail.com>

First of all, it's inappropriate to call setup_internal_uart() in a
generic API fsp_init(), as CONFIG_INTERNAL_UART is an option that
is only available on BayTrail platform. Secondly even for BayTrail,
there is no need to call setup_internal_uart() at all, as Intel FSP
will do this for us.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

---

 arch/x86/lib/fsp/fsp_support.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/lib/fsp/fsp_support.c b/arch/x86/lib/fsp/fsp_support.c
index a480361..ab8340c 100644
--- a/arch/x86/lib/fsp/fsp_support.c
+++ b/arch/x86/lib/fsp/fsp_support.c
@@ -110,10 +110,6 @@ void fsp_init(u32 stack_top, u32 boot_mode, void *nvs_buf)
 	struct upd_region *fsp_upd;
 #endif
 
-#ifdef CONFIG_INTERNAL_UART
-	setup_internal_uart(1);
-#endif
-
 	fsp_hdr = find_fsp_header();
 	if (fsp_hdr == NULL) {
 		/* No valid FSP info header was found */
-- 
2.9.2

  reply	other threads:[~2017-06-01 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 10:41 [U-Boot] [PATCH 1/2] x86: baytrail: Fix boot hang with a debug build Bin Meng
2017-06-01 10:41 ` Bin Meng [this message]
2017-06-01 10:58   ` [U-Boot] [PATCH 2/2] x86: fsp: Remove the call to set up internal uart in fsp_init() Stefan Roese
2017-06-02  2:56   ` Simon Glass
2017-06-02  6:51     ` Bin Meng
2017-06-01 10:57 ` [U-Boot] [PATCH 1/2] x86: baytrail: Fix boot hang with a debug build Stefan Roese
2017-06-02  2:55 ` Simon Glass
2017-06-02  6:50   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496313674-26642-2-git-send-email-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.