From: Gerd Hoffmann <kraxel@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
edk2-devel@lists.01.org
Cc: leif.lindholm@linaro.org, jordan.l.justen@intel.com,
Shannon Zhao <zhaoshenglong@huawei.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
qemu devel list <qemu-devel@nongnu.org>,
gengdongjiu <gengdongjiu@huawei.com>,
Drew Jones <drjones@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems
Date: Fri, 02 Jun 2017 16:56:22 +0200 [thread overview]
Message-ID: <1496415382.16895.4.camel@redhat.com> (raw)
In-Reply-To: <e3a61707-2356-7ad3-0efc-e7d0c4115eea@redhat.com>
Hi,
> The reason is that old firmware is allowed to fail on new QEMU
> (regardless of machine type). Example: the WRITE_POINTER command,
> originally introduced for VMGENID. If you run a SeaBIOS binary
> without
> WRITE_POINTER support, in a QEMU VM with "-device vmgenid", the
> device
> will not work.
Old seabios will work just fine on new qemu as long as you don't use
the vmgenid device.
Only when using new features (which require firmware support) new
seabios is needed, and usually we update seabios for that reason. We
want the new features be usable of course. But in general there are no
lockstep updates for qemu and seabios (any more).
> And this patch is actually that case, because the new fw would
> allocate
> blobs with such 8-byte addresses that might not fit into 32-bit blob
> fields.
I think ovmf simply checking whenever the pointer fields are 32bit or
64bit, then doing allocations accordingly (as Igor suggested) would be
the best. Why ask qemu for a hint when ovmf can figure on its own?
That adds a new interface and new config knobs for IMO no good reason.
cheers,
Gerd
next prev parent reply other threads:[~2017-06-02 14:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170601112241.2580-1-ard.biesheuvel@linaro.org>
2017-06-01 12:25 ` [Qemu-devel] [RFC PATCH] OvmfPkg/AcpiPlatformDxe: lift 4 GB alloc limit for modern ACPI systems Laszlo Ersek
2017-06-01 15:16 ` Igor Mammedov
2017-06-01 16:37 ` Laszlo Ersek
2017-06-01 20:40 ` Laszlo Ersek
2017-06-02 14:56 ` Gerd Hoffmann [this message]
2017-06-02 22:40 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496415382.16895.4.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=drjones@redhat.com \
--cc=edk2-devel@lists.01.org \
--cc=gengdongjiu@huawei.com \
--cc=imammedo@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=leif.lindholm@linaro.org \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.