From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v3 2/4] net/virtio: skip device probe in vdpa mode Date: Sat, 31 Mar 2018 13:13:02 +0200 Message-ID: <1496487c-f3ea-dc34-dee7-dbaf40d54a97@redhat.com> References: <20180321132108.52464-4-xiao.w.wang@intel.com> <20180331022929.42172-1-xiao.w.wang@intel.com> <20180331022929.42172-3-xiao.w.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, zhihong.wang@intel.com, yliu@fridaylinux.org, jianfeng.tan@intel.com, tiwei.bie@intel.com, cunming.liang@intel.com, dan.daly@intel.com, thomas@monjalon.net, gaetan.rivet@6wind.com, anatoly.burakov@intel.com To: Xiao Wang , ferruh.yigit@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 33482354D for ; Sat, 31 Mar 2018 13:13:08 +0200 (CEST) In-Reply-To: <20180331022929.42172-3-xiao.w.wang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xiao, On 03/31/2018 04:29 AM, Xiao Wang wrote: > If we want a virtio device to work in vDPA (vhost data path acceleration) > mode, we could add a "vdpa=1" devarg for this device to specify the mode. > > This patch let virtio pmd skip device probe when detecting this parameter. > > Signed-off-by: Xiao Wang > --- > drivers/net/virtio/virtio_ethdev.c | 43 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > As we discussed, I would prefer a generic solution at EAL level. But as a start, I agree with this solution: Reviewed-by: Maxime Coquelin Thanks! Maxime