From: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] rockchip: video: rk_hdmi: fix implicit definition warnings
Date: Tue, 6 Jun 2017 09:15:14 +0200 [thread overview]
Message-ID: <1496733316-9788-2-git-send-email-philipp.tomsich@theobroma-systems.com> (raw)
In-Reply-To: <1496733316-9788-1-git-send-email-philipp.tomsich@theobroma-systems.com>
When enabling CONFIG_DISPLAY_ROCKCHIP_HDMI, compile-time warning for
the following implicitly defined functions are raised due to a missing
include directive:
drivers/video/rockchip/rk_hdmi.c: In function 'rk_hdmi_probe':
drivers/video/rockchip/rk_hdmi.c:150:2: warning: implicit declaration of function 'rk_setreg' [-Wimplicit-function-declaration]
rk_setreg(&priv->grf->soc_con6, 1 << 15);
^~~~~~~~~
drivers/video/rockchip/rk_hdmi.c:153:2: warning: implicit declaration of function 'rk_clrsetreg' [-Wimplicit-function-declaration]
rk_clrsetreg(&priv->grf->soc_con6, 1 << 4,
^~~~~~~~~~~~
This change fixes this by including <asm/hardware.h> in rk_hdmi.c.
Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
Changes in v3:
- adds an include-directive to the (pre-RK3399 enabled) rk_hdmi to
fix implicit definition warnings
Changes in v2: None
drivers/video/rockchip/rk_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/rockchip/rk_hdmi.c b/drivers/video/rockchip/rk_hdmi.c
index cd695ca..0479d6e 100644
--- a/drivers/video/rockchip/rk_hdmi.c
+++ b/drivers/video/rockchip/rk_hdmi.c
@@ -14,6 +14,7 @@
#include <regmap.h>
#include <syscon.h>
#include <asm/gpio.h>
+#include <asm/hardware.h>
#include <asm/io.h>
#include <asm/arch/clock.h>
#include <asm/arch/grf_rk3288.h>
--
1.9.1
next prev parent reply other threads:[~2017-06-06 7:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-06 7:15 [U-Boot] [PATCH 0/2] Enable video in the rk3399-puma defconfig (includes rk_hdmi.c fix for compile warning) Philipp Tomsich
2017-06-06 7:15 ` Philipp Tomsich [this message]
2017-06-06 21:09 ` [U-Boot] [PATCH 1/2] rockchip: video: rk_hdmi: fix implicit definition warnings Simon Glass
2017-06-08 3:34 ` sjg at google.com
2017-06-06 7:15 ` [U-Boot] [PATCH 2/2] rockchip: defconfig: puma-rk3399: update defconfig with video-support Philipp Tomsich
2017-06-06 21:09 ` Simon Glass
2017-06-08 3:34 ` sjg at google.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496733316-9788-2-git-send-email-philipp.tomsich@theobroma-systems.com \
--to=philipp.tomsich@theobroma-systems.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.