From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751697AbdFFUqe (ORCPT ); Tue, 6 Jun 2017 16:46:34 -0400 Received: from mga05.intel.com ([192.55.52.43]:57510 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751526AbdFFUqc (ORCPT ); Tue, 6 Jun 2017 16:46:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,307,1493708400"; d="asc'?scan'208";a="1179125712" Message-ID: <1496781986.86439.3.camel@intel.com> Subject: Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails From: Jeff Kirsher To: David Miller , jani.nikula@intel.com Cc: daniel.vetter@ffwll.ch, airlied@gmail.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, jani.nikula@linux.intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, chris@chris-wilson.co.uk, tvrtko.ursulin@intel.com, davidx.m.ertman@intel.com, bruce.w.allan@intel.com Date: Tue, 06 Jun 2017 13:46:26 -0700 In-Reply-To: <20170602.141426.713378366601051907.davem@davemloft.net> References: <20170531.110833.1362264472730468352.davem@davemloft.net> <20170531155043.3596-1-jani.nikula@intel.com> <20170531155043.3596-2-jani.nikula@intel.com> <20170602.141426.713378366601051907.davem@davemloft.net> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-P0nDB+VdAD0T/cKD8nLp" X-Mailer: Evolution 3.24.2 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-P0nDB+VdAD0T/cKD8nLp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote: > From: Jani Nikula > Date: Wed, 31 May 2017 18:50:43 +0300 >=20 > > From: Chris Wilson > >=20 > > An error during suspend (e100e_pm_suspend), >=20 > ... > > lead to complete failure: >=20 > ... > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > Refactor PM > > flows"), but it may be a later patch that introduced the non- > > recoverable > > behaviour. > >=20 > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D99847 > > Cc: Tvrtko Ursulin > > Cc: Jeff Kirsher > > Cc: Dave Ertman > > Cc: Bruce Allan > > Cc: intel-wired-lan@lists.osuosl.org > > Cc: netdev@vger.kernel.org > > Signed-off-by: Chris Wilson > > [Jani: bikeshed repainted] > > Signed-off-by: Jani Nikula >=20 > Jeff, please make sure this gets submitted to me soon. Expect it later tonight, just finishing up testing. --=-P0nDB+VdAD0T/cKD8nLp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlk3FKIACgkQ5W/vlVpL 7c7OCw//ZSpQsILqkMfAF0x0nuDBeCdDpTA0wTbgUhrnKgKile33cIwgUrSkz20U zbB9kUJB0HcIMKKVbQ0VgKH/cHTdqnXA2XeEiK8I6ec3plc+srG+NVW8AvN14fwX DsY63SzTyIkZNzRtskd8E5ZyGAxpQvBlTlc5QQ+FFOZ4q971GYWD8CiuXX6vmyfI Bk3YyGQIU0R0MLf52E0FRpDMCSC/if9DeuW8bWIwXPdrK3crSyIpSHorfmVlwL0q a7EIYe1d5xQjzeHkoqzpM3M/N1B3+VKoV7QfGYDbEsmF+BtjOGJRizeSNd90njm6 oYJ6BMBtDA4TqLP6ItU1vHF91Y69+G9tvrOxLLz3Rvud5w+BavOQFzpDqDRVVvIj DOcyOQDxPxv5baGkPs6dnEHdbu3+8+Hg4W6vwlq0ZQ/+tsLhmaFApZZtxcHkE+ok f9PSQUjv0EtprWi39hRph18Zoc/KR9/NHSoukQmqOgdmaBnFza1QnUKArQngEFbw AymbpXTb07vADuixI2AglS1gBTudU7LmiGoiDc/Qkkgu+S8lVMSOVcc7bYDPK/XK wy+lo2u13DsLpSzWM3NbFAba2h39U79DWkinH6SfSNJv/Bl3TLDZ+rGQ1BJ878IB nJ583HdqSTaa71HEZqE9FmnweCgTZLPnx9QS/iAU9iaAvsQKokE= =K+he -----END PGP SIGNATURE----- --=-P0nDB+VdAD0T/cKD8nLp-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Tue, 06 Jun 2017 13:46:26 -0700 Subject: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails In-Reply-To: <20170602.141426.713378366601051907.davem@davemloft.net> References: <20170531.110833.1362264472730468352.davem@davemloft.net> <20170531155043.3596-1-jani.nikula@intel.com> <20170531155043.3596-2-jani.nikula@intel.com> <20170602.141426.713378366601051907.davem@davemloft.net> Message-ID: <1496781986.86439.3.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote: > From: Jani Nikula > Date: Wed, 31 May 2017 18:50:43 +0300 > > > From: Chris Wilson > > > > An error during suspend (e100e_pm_suspend), > > ... > > lead to complete failure: > > ... > > The unwind failures stems from commit 2800209994f8 ("e1000e: > > Refactor PM > > flows"), but it may be a later patch that introduced the non- > > recoverable > > behaviour. > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows") > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847 > > Cc: Tvrtko Ursulin > > Cc: Jeff Kirsher > > Cc: Dave Ertman > > Cc: Bruce Allan > > Cc: intel-wired-lan at lists.osuosl.org > > Cc: netdev at vger.kernel.org > > Signed-off-by: Chris Wilson > > [Jani: bikeshed repainted] > > Signed-off-by: Jani Nikula > > Jeff, please make sure this gets submitted to me soon. Expect it later tonight, just finishing up testing. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: