From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751743AbdFHOwj (ORCPT ); Thu, 8 Jun 2017 10:52:39 -0400 Received: from smtprelay0131.hostedemail.com ([216.40.44.131]:36208 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751412AbdFHOwi (ORCPT ); Thu, 8 Jun 2017 10:52:38 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:4321:5007:6119:7619:7903:7974:8603:10004:10400:10450:10455:10848:11232:11658:11914:12048:12050:12296:12679:12740:12760:12895:13069:13138:13149:13230:13231:13311:13357:13439:14659:14721:19904:19999:21067:21080:21433:21434:21451:21627:30034:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: sugar60_50dc3c87f2a07 X-Filterd-Recvd-Size: 2399 Message-ID: <1496933554.1929.15.camel@perches.com> Subject: Re: [PATCH v1 00/25] lib, rtc: Print rtc_time via %pt[dt][rv] From: Joe Perches To: Andy Shevchenko , Rasmus Villemoes , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Date: Thu, 08 Jun 2017 07:52:34 -0700 In-Reply-To: <20170608134811.60786-1-andriy.shevchenko@linux.intel.com> References: <20170608134811.60786-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2017-06-08 at 16:47 +0300, Andy Shevchenko wrote: > Recently I have noticed too many users of struct rtc_time that printing > its content field by field. > > In this series I introduce %pt[dt][rv] specifier to make life a bit > easier. > > There are still users of detailed output of the struct rtc_time, but we > can introduce an additional extension for them in the future if needed, > otherwise they might be converted to the proposed output format. > > Some of the changes slightly modify the output. In those cases we are on > the safe side since they are pure debug. Nevertheless I tried to leave > numbers to be the same or quite close: in some cases year is printed + > 1900, though month is left in the range [0,11] instead of [1,12]. > > I didn't compile everything there, though I did a basic smoke test on > some x86 hardware. So, I rely on kbuild test robot as well :-) > > Most of the users currently are RTC drivers, thus the patch series is > assumed to go via RTC tree. What I wonder about this series is how much larger it makes a typical kernel and how often multiple rtc clocks are built for a single kernel? What is the size impact on an embedded kernel that uses a single rtc driver? trivia: Aren't there also uses of struct tm that are nearly identical? e.g.: drivers/usb/host/xhci-tegra.c