From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753129AbdFLP5N (ORCPT ); Mon, 12 Jun 2017 11:57:13 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:36078 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbdFLP5K (ORCPT ); Mon, 12 Jun 2017 11:57:10 -0400 From: Daniel Lezcano To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, Christophe Jaillet , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()' Date: Mon, 12 Jun 2017 17:55:09 +0200 Message-Id: <1497282910-19085-1-git-send-email-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20170612155441.GE2261@mai> References: <20170612155441.GE2261@mai> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Jaillet 'of_node_put()' should be called on pointer returned by 'of_parse_phandle()' when done. In this function this is done in all path except this 'continue', so add it. Fixes: 97735da074fd ("drivers: cpuidle: Add status property to ARM idle states") Signed-off-by: Christophe JAILLET Signed-off-by: Daniel Lezcano --- drivers/cpuidle/dt_idle_states.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c index ffca4fc..ae8eb03 100644 --- a/drivers/cpuidle/dt_idle_states.c +++ b/drivers/cpuidle/dt_idle_states.c @@ -180,8 +180,10 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, if (!state_node) break; - if (!of_device_is_available(state_node)) + if (!of_device_is_available(state_node)) { + of_node_put(state_node); continue; + } if (!idle_state_valid(state_node, i, cpumask)) { pr_warn("%s idle state not valid, bailing out\n", -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: [PATCH 1/2] cpuidle: dt: Add missing 'of_node_put()' Date: Mon, 12 Jun 2017 17:55:09 +0200 Message-ID: <1497282910-19085-1-git-send-email-daniel.lezcano@linaro.org> References: <20170612155441.GE2261@mai> Return-path: In-Reply-To: <20170612155441.GE2261@mai> Sender: linux-kernel-owner@vger.kernel.org To: rjw@rjwysocki.net Cc: linux-pm@vger.kernel.org, Christophe Jaillet , open list List-Id: linux-pm@vger.kernel.org From: Christophe Jaillet 'of_node_put()' should be called on pointer returned by 'of_parse_phandle()' when done. In this function this is done in all path except this 'continue', so add it. Fixes: 97735da074fd ("drivers: cpuidle: Add status property to ARM idle states") Signed-off-by: Christophe JAILLET Signed-off-by: Daniel Lezcano --- drivers/cpuidle/dt_idle_states.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c index ffca4fc..ae8eb03 100644 --- a/drivers/cpuidle/dt_idle_states.c +++ b/drivers/cpuidle/dt_idle_states.c @@ -180,8 +180,10 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, if (!state_node) break; - if (!of_device_is_available(state_node)) + if (!of_device_is_available(state_node)) { + of_node_put(state_node); continue; + } if (!idle_state_valid(state_node, i, cpumask)) { pr_warn("%s idle state not valid, bailing out\n", -- 2.7.4