On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: > --- a/xen/common/rbtree.c > +++ b/xen/common/rbtree.c > @@ -110,11 +110,8 @@ void rb_insert_color(struct rb_node *node, > struct rb_root *root) >   >              if (parent->rb_right == node) >              { > -                register struct rb_node *tmp; >                  __rb_rotate_left(parent, root); > -                tmp = parent; >                  parent = node; > -                node = tmp; >              } >   >              rb_set_black(parent); > @@ -135,11 +132,8 @@ void rb_insert_color(struct rb_node *node, > struct rb_root *root) >   >              if (parent->rb_left == node) >              { > -                register struct rb_node *tmp; >                  __rb_rotate_right(parent, root); > -                tmp = parent; >                  parent = node; > -                node = tmp; >              } >   >              rb_set_black(parent); > It looks to me like something went wrong while you applied/prepared the patch. In fact, I can see the removed lines are the same, between the patch itself and the original Linux comment, but you are not adding any code (while the original Linux commit does!) Regards, Dario -- <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)