From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754215AbdFNDIe (ORCPT ); Tue, 13 Jun 2017 23:08:34 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:62448 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753926AbdFNDId (ORCPT ); Tue, 13 Jun 2017 23:08:33 -0400 Message-ID: <1497409708.21216.2.camel@mtkswgap22> Subject: Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node From: Sean Wang To: Matthias Brugger CC: Erin Lo , , , , , Date: Wed, 14 Jun 2017 11:08:28 +0800 In-Reply-To: References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-2-git-send-email-erin.lo@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote: > > On 01/06/17 08:08, Erin Lo wrote: > > From: Sean Wang > > > > Add ethernet device node for MT2701 > > > > Signed-off-by: Sean Wang > > Signed-off-by: Erin Lo > > --- > > arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 8037210..de88bd7 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -420,6 +420,26 @@ > > #clock-cells = <1>; > > }; > > > > + eth: ethernet@1b100000 { > > + compatible = "mediatek,mt2701-eth", "syscon"; > > + reg = <0 0x1b100000 0 0x20000>; > > + interrupts = , > > + , > > + ; > > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > > + <ðsys CLK_ETHSYS_ESW>, > > + <ðsys CLK_ETHSYS_GP1>, > > + <ðsys CLK_ETHSYS_GP2>, > > + <&apmixedsys CLK_APMIXED_TRGPLL>; > > + clock-names = "ethif", "esw", "gp1", "gp2", "trgpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > > + mediatek,ethsys = <ðsys>; > > + mediatek,pctl = <&syscfg_pctl_a>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > I'm missing the reset properties. Hi Matthias, Appreciate your careful reviewing, I'll add it for the missing which causes binding violation. Sean > > Regards, > Matthias From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Wang Subject: Re: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node Date: Wed, 14 Jun 2017 11:08:28 +0800 Message-ID: <1497409708.21216.2.camel@mtkswgap22> References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-2-git-send-email-erin.lo@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthias Brugger Cc: Erin Lo , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote: > > On 01/06/17 08:08, Erin Lo wrote: > > From: Sean Wang > > > > Add ethernet device node for MT2701 > > > > Signed-off-by: Sean Wang > > Signed-off-by: Erin Lo > > --- > > arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 8037210..de88bd7 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -420,6 +420,26 @@ > > #clock-cells = <1>; > > }; > > > > + eth: ethernet@1b100000 { > > + compatible = "mediatek,mt2701-eth", "syscon"; > > + reg = <0 0x1b100000 0 0x20000>; > > + interrupts = , > > + , > > + ; > > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > > + <ðsys CLK_ETHSYS_ESW>, > > + <ðsys CLK_ETHSYS_GP1>, > > + <ðsys CLK_ETHSYS_GP2>, > > + <&apmixedsys CLK_APMIXED_TRGPLL>; > > + clock-names = "ethif", "esw", "gp1", "gp2", "trgpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > > + mediatek,ethsys = <ðsys>; > > + mediatek,pctl = <&syscfg_pctl_a>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > I'm missing the reset properties. Hi Matthias, Appreciate your careful reviewing, I'll add it for the missing which causes binding violation. Sean > > Regards, > Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sean.wang@mediatek.com (Sean Wang) Date: Wed, 14 Jun 2017 11:08:28 +0800 Subject: [PATCH 1/3] arm: dts: mt2701: Add ethernet device node In-Reply-To: References: <1496297324-21091-1-git-send-email-erin.lo@mediatek.com> <1496297324-21091-2-git-send-email-erin.lo@mediatek.com> Message-ID: <1497409708.21216.2.camel@mtkswgap22> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2017-06-09 at 10:22 +0200, Matthias Brugger wrote: > > On 01/06/17 08:08, Erin Lo wrote: > > From: Sean Wang > > > > Add ethernet device node for MT2701 > > > > Signed-off-by: Sean Wang > > Signed-off-by: Erin Lo > > --- > > arch/arm/boot/dts/mt2701.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 8037210..de88bd7 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -420,6 +420,26 @@ > > #clock-cells = <1>; > > }; > > > > + eth: ethernet at 1b100000 { > > + compatible = "mediatek,mt2701-eth", "syscon"; > > + reg = <0 0x1b100000 0 0x20000>; > > + interrupts = , > > + , > > + ; > > + clocks = <&topckgen CLK_TOP_ETHIF_SEL>, > > + <ðsys CLK_ETHSYS_ESW>, > > + <ðsys CLK_ETHSYS_GP1>, > > + <ðsys CLK_ETHSYS_GP2>, > > + <&apmixedsys CLK_APMIXED_TRGPLL>; > > + clock-names = "ethif", "esw", "gp1", "gp2", "trgpll"; > > + power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>; > > + mediatek,ethsys = <ðsys>; > > + mediatek,pctl = <&syscfg_pctl_a>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > I'm missing the reset properties. Hi Matthias, Appreciate your careful reviewing, I'll add it for the missing which causes binding violation. Sean > > Regards, > Matthias