From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 07/20] rbtree: move some implementation details from rbtree.h to rbtree.c Date: Mon, 19 Jun 2017 19:05:37 +0200 Message-ID: <1497891937.7405.13.camel@citrix.com> References: <20170617093253.3990-1-kpraveen.lkml@gmail.com> <20170617093253.3990-8-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5542872930184166776==" Return-path: In-Reply-To: <20170617093253.3990-8-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org --===============5542872930184166776== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-J81sC8HT49pKcqmtJLIp" --=-J81sC8HT49pKcqmtJLIp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2017-06-17 at 15:02 +0530, Praveen Kumar wrote: > --- a/xen/include/xen/rbtree.h > +++ b/xen/include/xen/rbtree.h > @@ -21,9 +21,7 @@ > =C2=A0 > =C2=A0struct rb_node > =C2=A0{ > The Linux commit converts this into: struct rb_node { and.. > -=C2=A0=C2=A0=C2=A0=C2=A0unsigned long=C2=A0=C2=A0rb_parent_color; > -#define RB_RED=C2=A0=C2=A00 > -#define RB_BLACK 1 > +=C2=A0=C2=A0=C2=A0=C2=A0unsigned long=C2=A0=C2=A0__rb_parent_color; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct rb_node *rb_right; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct rb_node *rb_left; > =C2=A0}; > @@ -33,21 +31,7 @@ struct rb_root > ...this struct here into: struct rb_root { The rest looks ok to me. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-J81sC8HT49pKcqmtJLIp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJZSARhAAoJEBZCeImluHPu5Z4QAJ0gt9iWndPMIPrxzN6Sfc7I CoTygG+DyTiWHk2Rgt+p73Z6wbdGKUXdGj8mDMLIF5jaopAJ8FfVXshO9CHZ/9sB ce2osjxE+q7k2LON7avkH8sBbmmu8Pq0nh+8AARq1uoPyWB6rMnLODd/87h/E/N1 Ck8Tq13h9lOmqai6kAj4X4+zOZT6UKXFSZZtp/sMiP48Av9kw0A65iTk3UgsOC3X 469sq5uM/hpglSE8JIZk1Gz5W7PmFwdCBed6HL27o8jT86IICGlcws6JCpCf/WRb sbJ8aX1IHpM68WEiFw+lF2R71TqE/sooURqZDAn+e8SQo5mhSMlv6XHtjo4qlXcq gcg4izQphiQdpfSULsLwSOxgzydmI1lutTI4SKHpEvTGwIFU8N9cRHnJaT8AfT1B xyBTclfI0EH7s/+ZFn4t4Ri1qxfP7A4PY1jwfNaJNzUcLBlFfmL5nHcBXzd1748r vgZaBJ2WGLlo+kXIxRwtqEhN2q5fNOXQDM+2emajPA0Ys2TTjw/Im2+3+t+WXF28 4nxm88iFsAA602DznN2osYAD0oJ6aaUYHuyrHqOE4lAEhzIikrANo+T1HSb0SyGK KjJ/gWbIaICdUs4ZEIfsrVaezs3AaOyVlrLvqwaZh7TxoSiJMOpZ/s5cGXaLATlj Rf5Za1xAJ9OKQIpEumzz =SvF2 -----END PGP SIGNATURE----- --=-J81sC8HT49pKcqmtJLIp-- --===============5542872930184166776== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5542872930184166776==--