Re: [PATCH 00/20] huge gtt pages

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Matthew Auld <matthew.auld@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 00/20] huge gtt pages
Date: Tue, 27 Jun 2017 18:19:42 +0100	[thread overview]
Message-ID: <149858398251.8075.6573082566252231538@mail.alporthouse.com> (raw)
In-Reply-To: <20170627145444.20491-1-matthew.auld@intel.com>

Quoting Matthew Auld (2017-06-27 15:54:24)
> Next iteration based on feedback from Chris.
> 
> Matthew Auld (20):
>   mm/shmem: introduce shmem_file_setup_with_mnt
>   drm/i915: introduce simple gemfs
>   drm/i915/gemfs: enable THP
>   drm/i915: introduce page_size_mask to dev_info
>   drm/i915: introduce page_size members
>   drm/i915: introduce vm set_pages/clear_pages
>   drm/i915: align the vma start to the largest gtt page size
>   drm/i915: align 64K objects to 2M
>   drm/i915: enable IPS bit for 64K pages
>   drm/i915: disable GTT cache for 2M/1G pages
>   drm/i915: support 1G pages for the 48b PPGTT
>   drm/i915: support 2M pages for the 48b PPGTT
>   drm/i915: support 64K pages for the 48b PPGTT
>   drm/i915: accurate page size tracking for the ppgtt
>   drm/i915/debugfs: include some gtt page size metrics
>   drm/i915/selftests: huge page tests

Hmm, I was thinking that the huge page tests could be run on all
platforms via the mock_device, then the live tests would then check that
the real platform support for its own subset. (That way we always have
coverage of the core code even before we get platform support.)

Otherwise the series is looking pretty good. Some minor nits, but so far
nothing scary.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx