All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	James Bottomley <james.bottomley@hansenpartnership.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
	Hannes Reinecke <hare@suse.com>
Subject: [PATCH 37/47] aic79xx: use scsi device as argument for BUILD_SCSIID()
Date: Wed, 28 Jun 2017 10:33:03 +0200	[thread overview]
Message-ID: <1498638793-44672-38-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1498638793-44672-1-git-send-email-hare@suse.de>

Signed-off-by: Hannes Reinecke <hare@suse.com>
---
 drivers/scsi/aic7xxx/aic79xx_osm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/aic7xxx/aic79xx_osm.c b/drivers/scsi/aic7xxx/aic79xx_osm.c
index 0797c2f..66f9450 100644
--- a/drivers/scsi/aic7xxx/aic79xx_osm.c
+++ b/drivers/scsi/aic7xxx/aic79xx_osm.c
@@ -541,8 +541,8 @@ void ahd_insb(struct ahd_softc * ahd, long port,
 }
 
 /******************************** Macros **************************************/
-#define BUILD_SCSIID(ahd, cmd)						\
-	(((scmd_id(cmd) << TID_SHIFT) & TID) | (ahd)->our_id)
+#define BUILD_SCSIID(ahd, sdev)					\
+	(((sdev_id(sdev) << TID_SHIFT) & TID) | (ahd)->our_id)
 
 /*
  * Return a string describing the driver.
@@ -837,7 +837,7 @@ static DEF_SCSI_QCMD(ahd_linux_queue)
 	ahd_set_sense_residual(reset_scb, 0);
 	reset_scb->platform_data->xfer_len = 0;
 	reset_scb->hscb->control = 0;
-	reset_scb->hscb->scsiid = BUILD_SCSIID(ahd,cmd);
+	reset_scb->hscb->scsiid = BUILD_SCSIID(ahd, cmd->device);
 	reset_scb->hscb->lun = cmd->device->lun;
 	reset_scb->hscb->cdb_len = 0;
 	reset_scb->hscb->task_management = SIU_TASKMGMT_LUN_RESET;
@@ -1598,7 +1598,7 @@ struct scsi_host_template aic79xx_driver_template = {
 	 * Fill out basics of the HSCB.
 	 */
 	hscb->control = 0;
-	hscb->scsiid = BUILD_SCSIID(ahd, cmd);
+	hscb->scsiid = BUILD_SCSIID(ahd, cmd->device);
 	hscb->lun = cmd->device->lun;
 	scb->hscb->task_management = 0;
 	mask = SCB_GET_TARGET_MASK(ahd, scb);
-- 
1.8.5.6

  parent reply	other threads:[~2017-06-28  8:33 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-28  8:32 [PATCH 00/47] SCSI EH argument reshuffle part II Hannes Reinecke
2017-06-28  8:32 ` [PATCH 01/47] aacraid: split off functions to generate reset FIB Hannes Reinecke
2017-06-28  9:07   ` Johannes Thumshirn
2017-06-29 19:59   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 02/47] aacraid: split off host reset Hannes Reinecke
2017-06-28  9:10   ` Johannes Thumshirn
2017-06-29 20:00   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 03/47] aacraid: split off device, target, and bus reset Hannes Reinecke
2017-06-28  9:14   ` Johannes Thumshirn
2017-06-29 20:01   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 04/47] aacraid: use aac_tmf_callback for reset fib Hannes Reinecke
2017-06-28 19:42   ` Dave Carroll
2017-06-29 20:06   ` Raghava Aditya Renukunta
2017-06-30  7:19     ` Hannes Reinecke
2017-06-28  8:32 ` [PATCH 05/47] aacraid: enable sending of TMFs from aac_hba_send() Hannes Reinecke
2017-06-28  9:17   ` Johannes Thumshirn
2017-06-29 20:07   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 06/47] aacraid: add fib flag to mark scsi command callback Hannes Reinecke
2017-06-28  9:18   ` Johannes Thumshirn
2017-06-29 20:07   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 07/47] aacraid: complete all commands during bus reset Hannes Reinecke
2017-06-28  9:19   ` Johannes Thumshirn
2017-06-29 20:07   ` Raghava Aditya Renukunta
2017-06-28  8:32 ` [PATCH 08/47] sym53c8xx_2: split off bus reset from host reset Hannes Reinecke
2017-06-28  9:19   ` Johannes Thumshirn
2017-06-28  9:25   ` Johannes Thumshirn
2017-06-28  8:32 ` [PATCH 09/47] zfcp: open-code fc_block_scsi_eh() for " Hannes Reinecke
2017-07-24 16:18   ` Steffen Maier
2017-07-24 18:01     ` Hannes Reinecke
2017-07-24 16:24   ` Steffen Maier
2017-06-28  8:32 ` [PATCH 10/47] ips: Do not try to abort command from " Hannes Reinecke
2017-06-28  9:31   ` Johannes Thumshirn
2017-06-28  8:32 ` [PATCH 11/47] snic: reserve tag for TMF Hannes Reinecke
2017-06-28  9:37   ` Johannes Thumshirn
2017-06-28  8:32 ` [PATCH 12/47] qla1280: separate out host reset function from qla1280_error_action() Hannes Reinecke
2017-06-28  9:39   ` Johannes Thumshirn
2017-06-28  8:32 ` [PATCH 13/47] megaraid: pass in NULL scb for host reset Hannes Reinecke
2017-06-28  9:39   ` Johannes Thumshirn
2017-06-28 13:41   ` Sumit Saxena
2017-06-28 15:30     ` Hannes Reinecke
2017-06-28 17:40       ` Kashyap Desai
     [not found]         ` <CAHtARFFTFMaUsVZ_KuYGr3hFcTuD5sf=h2+1RM6aj8yfpwsCWQ@mail.gmail.com>
2017-06-28 18:40           ` Christoph Hellwig
2017-06-29  5:53         ` Hannes Reinecke
2017-06-29  7:51           ` Sumit Saxena
2017-06-28  8:32 ` [PATCH 14/47] scsi: Use Scsi_Host as argument for eh_host_reset_handler Hannes Reinecke
2017-07-24 16:55   ` Steffen Maier
2017-06-28  8:32 ` [PATCH 15/47] scsi_transport_fc: Use fc_rport as argument for fc_block_scsi_eh Hannes Reinecke
2017-07-24 16:34   ` Steffen Maier
2017-06-28  8:32 ` [PATCH 16/47] mptfc: simplify mpt_fc_block_error_handler() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 17/47] mptfusion: correct definitions for mptscsih_dev_reset() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 18/47] mptfc: open-code mptfc_block_error_handler() for bus reset Hannes Reinecke
2017-06-28  8:32 ` [PATCH 19/47] pmcraid: Select device in pmcraid_eh_bus_reset_handler() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 20/47] scsi: Use Scsi_Host and channel number as argument for eh_bus_reset_handler() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 21/47] libiscsi: use cls_session as argument for target and session reset Hannes Reinecke
2017-06-28  8:32 ` [PATCH 22/47] bnx2fc: Do not rely on a scsi command when issueing lun or target reset Hannes Reinecke
2017-06-28  8:32 ` [PATCH 23/47] zfcp: do not rely on scsi command for debugging message Hannes Reinecke
2017-06-28  8:32 ` [PATCH 24/47] zfcp: use scsi device as argument for zfcp_task_mgmt_function() Hannes Reinecke
2017-07-24 17:15   ` Steffen Maier
2017-07-25 14:14     ` Hannes Reinecke
2017-06-28  8:32 ` [PATCH 25/47] ibmvfc: open-code reset loop for target reset Hannes Reinecke
2017-06-28  8:32 ` [PATCH 26/47] lpfc: use rport as argument for lpfc_send_taskmgmt() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 27/47] lpfc: use rport as argument for lpfc_chk_tgt_mapped() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 28/47] qla2xxx: open-code qla2xxx_generic_reset() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 29/47] qedf: use fc rport as argument for qedf_initiate_tmf() Hannes Reinecke
2017-06-28  8:32 ` [PATCH 30/47] sym53c8xx_2: rework reset handling Hannes Reinecke
2017-06-28  8:32 ` [PATCH 31/47] bfa: Do not use scsi command to signal TMF status Hannes Reinecke
2017-06-28  8:32 ` [PATCH 32/47] scsi: Use scsi_target as argument for eh_target_reset_handler() Hannes Reinecke
2017-07-24 18:10   ` Steffen Maier
2017-07-25 14:19     ` Hannes Reinecke
2017-08-02 16:52       ` Steffen Maier
2017-06-28  8:32 ` [PATCH 33/47] cxlflash: use dedicated reset command in send_tmf() Hannes Reinecke
2017-06-28 16:29   ` Matthew R. Ochs
2017-06-28  8:33 ` [PATCH 34/47] aha152x: look for stuck command when resetting device Hannes Reinecke
2017-06-28  8:33 ` [PATCH 35/47] fnic: use dedicated device reset command Hannes Reinecke
2017-06-28  8:33 ` [PATCH 36/47] a1000u2w: do not rely on the command for inia100_device_reset() Hannes Reinecke
2017-06-28  8:33 ` Hannes Reinecke [this message]
2017-06-28  8:33 ` [PATCH 38/47] aic7xxx: use scsi device as argument for BUILD_SCSIID() Hannes Reinecke
2017-06-28  8:33 ` [PATCH 39/47] aic79xx: do not reference scsi command when resetting device Hannes Reinecke
2017-06-28  8:33 ` [PATCH 40/47] aic7xxx: " Hannes Reinecke
2017-06-28  8:33 ` [PATCH 41/47] xen-scsifront: add scsi device as argument to scsifront_do_request() Hannes Reinecke
2017-06-28  8:33 ` [PATCH 42/47] xen-scsifront: call scsifront_action_handler() with a NULL command argument Hannes Reinecke
2017-06-28  8:33 ` [PATCH 43/47] fas216: Rework device reset to not rely on SCSI command pointer Hannes Reinecke
2017-06-28  8:33 ` [PATCH 44/47] csiostor: use separate TMF command Hannes Reinecke
2017-06-28  8:33 ` [PATCH 45/47] snic: use dedicated device reset command Hannes Reinecke
2017-06-28  8:33 ` [PATCH 46/47] scsi: Move eh_device_reset_handler() to use scsi_device as argument Hannes Reinecke
2017-07-24 18:42   ` Steffen Maier
2017-06-28  8:33 ` [PATCH 47/47] scsi: Do not allocate scsi command in scsi_ioctl_reset() Hannes Reinecke
2017-06-28 14:06 ` [PATCH 00/47] SCSI EH argument reshuffle part II Christoph Hellwig
2018-01-08 11:26 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498638793-44672-38-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=hare@suse.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.