All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "laurent.pinchart+renesas@ideasonboard.com"
	<laurent.pinchart+renesas@ideasonboard.com>
Cc: "daniel.vetter@intel.com" <daniel.vetter@intel.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/8] drm: arcpgu: Remove CRTC .commit() helper operation
Date: Wed, 28 Jun 2017 08:36:02 +0000	[thread overview]
Message-ID: <1498638961.3496.23.camel@synopsys.com> (raw)
In-Reply-To: <20170627211621.27767-1-laurent.pinchart+renesas@ideasonboard.com>

Hi Laurent,

On Wed, 2017-06-28 at 00:16 +0300, Laurent Pinchart wrote:
> The CRTC helper .commit() operation is legacy code, the atomic helpers
> prefer the .enable() operation. As the arcpgu driver implements the
> .enable() operation, .commit() is never used and can be removed.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/arc/arcpgu_crtc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c
> index 611af74a31c0..51745608e09d 100644
> --- a/drivers/gpu/drm/arc/arcpgu_crtc.c
> +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c
> @@ -164,7 +164,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = {
>  	.enable		= arc_pgu_crtc_enable,
>  	.disable	= arc_pgu_crtc_disable,
>  	.prepare	= arc_pgu_crtc_disable,
> -	.commit		= arc_pgu_crtc_enable,
>  	.atomic_begin	= arc_pgu_crtc_atomic_begin,
>  };

Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-06-28  8:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 20:38 [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult Laurent Pinchart
2017-06-27 20:38 ` [PATCH 1/8] drm: arcpgu: Remove CRTC .commit() helper operation Laurent Pinchart
2017-06-27 20:38 ` [PATCH 2/8] drm: arcpgu: Remove CRTC .prepare() " Laurent Pinchart
2017-06-27 20:38 ` [PATCH 3/8] drm: qxl: Remove unused CRTC .dpms() " Laurent Pinchart
2017-06-27 20:38 ` [PATCH 4/8] drm: qxl: Replace CRTC .commit() helper operation with .enable() Laurent Pinchart
2017-06-27 20:38 ` [PATCH 5/8] drm: vmwgfx: Remove unneeded CRTC .prepare() helper operation Laurent Pinchart
2017-06-27 20:38 ` [PATCH 6/8] drm: vmwgfx: Replace CRTC .commit() helper operation with .enable() Laurent Pinchart
2017-06-28  7:39   ` Daniel Vetter
2017-06-28  8:25     ` Laurent Pinchart
2017-06-27 20:38 ` [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function Laurent Pinchart
2017-06-27 20:38 ` [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable() Laurent Pinchart
2017-06-27 21:16 ` [PATCH 1/8] drm: arcpgu: Remove CRTC .commit() helper operation Laurent Pinchart
2017-06-28  8:36   ` Alexey Brodkin [this message]
2017-06-27 21:16 ` [PATCH 2/8] drm: arcpgu: Remove CRTC .prepare() " Laurent Pinchart
2017-06-28  8:36   ` Alexey Brodkin
2017-06-27 21:16 ` [PATCH 3/8] drm: qxl: Remove unused CRTC .dpms() " Laurent Pinchart
2017-06-27 21:16 ` [PATCH 4/8] drm: qxl: Replace CRTC .commit() helper operation with .enable() Laurent Pinchart
2017-06-28  8:14   ` Daniel Vetter
2017-06-27 21:16 ` [PATCH 5/8] drm: vmwgfx: Remove unneeded CRTC .prepare() helper operation Laurent Pinchart
2017-06-29 12:56   ` Thomas Hellstrom
2017-06-27 21:16 ` [PATCH 6/8] drm: vmwgfx: Replace CRTC .commit() helper operation with .enable() Laurent Pinchart
2017-06-29 12:58   ` Thomas Hellstrom
2017-06-27 21:16 ` [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function Laurent Pinchart
2017-06-28  6:46   ` Maxime Ripard
2017-06-28  7:42   ` Daniel Vetter
2017-06-28 11:55     ` Laurent Pinchart
2017-06-28  8:15   ` Philipp Zabel
2017-06-28  8:37   ` Alexey Brodkin
2017-06-28  8:43   ` Boris Brezillon
2017-06-28 13:41   ` Liviu Dudau
2017-06-28 13:44     ` Laurent Pinchart
2017-06-28 13:55   ` dri-devel-bounces
2017-06-29  7:48   ` Philippe CORNU
2017-06-29  8:00   ` Vincent ABRIOU
2017-06-29 12:59   ` Thomas Hellstrom
2017-07-03  8:57   ` Jyri Sarha
2017-06-27 21:16 ` [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable() Laurent Pinchart
2017-06-28  6:47   ` Maxime Ripard
2017-06-28  8:15   ` Philipp Zabel
2017-06-28  8:39   ` Alexey Brodkin
2017-06-28  8:45   ` Boris Brezillon
2017-06-29  7:49   ` Philippe CORNU
2017-06-29  8:00   ` Vincent ABRIOU
2017-06-29 13:00   ` Thomas Hellstrom
2017-07-03  8:53   ` Jyri Sarha
2017-06-28  8:16 ` [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult Daniel Vetter
2017-06-28  8:20   ` Daniel Vetter
2017-06-28  8:23     ` Laurent Pinchart
2017-06-28 11:27 ` Emil Velikov
2017-06-28 13:10   ` Laurent Pinchart
2017-06-29 12:39     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1498638961.3496.23.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.