From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Message-ID: <1498767443.5710.1.camel@poochiereds.net> Subject: Re: [PATCH v8 03/18] fs: check for writeback errors after syncing out buffers in generic_file_fsync From: Jeff Layton To: Christoph Hellwig , jlayton@kernel.org Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , Carlos Maiolino , Eryu Guan , David Howells , Liu Bo , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Date: Thu, 29 Jun 2017 16:17:23 -0400 In-Reply-To: <20170629141933.GE17251@infradead.org> References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-4-jlayton@kernel.org> <20170629141933.GE17251@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote: > On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@kernel.org wrote: > > From: Jeff Layton > > > > ext2 currently does a test+clear of the AS_EIO flag, which is > > is problematic for some coming changes. > > > > What we really need to do instead is call filemap_check_errors > > in __generic_file_fsync after syncing out the buffers. That > > will be sufficient for this case, and help other callers detect > > these errors properly as well. > > > > With that, we don't need to twiddle it in ext2. > > Seems like much of this code is getting replaced later in the > series.. It does. I suppose I could squash this in with the __generic_file_fsync patch. -- Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:35711 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753163AbdF2URc (ORCPT ); Thu, 29 Jun 2017 16:17:32 -0400 Received: by mail-qk0-f195.google.com with SMTP id 16so13037131qkg.2 for ; Thu, 29 Jun 2017 13:17:32 -0700 (PDT) Message-ID: <1498767443.5710.1.camel@poochiereds.net> Subject: Re: [PATCH v8 03/18] fs: check for writeback errors after syncing out buffers in generic_file_fsync From: Jeff Layton To: Christoph Hellwig , jlayton@kernel.org Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , Carlos Maiolino , Eryu Guan , David Howells , Liu Bo , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Date: Thu, 29 Jun 2017 16:17:23 -0400 In-Reply-To: <20170629141933.GE17251@infradead.org> References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-4-jlayton@kernel.org> <20170629141933.GE17251@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote: > On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@kernel.org wrote: > > From: Jeff Layton > > > > ext2 currently does a test+clear of the AS_EIO flag, which is > > is problematic for some coming changes. > > > > What we really need to do instead is call filemap_check_errors > > in __generic_file_fsync after syncing out the buffers. That > > will be sufficient for this case, and help other callers detect > > these errors properly as well. > > > > With that, we don't need to twiddle it in ext2. > > Seems like much of this code is getting replaced later in the > series.. It does. I suppose I could squash this in with the __generic_file_fsync patch. -- Jeff Layton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1498767443.5710.1.camel@poochiereds.net> Subject: Re: [PATCH v8 03/18] fs: check for writeback errors after syncing out buffers in generic_file_fsync From: Jeff Layton To: Christoph Hellwig , jlayton@kernel.org Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , Carlos Maiolino , Eryu Guan , David Howells , Liu Bo , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Date: Thu, 29 Jun 2017 16:17:23 -0400 In-Reply-To: <20170629141933.GE17251@infradead.org> References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-4-jlayton@kernel.org> <20170629141933.GE17251@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote: > On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@kernel.org wrote: > > From: Jeff Layton > > > > ext2 currently does a test+clear of the AS_EIO flag, which is > > is problematic for some coming changes. > > > > What we really need to do instead is call filemap_check_errors > > in __generic_file_fsync after syncing out the buffers. That > > will be sufficient for this case, and help other callers detect > > these errors properly as well. > > > > With that, we don't need to twiddle it in ext2. > > Seems like much of this code is getting replaced later in the > series.. It does. I suppose I could squash this in with the __generic_file_fsync patch. -- Jeff Layton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f197.google.com (mail-qt0-f197.google.com [209.85.216.197]) by kanga.kvack.org (Postfix) with ESMTP id 2E22C6B0292 for ; Thu, 29 Jun 2017 16:17:28 -0400 (EDT) Received: by mail-qt0-f197.google.com with SMTP id h15so45588637qte.0 for ; Thu, 29 Jun 2017 13:17:28 -0700 (PDT) Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com. [2607:f8b0:400d:c09::244]) by mx.google.com with ESMTPS id o190si5462415qkc.109.2017.06.29.13.17.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jun 2017 13:17:27 -0700 (PDT) Received: by mail-qk0-x244.google.com with SMTP id v143so250589qkb.3 for ; Thu, 29 Jun 2017 13:17:26 -0700 (PDT) Message-ID: <1498767443.5710.1.camel@poochiereds.net> Subject: Re: [PATCH v8 03/18] fs: check for writeback errors after syncing out buffers in generic_file_fsync From: Jeff Layton Date: Thu, 29 Jun 2017 16:17:23 -0400 In-Reply-To: <20170629141933.GE17251@infradead.org> References: <20170629131954.28733-1-jlayton@kernel.org> <20170629131954.28733-4-jlayton@kernel.org> <20170629141933.GE17251@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Hellwig , jlayton@kernel.org Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , Carlos Maiolino , Eryu Guan , David Howells , Liu Bo , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org On Thu, 2017-06-29 at 07:19 -0700, Christoph Hellwig wrote: > On Thu, Jun 29, 2017 at 09:19:39AM -0400, jlayton@kernel.org wrote: > > From: Jeff Layton > > > > ext2 currently does a test+clear of the AS_EIO flag, which is > > is problematic for some coming changes. > > > > What we really need to do instead is call filemap_check_errors > > in __generic_file_fsync after syncing out the buffers. That > > will be sufficient for this case, and help other callers detect > > these errors properly as well. > > > > With that, we don't need to twiddle it in ext2. > > Seems like much of this code is getting replaced later in the > series.. It does. I suppose I could squash this in with the __generic_file_fsync patch. -- Jeff Layton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org