From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CE1C433F5 for ; Sat, 25 Sep 2021 13:07:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7A516124B for ; Sat, 25 Sep 2021 13:07:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245362AbhIYNJH (ORCPT ); Sat, 25 Sep 2021 09:09:07 -0400 Received: from ciao.gmane.io ([116.202.254.214]:37126 "EHLO ciao.gmane.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234877AbhIYNJC (ORCPT ); Sat, 25 Sep 2021 09:09:02 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1mU7Oo-0008Iy-BP for linux-kernel@vger.kernel.org; Sat, 25 Sep 2021 15:07:26 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: linux-kernel@vger.kernel.org From: Christophe JAILLET Subject: Re: [PATCH 3/4] net: sis: Fix a function name in comments Date: Sat, 25 Sep 2021 15:07:22 +0200 Message-ID: <1498cb33-bbd1-ccb7-0ea3-12b319e18dbe@wanadoo.fr> References: <20210925125042.1629-1-caihuoqing@baidu.com> <20210925125042.1629-3-caihuoqing@baidu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210925125042.1629-3-caihuoqing@baidu.com> Content-Language: fr Cc: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 25/09/2021 à 14:50, Cai Huoqing a écrit : > Use dma_alloc_coherent() instead of pci_alloc_consistent(), > because only dma_alloc_coherent() is called here. > > Signed-off-by: Cai Huoqing > --- > drivers/net/ethernet/sis/sis190.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c > index 3d1a18a01ce5..7e107407476a 100644 > --- a/drivers/net/ethernet/sis/sis190.c > +++ b/drivers/net/ethernet/sis/sis190.c > @@ -1070,7 +1070,7 @@ static int sis190_open(struct net_device *dev) > > /* > * Rx and Tx descriptors need 256 bytes alignment. > - * pci_alloc_consistent() guarantees a stronger alignment. > + * dma_alloc_consistent() guarantees a stronger alignment. > */ > tp->TxDescRing = dma_alloc_coherent(&pdev->dev, TX_RING_BYTES, > &tp->tx_dma, GFP_KERNEL); > Hi, s/consistent/coherent/ CJ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 093C4C433EF for ; Sat, 25 Sep 2021 13:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB8F0610D1 for ; Sat, 25 Sep 2021 13:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245454AbhIYNJI (ORCPT ); Sat, 25 Sep 2021 09:09:08 -0400 Received: from smtp09.smtpout.orange.fr ([80.12.242.131]:23231 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245170AbhIYNJG (ORCPT ); Sat, 25 Sep 2021 09:09:06 -0400 Received: from [192.168.1.18] ([90.126.248.220]) by mwinf5d11 with ME id yD7N250044m3Hzu03D7NbK; Sat, 25 Sep 2021 15:07:30 +0200 X-ME-Helo: [192.168.1.18] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 25 Sep 2021 15:07:30 +0200 X-ME-IP: 90.126.248.220 Subject: Re: [PATCH 3/4] net: sis: Fix a function name in comments To: Cai Huoqing Cc: Chris Snook , "David S. Miller" , Jakub Kicinski , Michael Chan , Francois Romieu , Steve Glendinning , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Newsgroups: gmane.linux.kernel,gmane.linux.network References: <20210925125042.1629-1-caihuoqing@baidu.com> <20210925125042.1629-3-caihuoqing@baidu.com> From: Christophe JAILLET Message-ID: <1498cb33-bbd1-ccb7-0ea3-12b319e18dbe@wanadoo.fr> Date: Sat, 25 Sep 2021 15:07:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210925125042.1629-3-caihuoqing@baidu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20210925130722.q1MhrYU_Npa7Fk4nDU8IGxfC9QX1p13Qb2YWcB6tf3Y@z> Le 25/09/2021 à 14:50, Cai Huoqing a écrit : > Use dma_alloc_coherent() instead of pci_alloc_consistent(), > because only dma_alloc_coherent() is called here. > > Signed-off-by: Cai Huoqing > --- > drivers/net/ethernet/sis/sis190.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sis/sis190.c b/drivers/net/ethernet/sis/sis190.c > index 3d1a18a01ce5..7e107407476a 100644 > --- a/drivers/net/ethernet/sis/sis190.c > +++ b/drivers/net/ethernet/sis/sis190.c > @@ -1070,7 +1070,7 @@ static int sis190_open(struct net_device *dev) > > /* > * Rx and Tx descriptors need 256 bytes alignment. > - * pci_alloc_consistent() guarantees a stronger alignment. > + * dma_alloc_consistent() guarantees a stronger alignment. > */ > tp->TxDescRing = dma_alloc_coherent(&pdev->dev, TX_RING_BYTES, > &tp->tx_dma, GFP_KERNEL); > Hi, s/consistent/coherent/ CJ