All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure
@ 2017-07-04 10:06 Geert Uytterhoeven
  2017-07-04 10:40 ` [tip:irq/urgent] " tip-bot for Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-07-04 10:06 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Arnd Bergmann, linux-kernel, Geert Uytterhoeven

If CONFIG_SMP=n, and gcc (e.g. 4.1.2) decides not to inline
__irq_startup_managed(), the build fails with:

    kernel/built-in.o: In function `irq_startup':
    (.text+0x38ed8): undefined reference to `irq_set_affinity_locked'

Fix this by forcing inlining of __irq_startup_managed().

Fixes: 761ea388e8c4e3ac ("genirq: Handle managed irqs gracefully in irq_startup()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 kernel/irq/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index ad43468e89f0e903..d171bc57e1e01830 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -234,7 +234,7 @@ __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 	return IRQ_STARTUP_MANAGED;
 }
 #else
-static int
+static __always_inline int
 __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 {
 	return IRQ_STARTUP_NORMAL;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:irq/urgent] genirq: Force inlining of __irq_startup_managed to prevent build failure
  2017-07-04 10:06 [PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure Geert Uytterhoeven
@ 2017-07-04 10:40 ` tip-bot for Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Geert Uytterhoeven @ 2017-07-04 10:40 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: hpa, arnd, tglx, geert, linux-kernel, mingo

Commit-ID:  2372a519f63829b8effcdde5f4564a7e036294f0
Gitweb:     http://git.kernel.org/tip/2372a519f63829b8effcdde5f4564a7e036294f0
Author:     Geert Uytterhoeven <geert@linux-m68k.org>
AuthorDate: Tue, 4 Jul 2017 12:06:01 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 4 Jul 2017 12:36:44 +0200

genirq: Force inlining of __irq_startup_managed to prevent build failure

If CONFIG_SMP=n, and gcc (e.g. 4.1.2) decides not to inline
__irq_startup_managed(), the build fails with:

    kernel/built-in.o: In function `irq_startup':
    (.text+0x38ed8): undefined reference to `irq_set_affinity_locked'

Fix this by forcing inlining of __irq_startup_managed().

Fixes: 761ea388e8c4e3ac ("genirq: Handle managed irqs gracefully in irq_startup()")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Link: http://lkml.kernel.org/r/1499162761-12398-1-git-send-email-geert@linux-m68k.org

---
 kernel/irq/chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 2e30d925..aa5497d 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -234,7 +234,7 @@ __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 	return IRQ_STARTUP_MANAGED;
 }
 #else
-static int
+static __always_inline int
 __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force)
 {
 	return IRQ_STARTUP_NORMAL;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-07-04 10:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-04 10:06 [PATCH] genirq: Force inlining of __irq_startup_managed to prevent build failure Geert Uytterhoeven
2017-07-04 10:40 ` [tip:irq/urgent] " tip-bot for Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.