All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	peterx@redhat.com, haoqf@linux.vnet.ibm.com,
	Laurent Vivier <lvivier@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: [Qemu-devel] [PATCH v2 4/4] doc: update TYPE_MIGRATION documents
Date: Wed,  5 Jul 2017 16:21:23 +0800	[thread overview]
Message-ID: <1499242883-2184-5-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1499242883-2184-1-git-send-email-peterx@redhat.com>

[Peter collected Eduardo's patch comment and formatted into patch]

Suggested-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
 migration/migration.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/migration/migration.c b/migration/migration.c
index dbdc121..31d46d1 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -2052,12 +2052,12 @@ static void migration_instance_init(Object *obj)
 static const TypeInfo migration_type = {
     .name = TYPE_MIGRATION,
     /*
-     * NOTE: "migration" itself is not really a device. We used
-     * TYPE_DEVICE here only to leverage some existing QDev features
-     * like "-global" properties, and HW_COMPAT_* fields (which are
-     * finally applied as global properties as well). If one day the
-     * global property feature can be migrated from QDev to QObject in
-     * general, then we can switch to QObject as well.
+     * NOTE: TYPE_MIGRATION is not really a device, as the object is
+     * not created using qdev_create(), it is not attached to the qdev
+     * device tree, and it is never realized.
+     *
+     * TODO: Make this TYPE_OBJECT once QOM provides something like
+     * TYPE_DEVICE's "-global" properties.
      */
     .parent = TYPE_DEVICE,
     .class_init = migration_class_init,
-- 
2.7.4

  parent reply	other threads:[~2017-07-05  8:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-05  8:21 [Qemu-devel] [PATCH v2 0/4] migration: fix iotest 055, only-migratable break Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 1/4] migration: fix handling for --only-migratable Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 2/4] vl: move global property, migrate init earlier Peter Xu
2017-07-05  8:21 ` [Qemu-devel] [PATCH v2 3/4] doc: add item for "-M enforce-config-section" Peter Xu
2017-07-06  2:08   ` [Qemu-devel] [PATCH v2.1 " Peter Xu
2017-07-06  8:09     ` Greg Kurz
2017-07-06  8:38       ` Peter Xu
2017-07-06 18:30     ` Eduardo Habkost
2017-07-07  2:54       ` [Qemu-devel] [PATCH v2.2 " Peter Xu
2017-07-07  6:53         ` Greg Kurz
2017-07-07 12:12         ` Eduardo Habkost
2017-07-07 12:16           ` Dr. David Alan Gilbert
2017-07-10  9:02           ` Greg Kurz
2017-07-10  9:21             ` Peter Xu
2017-07-05  8:21 ` Peter Xu [this message]
2017-07-07 13:30   ` [Qemu-devel] [PATCH v2 4/4] doc: update TYPE_MIGRATION documents Eduardo Habkost
2017-07-10 12:55 ` [Qemu-devel] [PATCH v2 0/4] migration: fix iotest 055, only-migratable break Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499242883-2184-5-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=haoqf@linux.vnet.ibm.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.